Page MenuHomePhabricator

Latest Toolforge docker images don't always have python2 installed at all
Closed, ResolvedPublic

Description

While python 2 is very much dead software, there may be unintended side effects for users where python 2 is suddenly not installed at all in some of our Toolforge docker images following the release of toollabs-webservice version 0.75.

Please reference this task when issues are found. One example is the php7.3 image. Ideally, users should migrate their code to python 3, but we may need to revive python 2 in some cases since the removal was not actually intentional.

Users may begin to notice this issue starting between 1530 UTC and 1700 UTC today when Toolforge Kubernetes was upgraded (T280340) since that includes restarting pods (which causes them to pull fresh images).

Reported on IRC and via https://github.com/slashme/parliamentdiagram/issues/109 for the parliamentdiagram tool

Event Timeline

Mentioned in SAL (#wikimedia-cloud) [2021-07-26T23:04:00Z] <bstorm> deleting pod to restart tool after adding an attempted cgi config to $HOME/.lighttpd.conf T287421

After failing to convince lighttpd to use python3, I'm trying building the php7.3 web image with the python2 package installed explicitly. If that builds, I'll push it and see how that affects things.

Mentioned in SAL (#wikimedia-cloud) [2021-07-27T00:04:21Z] <bstorm> deploy a version of the php3.7 web image that includes the python2 package with tag :testing T287421

Mentioned in SAL (#wikimedia-cloud) [2021-07-27T00:05:19Z] <bstorm> changed deployment to use the image docker-registry.tools.wmflabs.org/toolforge-php73-sssd-web:testing T287421

Change 708187 had a related patch set uploaded (by Bstorm; author: Bstorm):

[operations/docker-images/toollabs-images@master] lighttpd surprises: we don't get python2 in php images

https://gerrit.wikimedia.org/r/708187

Change 708187 merged by jenkins-bot:

[operations/docker-images/toollabs-images@master] lighttpd surprises: we don't get python2 in php images

https://gerrit.wikimedia.org/r/708187

Bstorm claimed this task.

That takes care of the php/lighttpd/cgi use case. That is the only one I am aware of at this time that needs python2. I'll close the ticket and re-open if we find another reason to install python2 in an image.

Mentioned in SAL (#wikimedia-cloud) [2021-07-27T16:20:13Z] <bstorm> built new php images with python2 on board T287421