Maniphest T287439

Replace deprecated UserLoadOptions hook in deployed extensions
Closed, ResolvedPublic
Actions

Description

According to codesearch, these extensions need to be updated to the UserLoadOptions hook.

WMF Deployed

extensions / Echo
extensions / GlobalPreferences
extensions / TwoColConflict

Details

	Subject	Repo	Branch	Lines +/-
	Hard deprecate UserLoadOptions hook	mediawiki/core	master	+4 -1

Customize query in gerrit

Related Objects

Mentioned In: rESCCd670e16d4250: Replaced deprecated UserLoadOptions hook.
rESCC1bd3c038b7e3: Merge "Replaced deprecated UserLoadOptions hook. Bug: T287439"

Event Timeline

codebug created this task.Jul 27 2021, 8:04 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 27 2021, 8:04 AM

Removing MediaWiki-User-management as this is about extension codebases (not about core).

Restricted Application added projects: Growth-Team, Community-Tech. · View Herald TranscriptJul 27 2021, 8:47 AM

• Pchelolo moved this task from Unsorted pile to UserStore pile on the Platform Team Workboards (MW Expedition) board.Jul 27 2021, 2:20 PM

Change 708842 had a related patch set uploaded (by WQuarshie; author: WQuarshie):

[mediawiki/extensions/TwoColConflict@master] Replaced deprecated hook in the extension. Bug: T287439

https://gerrit.wikimedia.org/r/708842

gerritbot added a project: Patch-For-Review.Jul 29 2021, 9:38 PM

• mewoph moved this task from Inbox to Needs Discussion on the Growth-Team board.Jul 30 2021, 9:17 PM

• mewoph edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.

• mewoph moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

ldelench_wmf moved this task from New & TBD Tickets to Engineering Backlog on the Community-Tech board.Aug 2 2021, 5:41 PM

Restricted Repository Identity mentioned this in rESCC1bd3c038b7e3: Merge "Replaced deprecated UserLoadOptions hook. Bug: T287439".Aug 3 2021, 2:29 PM

codebug mentioned this in rESCCd670e16d4250: Replaced deprecated UserLoadOptions hook..Aug 3 2021, 2:29 PM

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.18; 2021-08-09).Aug 3 2021, 3:00 PM

Now the hook is not used anymore, we can hard-deprecate it according to the deprecation process

To do that, you need to remove 'silent' => true from DeprecatedHooks in MW core. See https://gerrit.wikimedia.org/r/c/mediawiki/core/+/710063 as an example.

Change 711689 had a related patch set uploaded (by TChin; author: TChin):

[mediawiki/core@master] Hard deprecate UserLoadOptions hook

https://gerrit.wikimedia.org/r/711689

Change 711689 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate UserLoadOptions hook

https://gerrit.wikimedia.org/r/711689

• Pchelolo closed this task as Resolved.Aug 12 2021, 1:32 PM

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.19; 2021-08-16); removed MW-1.37-notes (1.37.0-wmf.18; 2021-08-09).Aug 12 2021, 2:00 PM