Page MenuHomePhabricator

Dirty diff related to link-in-link and a template
Closed, ResolvedPublic


In this edit, a dirty diff occurred where the character "-" was duplicated:

This is probably related to a link-in-link problem (and also involves a template). {{ping|...}} generates an internal link, and it was used inside an external link. The duplicated character directly follows the external link.

Event Timeline

Arlolra triaged this task as Medium priority.Jul 27 2021, 5:20 PM
Arlolra moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.
Arlolra added a subscriber: Arlolra.

Seems like a bug in wrapTextChildrenOfNode. A bare : in the dd is span wrapped but assigned dsr from neighbouring nodes which are misnested and zero'd out.

<a rel="mw:WikiLink" href="./Usuario:Jmvgpartner" title="Usuario:Jmvgpartner" data-parsoid='{"stx":"piped","a":{"href":"./Usuario:Jmvgpartner"},"sa":{"href":":usuario:Jmvgpartner"},"dsr":[314,314,null,null],"misnested":true}'>Jmvgpartner</a><span data-mw-selser-wrapper="" data-parsoid='{"dsr":[314,315,0,0]}'>:</span><span data-parsoid='{"dsr":[314,314,null,null],"misnested":true}'> dice que si lo subo se retirará inmediatamente</span>

Mind you, fixUpMisnestedTagDSR gets called on,

26 de julio, cuando <span class="template-ping" data-object-id="2" about="#mwt1" typeof="mw:Transclusion">@<a rel="mw:WikiLink" href="./User:Jmvgpartner" title="User:Jmvgpartner" data-object-id="5">Jmvgpartner</a>:</span><span data-object-id="56"> dice que si lo subo se retirará inmediatamente</span>

which leaves the : bare after the misnesting.

Change 708336 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Wrap next siblings in fixUpMisnestedTagDSR

Change 708336 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Wrap next siblings in fixUpMisnestedTagDSR

Arlolra claimed this task.

Change 708791 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.14.0-a11

Change 708791 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.14.0-a11