Dirty diff related to link-in-link and a template
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Jul 27 2021, 1:06 PM

Description

In this edit, a dirty diff occurred where the character "-" was duplicated: https://es.wikipedia.org/?diff=137268496

This is probably related to a link-in-link problem (and also involves a template). {{ping|...}} generates an internal link, and it was used inside an external link. The duplicated character directly follows the external link.

Details

	Subject	Repo	Branch	Lines +/-
	Bump wikimedia/parsoid to 0.14.0-a11	mediawiki/vendor	master	+144 K -2 K
	Wrap next siblings in fixUpMisnestedTagDSR	mediawiki/services/parsoid	master	+14 -2

Customize query in gerrit

Event Timeline

matmarex created this task.Jul 27 2021, 1:06 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 27 2021, 1:06 PM

Seems like a bug in wrapTextChildrenOfNode. A bare : in the dd is span wrapped but assigned dsr from neighbouring nodes which are misnested and zero'd out.

<a rel="mw:WikiLink" href="./Usuario:Jmvgpartner" title="Usuario:Jmvgpartner" data-parsoid='{"stx":"piped","a":{"href":"./Usuario:Jmvgpartner"},"sa":{"href":":usuario:Jmvgpartner"},"dsr":[314,314,null,null],"misnested":true}'>Jmvgpartner</a><span data-mw-selser-wrapper="" data-parsoid='{"dsr":[314,315,0,0]}'>:</span><span data-parsoid='{"dsr":[314,314,null,null],"misnested":true}'> dice que si lo subo se retirará inmediatamente</span>

Mind you, fixUpMisnestedTagDSR gets called on,

26 de julio, cuando <span class="template-ping" data-object-id="2" about="#mwt1" typeof="mw:Transclusion">@<a rel="mw:WikiLink" href="./User:Jmvgpartner" title="User:Jmvgpartner" data-object-id="5">Jmvgpartner</a>:</span><span data-object-id="56"> dice que si lo subo se retirará inmediatamente</span>

which leaves the : bare after the misnesting.

Change 708336 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Wrap next siblings in fixUpMisnestedTagDSR

https://gerrit.wikimedia.org/r/708336

gerritbot added a project: Patch-For-Review.Jul 27 2021, 7:19 PM

Change 708336 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Wrap next siblings in fixUpMisnestedTagDSR

https://gerrit.wikimedia.org/r/708336

Arlolra closed this task as Resolved.Jul 29 2021, 12:38 AM

Arlolra claimed this task.

Maintenance_bot removed a project: Patch-For-Review.Jul 29 2021, 1:10 AM

Change 708791 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):