Hi @schoenbaechler

For the 3) that shows the list of notification channels with icons and descriptions, here is the exact implementation:

Looks like there's no way to add and show the icon in the list and also the description is device dependant, which cannot see the descriptions on my Samsung S9 and Samsung S21.

Thanks @cooltey — I think that’s fine for now! One question though → what does the “Show notifications” toggle below ”Show notifications” do? Can we remove it?

In T287477#7295216, @schoenbaechler wrote:

Thanks @cooltey — I think that’s fine for now! One question though → what does the “Show notifications” toggle below ”Show notifications” do? Can we remove it?

@schoenbaechler
That's an auto-generated toggle option and it can toggle all notifications in the "Wikipedia notifications" group at once. I can check if it is possible to remove it.

Yeah I think the global “Show notifications” toggle (blue background color) will suffice @cooltey

Hi @schoenbaechler,

Here are the screenshots from Pixel 3 XL emulator:

Also, the descriptions below the notification item are system generated.

thanks @cooltey for all the specs. quickly checked the list in T288064:

• Thanks
• Talk page
• Mention
• Milestone
• Revert
• Successful mention?
• Unsuccesful mention?
• Email received
• Failed login
• Log in from an unfamiliar device
• User rights change
• Page patrolled
• Links to articles you created

A few notes and questions:

• Does Mention include 'Succesful' and 'Unsuccesful' mention notification types as well?
• What about the 'Email received' notification type, it’s not listed?
• What notifications does 'System' include?
• What about the other, not checked notification types in the list above? (is it included in System?)

Thanks!

A few questions:

• What happens to the notifications that are marked as read in secondary languages?
• If I mark something as read and decide to hide them in a secondary language, will I get it back? What about in a primary language?

In T287477#7302316, @schoenbaechler wrote:

thanks @cooltey for all the specs. quickly checked the list in T288064:

• Thanks
• Talk page
• Mention
• Milestone
• Revert
• Successful mention?
• Unsuccesful mention?
• Email received
• Failed login
• Log in from an unfamiliar device
• User rights change
• Page patrolled
• Links to articles you created

---

A few notes and questions:

• Does Mention include 'Succesful' and 'Unsuccesful' mention notification types as well?
• What about the 'Email received' notification type, it’s not listed?
• What notifications does 'System' include?
• What about the other, not checked notification types in the list above? (is it included in System?)

Thanks!

After digging into the source code of the MediaWiki extension below, I found something different between the API and the app.

https://github.com/wikimedia/mediawiki-extensions-Echo/blob/5cfc33d546512b1a3a55bfb820f106fee2999e18/extension.json#L618-L696

and these are the API provided notification categories:

system
system-noemail
system-emailonly
user-rights
other
edit-user-talk
reverted
article-linked
mention
mention-failure
mention-success
emailuser
article-reminder
thank-you-edit
watchlist
minor-watchlist

and here are what we currently have in the app:

system
system-noemail
thank-you-edit
edit-user-talk
edit-thank             => this might be a custom category.
reverted
login-fail             => this might be a custom category.
mention

Does Mention include 'Succesful' and 'Unsuccesful' mention notification types as well?

There are three different categories of mention (mention, mention-failure, mention-success), so we can separate them out. Please provide the descriptions of the categories.

What about the 'Email received' notification type, it’s not listed?

Not sure which category will show "Email received" because it has two email related categories: system-emailonly and emailuser, might be emailuser.

What notifications does 'System' include?
What about the other, not checked notification types in the list above? (is it included in System?)

If we are not explicitly set up categories in the app, all the custom categories will be considered as a system notification.

These should be matched to the list you provided:
Email received => emailuser
Failed login => login-fail
Log in from an unfamiliar device => not sure now, but I can look into this.
User rights change => user-rights
Page patrolled => watchlist or minor-watchlist
Links to articles you created => article-reminder

In T287477#7306624, @JTannerWMF wrote:

A few questions:

• What happens to the notifications that are marked as read in secondary languages?
• If I mark something as read and decide to hide them in a secondary language, will I get it back? What about in a primary language?

Hi @JTannerWMF

I didn't do this in the ticket, and I believe these questions can be a separated ticket that actually implements the "Mark all as read" function.

Suggestions for channels

Thanks a lot for the investigations @cooltey. Based on that, I suggest the following channels, per specs on Help:Notifications. Also added the levels for channel importance, per Material Design spec.

Talk page
Channel importance level: High
Description: Messages from talk pages
edit-user-talk

Mention
Channel importance level: High
Description: Someone mentions you in a page
mention
mention-failure
mention-success

Email received
Channel importance level: High
Description: Someone sent you an email through the wiki.
emailuser

Revert
Channel importance level: High
Description: One of your contributions was reverted
reverted

User rights changes
Channel importance level: High
Description: Received when your user rights change
user-rights

Thanks
Channel importance level: Default
Description: Someone thanks you for an edit
edit-thank

Milestone
Channel importance level: Default
Description: Certain edit counts are reached
thank-you-edit

Login
Channel importance level: Default
Description: Your log in activities
login-fail

System
Channel importance level: Default
Description: Messages from system
system
system-noemail
system-emailonly
article-reminder`

Links to articles you created
Channel importance level: Default
Description: Received when a new link is made to a page you created
article-linked

More questions 🤔

• Is article-reminder the Milestone notification? My understanding is that article-linked is the Links to articles you created notification. If it’s not the Milestone notification, what is it, then?
• I’m not quite sure what you mean by edit-thank and login-fail being a custom category?
  • Isn’t the edit-thank category the same as thank-you-edit (see spec)? If not, what’s the difference?
  • Is login-fail the default Failed login attempts notification?
• What are the Watchlist related notification types doing? My understanding is/was that the Watchlist currently doesn’t have notification capabilities?

Hi @schoenbaechler

• Is article-reminder the Milestone notification? My understanding is that article-linked is the Links to articles you created notification. If it’s not the Milestone notification, what is it, then?

As we discussed in the meeting, the thank-you-edit represents Milestone. If we are not sure what article-reminder is, we can consider it as a System notification.

• I’m not quite sure what you mean by edit-thank and login-fail being a custom category?
  • Isn’t the edit-thank category the same as thank-you-edit (see spec)? If not, what’s the difference?

edit-thank = Thanks
thank-you-edit = Milestone

• Is login-fail the default Failed login attempts notification?

That's true that login-fail is the default failed login attempts, and it is also true that the login-fail might be a custom notification category.

• What are the Watchlist related notification types doing? My understanding is/was that the Watchlist currently doesn’t have notification capabilities?

I have done some tests for triggering the watchlist notifications but didn't see any of them. I guess we can ignore it by now.

Here is the current implementation of the notification channels:

since we are adding three notification categories to the channel, would it be possible to provide icons for them? Thanks!
emailuser
user-rights
article-linked

Per @Pginer-WMF’s feedback → Set Links to articles you created priority to maybe low as there’s feedback from experienced users that it’s rather annoying.

This all sounds good to me @cooltey. I updated the the task’s description with the specs you provided and the new icons.

👉Please make sure to replace all icons since they have been newly designed on 24*24dp canvas for more visual harmony.

❓Also, what icon are we currently using for System notifications ?

@schoenbaechler

👉Please make sure to replace all icons since they have been newly designed on 24*24dp canvas for more visual harmony.

Done

❓Also, what icon are we currently using for System notifications ?

The current one (the last item)

I can update it to the "settings" icon, not sure if it is fine to you.

Also, what icon are we currently using for System notifications ?

I can update it to the "settings" icon, not sure if it is fine to you.

Sounds like a good suggestion to use the 'Settings' icon for system notifications @cooltey.

Pinging @cmadeo here — what type of icon are you using for system notifications (e.g. system, system-noemail, system-emailonly) on iOS?

Thanks all!

Thanks @cooltey, some feedback 👇

01) Change this label to 'All “Wikipedia” notifications` (it currently uses the word notifications twice.

02) Question — why do “Other” notifications don’t have a bell icon? Is it because of channel importance? If yes, what is the current importance level of these notifications? I think they should be set to low — do you agree with that?

Knocked this out, too, while testing other stuff. NOTE: you will need to uninstall/reinstall to see this change.

02) Question — why do “Other” notifications don’t have a bell icon? Is it because of channel importance? If yes, what is the current importance level of these notifications? I think they should be set to low — do you agree with that?

That's exactly right: the channels that have a "bell" icon are High importance, meaning that the user might hear a tone or vibration with these notifications. The ones that don't have a bell icon are low importance, and I agree that they should be.

Great work @Dbrant! 👏

In addition to the 'Low' channel importance for 'Other' notifications, we differentiate between 'High' and 'Default' (or 'Medium') channel importance levels for Wikipedia notifications, per the task’s description:

Talk page
Channel importance level: High

Mention
Channel importance level: High

Email received
Channel importance level: High

Revert
Channel importance level: High

User rights changes
Channel importance level: High

Thanks
Channel importance level: Default

Milestone
Channel importance level: Default

Login
Channel importance level: Default

System
Channel importance level: Default

Links to articles you created
Channel importance level: Default

This is a direct representation of the triage made in T288064 ('All' and 'Mentions'). 'Default' maps to 'Medium' per Notification importance spec, which does not trigger sound. Do you see any disadvantages in doing this @Dbrant?

(Maybe this discussion is of interest to @JTanner as well...)

@schoenbaechler All the channel importance settings are already as laid out.

@Dbrant perfect! 🚀

Settings are present on 2.7.50376-r-2021-09-27, I am still working on the functionality testing

Moving this back until functionality testing is complete

Looks good on 2.7.50380-r-2021-10-18

edit - corrected build number used to test