Page MenuHomePhabricator

Uncaught TypeError: Cannot read property 'tools' of null
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
normalized_message
TypeError: Cannot read property 'tools' of null
exception.trace
at VeInitMwDesktopArticleTarget.ve.init.mw.DesktopArticleTarget.surfaceReady  https://fr.wikipedia.org/w/load.php?...
at https://fr.wikipedia.org/w/load.php?...
Impact

None, just log spam

Notes

Logstash search: https://logstash.wikimedia.org/goto/6d015e561d769d57ddbd4c3130c22268
Frequency:

image.png (535×2 px, 88 KB)

It's a fairly rare error, but I accidentally ran into it locally while trying to reproduce T237063.

Event Timeline

Change 708312 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Fix rare exception when editor loading is aborted

https://gerrit.wikimedia.org/r/708312

Change 708312 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix rare exception when editor loading is aborted

https://gerrit.wikimedia.org/r/708312

We should check the logs after this is deployed everywhere next week.

DLynch added a project: Editing QA.
DLynch added a subscriber: DLynch.

There haven't been any of these errors since August 5th, so I think we've gotten it.