Uncaught TypeError: Cannot read property 'tools' of null
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	matmarex
	Jul 27 2021, 3:35 PM

Description

Error

normalized_message

TypeError: Cannot read property 'tools' of null

exception.trace

at VeInitMwDesktopArticleTarget.ve.init.mw.DesktopArticleTarget.surfaceReady  https://fr.wikipedia.org/w/load.php?...
at https://fr.wikipedia.org/w/load.php?...

Impact

None, just log spam

Notes

Logstash search: https://logstash.wikimedia.org/goto/6d015e561d769d57ddbd4c3130c22268
Frequency:

It's a fairly rare error, but I accidentally ran into it locally while trying to reproduce T237063.

Details

	Subject	Repo	Branch	Lines +/-
	Fix rare exception when editor loading is aborted	mediawiki/extensions/VisualEditor	master	+6 -6

Customize query in gerrit

Related Objects

Mentioned Here: T237063: EventLogging validation errors for EditAttemptStep

Event Timeline

matmarex created this task.Jul 27 2021, 3:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 27 2021, 3:35 PM

matmarex claimed this task.Jul 27 2021, 3:35 PM

matmarex added a project: Editing-team (Kanban Board).

Change 708312 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Fix rare exception when editor loading is aborted

https://gerrit.wikimedia.org/r/708312

gerritbot added a project: Patch-For-Review.Jul 27 2021, 3:40 PM

matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Jul 27 2021, 3:41 PM

Change 708312 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix rare exception when editor loading is aborted

https://gerrit.wikimedia.org/r/708312

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.17; 2021-08-02).Jul 27 2021, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 27 2021, 6:10 PM

We should check the logs after this is deployed everywhere next week.

thcipriani moved this task from Untriaged to July 2021 on the Wikimedia-production-error board.Jul 28 2021, 6:57 PM

matmarex moved this task from To Triage to Triaged on the VisualEditor board.Jul 29 2021, 2:59 PM

• ppelberg moved this task from Blocked / Needs More Work to Ready to Be Worked On on the Editing-team (Kanban Board) board.Aug 11 2021, 4:16 PM

There haven't been any of these errors since August 5th, so I think we've gotten it.

matmarex edited projects, added Skipped QA; removed Editing QA.Aug 11 2021, 10:10 PM

• ppelberg closed this task as Resolved.Aug 25 2021, 12:31 AM

Uncaught TypeError: Cannot read property 'tools' of nullClosed, ResolvedPublicPRODUCTION ERRORActions