MediaSearch not compatible with new WVUI search widget on Wikimedia Commons
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Jul 27 2021, 11:46 PM

Description

During deployment of T287215, we noticed that search results were not taking the user to Special:MediaSearch and were instead taking the user to Special:Search.

It does this by adding a hidden field <input type="hidden" name="title" value="Special:MediaSearch"> via this hook:
https://gerrit.wikimedia.org/g/mediawiki/extensions/MediaSearch/+/939b5861410f3528501604064ab536eed33d5c0e/src/MediaSearchHooks.php#51

The code in Vector doesn't seem to be passing this page title to the WVUI widget.

Developer notes

Use the urlGenerator property in https://doc.wikimedia.org/wvui/master/ui/?path=/story/components-typeaheadsearch--configurable to pass the title to the WVUI widget.

For testing purposes use the following hook:

$wgHooks['BeforePageDisplay'][] = function ( $out, $skin ) {
	$skin->setSearchPageTitle( Title::newFromText('Special:MediaSearch') );
  };

To fix this WVUI will need to accept a searchPageTitle parameter to allow us to customize Special:Search with Special:MediaSearch
A patch in Vector will make use of it (which will be blocked on a release)

QA Results - Beta

AC	Status	Details
1	✅	T287540#7332720

QA Results - Prod

AC	Status	Details
1	✅	T287540#7332739

Details

Subject	Repo	Branch	Lines +/-
Do not hard code Special:Search	mediawiki/skins/Vector	master	+1 -1
Update WVUI to v0.3.0	mediawiki/core	master	+69 -40
Use the search title if configured	mediawiki/skins/Vector	master	+13 -2
It should be possible to use something other than Special:Search	wvui	master	+19 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		ovasileva	T287215 Enable WVUI search on commons
		Resolved		ovasileva	T287540 MediaSearch not compatible with new WVUI search widget on Wikimedia Commons

Event Timeline

Jdlrobson removed Jdlrobson as the assignee of this task.Jul 27 2021, 11:46 PM

Jdlrobson triaged this task as Medium priority.

Jdlrobson created this task.

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Jdlrobson mentioned this in T287215: Enable WVUI search on commons .

Jdlrobson updated the task description. (Show Details)Jul 28 2021, 12:10 AM

Jdlrobson added a project: WVUI.Jul 28 2021, 3:24 PM

Jdlrobson updated the task description. (Show Details)

Change 708553 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[wvui@master] It should be possible to use something other than Special:Search

https://gerrit.wikimedia.org/r/708553

gerritbot added a project: Patch-For-Review.Jul 28 2021, 3:37 PM

@egardner given the overlap between our projects could I request a review on the WVUI side of this?

Change 708561 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Use the search title if configured

https://gerrit.wikimedia.org/r/708561

gerritbot added a project: Patch-For-Review.Jul 28 2021, 4:17 PM

In T287540#7243482, @Jdlrobson wrote:

@egardner given the overlap between our projects could I request a review on the WVUI side of this?

@Jdlrobson: @egardner is out this week; do you need review before he's back? if so I'll ask some others on the SD team.

@CBogen the change is relatively simple. if this week is possible and anyone is familiar with Vue.js that would be ideal. Perhaps the only thing that might happen in review is a bike shed over the name :)

• nray updated the task description. (Show Details)Jul 29 2021, 5:24 PM

LGoto set the point value for this task to 2.Jul 29 2021, 5:24 PM

LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Jdlrobson moved this task from Ready for Development to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jul 29 2021, 5:36 PM