Page MenuHomePhabricator

Mismatch Finder website header
Closed, ResolvedPublic5 Estimated Story Points

Description

Problem:
We'd like to have a header for the Mismatch Finder website to help people figure out what page they are on.

Screenshots/mockups:
Header and Specs (link to Figma)

Screenshot 2021-08-25 at 15.47.03.png (139×669 px, 13 KB)

Screenshot 2021-09-02 at 10.43.47.png (598×1 px, 98 KB)

BDD
GIVEN a mismatch finder page (landing page or result page)
WHEN opening it
THEN I can see a header letting me know it is the mismatch finder website

Acceptance criteria:

  • all mismatch finder website pages have a header

Notes:

  • Sarai blesses us to have a max width of 1042 + 24 x2 (sprint 6 planning)
  • The header includes: the Wikidata logo, the authentication widget (with user name, icon and login status) and the H1 "Mismatch Finder" heading
  • Here's an svg file containing the Wikidata logo used within the header:

Event Timeline

The content of this task (meaning the screenshot and the copy) is UX-approved and ready to be worked upon.

If mistakes or different content are encountered on Figma, this ticket can be treated as the ultimate source of truth.

Just in case this has any impact on any of the decisions made during implementation, it's worth mentioning that, ideally, the header (the top section displaying the Wikidata logo and – optionally – links) should be available to be copied/reused in other SPAs, such as the Query builder. This is not a system component, but a structural section (like the Query Builder footer) that SPAs should share in order to be visually consistent.

Task Breakdown Notes:

  • This task might need breaking down, but we did not get to it during the meeting, please notify the channel when picking this up so that we can consider with this needs breaking down.

a change of rewrite rules in .lighttpd.conf was needed in order to make this work on toolforge:

$ diff .lighttpd.conf .lighttpd.conf.bak
7c7
<     ".*\.(jpg|jpeg|gif|png|swf|avi|mpg|mpeg|mp3|flv|ico|css|js|woff|ttf|svg|json)(?:\?(.*))?$" => "$0",
---
>     ".*\.(jpg|jpeg|gif|png|swf|avi|mpg|mpeg|mp3|flv|ico|css|js|woff|ttf|svg|json)$" => "$0",

(see https://www.wrichards.com/blog/2012/05/lighttpd-url-rewrite-and-query-string-qsa/)

Hello there!
Here is my test verification comment (more likely heads-up) for this ticket: I know the team is already aware that when the tablet (720px) and mobile (320px) breaking points are triggered the logo expands considerably.

But, I also wanted to mention that currently, for these two breaking points (720px, 320px) the authentication widget moves above the Wikidata logo

Screenshot 2021-09-09 at 11.59.50.png (252×386 px, 18 KB)


Instead, according to the design, the authentication widget should go below the Wikidata logo

Screenshot 2021-09-09 at 12.00.06.png (250×468 px, 19 KB)


I guess this is related to the fact that the header, for these two breaking points, is behaving a bit weird but just wanted to point it out to make sure we don't miss it.
I am sure fixing this behaviour will result in fixing also the placement of the authentication widget.

🎉
Looking great from my side.

@Mattia_Capozzi_WMDE can you check and close?

Hello! Sorry for the delay! Great from my side as well :)