Page MenuHomePhabricator

Log-in button appears twice on user links in officewiki
Closed, ResolvedPublic2 Estimated Story Points

Description

Steps to reproduce

  1. Go to https://office.wikimedia.org/ as a logged out user
  2. Select the user menu

Observed:
Log in link appears twice. No other links appear.

Screen Shot 2021-07-28 at 9.52.57 AM.png (632×744 px, 365 KB)

Expected:
Screen Shot 2021-07-28 at 9.53.31 AM.png (726×596 px, 38 KB)

Developer notes

  • Replicate locally with $wgGroupPermissions['*']['read'] = false;
  • In hooks where we unset( $content_navigation['user-menu']['login'] ); we will also need to `unset( $content_navigation['user-menu']['login-private'] );

QA

You can test this in beta at https://vote.wikimedia.beta.wmflabs.org/wiki/Main_Page
For production test in office.wikimedia.org

QA Results - Beta

ACStatusDetails
1T287585#7277858

QA Results - Prod

ACStatusDetails
1T287585#7277862

Event Timeline

Note: not a blocker for further deployment

Change 708594 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/skins/Vector@master] Remove duplicate login button from user links user menu.

https://gerrit.wikimedia.org/r/708594

cjming added a subscriber: cjming.

Change 708594 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove duplicate login button from user links user menu.

https://gerrit.wikimedia.org/r/708594

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Login link should only appear once in user links menu.

Screen Shot 2021-08-05 at 7.19.44 AM.png (272×995 px, 64 KB)

Edtadros added a subscriber: Edtadros.

Test Result - Fail

Status: ❌ Fail
Environment: officewiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

❌ AC1: Login link should only appear once in user links menu.

There is no ellipsis to access the user links menu.

Screen Shot 2021-08-05 at 7.26.32 AM.png (253×1 px, 50 KB)

I logged in and validated the version:

Screen Shot 2021-08-05 at 7.25.35 AM.png (713×766 px, 186 KB)

I also tried the url params.

Test Result - Fail

Status: ❌ Fail
Environment: officewiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

❌ AC1: Login link should only appear once in user links menu.

There is no ellipsis to access the user links menu.

Screen Shot 2021-08-05 at 7.26.32 AM.png (253×1 px, 50 KB)

I logged in and validated the version:

Screen Shot 2021-08-05 at 7.25.35 AM.png (713×766 px, 186 KB)

I also tried the url params.

Thanks for flagging. QA of this one is blocked on the QA of T288119 which fixes this issue.

Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: Jdlrobson.

@Edtadros this can be QAed now. Please make sure to use the right beta cluster link though (see QA section in updated task description)

Test Result - Pass

Status: ✅ Pass
Environment: vote beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Login link should only appear once in user links menu.

Screen Shot 2021-08-11 at 7.15.05 PM.png (234×1 px, 43 KB)

Test Result - Pass

Status: ✅ Pass
Environment: officewiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Login link should only appear once in user links menu.

Screen Shot 2021-08-11 at 7.15.15 PM.png (250×1 px, 54 KB)