Page MenuHomePhabricator

wbregistry-01 docker-compose.yml is not under source control
Closed, ResolvedPublic5 Estimated Story Points

Description

The docker-compose.yml, that orchestrates the wbregistry-01 instance of the wikibase-registry tool, is not in source control and only exists in that VM at /root/wikibase-registry/docker-compose.yml

We should use check this into some source control and usually only update it via git pull.

Ideally, we'd switch to managing tools like that purely declarative, but that might be out of scope.

Regarding update etc, there are already some docs at https://wikitech.wikimedia.org/wiki/Nova_Resource:Wikibase-registry which should be cleaned up, used and or removed if we recreate them somewhere else.

Acceptance criteria 🏕️🌟(August 2021)

  • wbregistry-01 docker-compose.yml is under source control
  • the files at the instance can be updated by performing a git pull and some form of restart of the containers
  • there is a README.md in the repo, detailing the most important things:
    • how the ssh to the instance hosting the registry (what it is called)
    • how to update the registry docker-compose code from the git repo (where it is, what commands to run)
    • how to update the docker deployment from the new docker-compose file / changes (recreate containers, build if needed etc)
    • how to check that the deployed state looks OK (check that only the expected containers are running)
    • when and how to submit things to the Server Admin Logs (SAL) https://wikitech.wikimedia.org/wiki/Nova_Resource:Wikibase-registry

Event Timeline

Michael updated the task description. (Show Details)
Michael updated the task description. (Show Details)
Addshore set the point value for this task to 5.Aug 11 2021, 10:36 AM

Probably easiest to put the Git repo on GitHub under the wmde organization. (And eventually maybe move it to Wikimedia GitLab, but I don’t think that’s quite ready yet.)

We should probably commit the LocalSettings.php as well, and move non-public settings into a separate file (e.g. PrivateSettings.php) which is included from LocalSettings.php and not committed.

There’s also a docker-compose-update.yml file, which seems to represent an attempt to move the wiki to MediaWiki 1.33. Currently Special:Version still shows 1.32, so I assume this was abandoned and we can ignore it? (It also only includes a Wikibase container and nothing else.)

Alright, some of the config lives at https://github.com/wmde/wikibase-registry now. I’ll add a README before moving this to peer review.

Mentioned in SAL (#wikimedia-cloud) [2021-08-18T10:12:46Z] <Lucas_WMDE> (over the past hour) extracted private config and moved infrastructure into Git T287586

Alright, there’s a README now.

One open issue is that the state of the query service updater is strange. In the docker-compose.yml, there’s a wdqs-updater service, but there’s no docker container named wikibase-registry_wdqs-updater_1; instead, there is a wikibase-registry_wdqs-updater_run_9, with no significant logs:

root@wbregistry-01:~/wikibase-registry# docker logs wikibase-registry_wdqs-updater_run_9
bash-4.4# exit

Trying to bring up the updater from docker-compose fails. Who knows where this other updater comes from, and what the status is in general? Maybe @Addshore or @Michael? (It doesn’t look like updates are actually running: this query finds no items that were updated after 7 November 2020.)

Alright, there’s a README now.

Looks good!

One open issue is that the state of the query service updater is strange. In the docker-compose.yml, there’s a wdqs-updater service, but there’s no docker container named wikibase-registry_wdqs-updater_1; instead, there is a wikibase-registry_wdqs-updater_run_9, with no significant logs:

root@wbregistry-01:~/wikibase-registry# docker logs wikibase-registry_wdqs-updater_run_9
bash-4.4# exit

Trying to bring up the updater from docker-compose fails. Who knows where this other updater comes from, and what the status is in general? Maybe @Addshore or @Michael? (It doesn’t look like updates are actually running: this query finds no items that were updated after 7 November 2020.)

If I touched that container at all, then only by doing a docker container restart <container id>. Looking at the image in the parent task, it seems like there used to be a container wikibase-registry_wdqs-updater_1 at some point? 🤔

LGTM!

I tried to push a suggestion but don't seem to be allowed in the new repo, could we add the wikidata group?

toan@C342:~/Documents/dev/wikibase-registry$     git push --set-upstream origin add-template-private-settings
ERROR: Permission to wmde/wikibase-registry.git denied to toban.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
toan@C342:~/Documents/dev/wikibase-registry$ git remote -v
origin	git@github.com:wmde/wikibase-registry.git (fetch)
origin	git@github.com:wmde/wikibase-registry.git (push)

Should be done, I made the Wikidata team a repo admin.

Should be done, I made the Wikidata team a repo admin.

cheers!

Certainly looks like it is under source control now!