Add a link: previously selected suggestion briefly shown when coming back from read mode
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	• mewoph
	Jul 28 2021, 5:38 PM

Description

List of steps to reproduce (step by step, including full links if applicable):

Enable link recommendation, click on task from Special:Homepage
Click on a suggestion (other than the first one)
If on desktop, click on "Read"; on mobile, close the editor
Open "Edit" tab again

What happens?:
The suggestion that was previously selected is shown and then the first suggestion is selected again.

What should have happened instead?:
The first suggestion should be selected when coming back from read mode.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

addlink_reload_prevSuggestion.gif (982×1 px, 3 MB)

Note: This bug only occurs if the suggestion is clicked. If the suggestion is navigated to via prev/next buttons in the link inspector, the first suggestion is selected after coming back from read mode.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Add a link: No-op onAnnotationClicked when the handler is called when it's added	mediawiki/extensions/GrowthExperiments	master	+8 -1

Customize query in gerrit

Event Timeline

• mewoph created this task.Jul 28 2021, 5:38 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 28 2021, 5:38 PM

• mewoph claimed this task.Jul 28 2021, 5:38 PM

• mewoph moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

• mewoph updated the task description. (Show Details)

When the user clicks on a suggestion and navigates to read mode, the link inspector is destroyed and set up again. onAnnotationClicked is called when setting up the link inspector again since mw.hook is used (if an event is fired, and a handler added afterwards, the handler is called right away with the last given argument).

Change 708574 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add a link: No-op onAnnotationClicked when the handler is called when it's added

https://gerrit.wikimedia.org/r/708574

gerritbot added a project: Patch-For-Review.Jul 28 2021, 5:53 PM

• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 28 2021, 5:53 PM

Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 29 2021, 3:36 AM

Change 708574 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add a link: No-op onAnnotationClicked when the handler is called when it's added

https://gerrit.wikimedia.org/r/708574

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.17; 2021-08-02).Jul 29 2021, 4:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jul 29 2021, 4:10 AM

Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 2 2021, 11:25 PM

Etonkovidova closed this task as Resolved.Aug 3 2021, 9:43 PM

	F34568150: addlink_reload_prevSuggestion.gif
	Jul 28 2021, 5:38 PM

Add a link: previously selected suggestion briefly shown when coming back from read modeClosed, ResolvedPublicBUG REPORTActions

Description

Details

Event Timeline

Add a link: previously selected suggestion briefly shown when coming back from read mode
Closed, ResolvedPublicBUG REPORT
Actions