Page MenuHomePhabricator

Evaluate best approach for live filtering for text filter [2hr]
Closed, ResolvedPublicSpike

Description

We have some options for how to best implement the text filter, given that we want it to filter the collections as the user types, rather than requiring them to click a search/filter button.

One option to explore is Django Autocomplete Light.

Acceptance Criteria

  • Decide the best approach for implementing live text filtering

Event Timeline

Restricted Application changed the subtype of this task from "Task" to "Spike". · View Herald TranscriptJul 29 2021, 9:09 AM

@Samwalton9 How much are we against a Javascript text search?

Honestly so much of the new My Library depends on JS at this point that I think you can implement this as a full-JS solution.

We haven't had any recent complaints from folks about JS.

After some research, the best path forward to implementing live search would be to use Javascript. I found some libraries like InstantSearch.js or FuseJS that might help us, but it might be better to create an in-house solution. Let's discuss this tomorrow!

Thinking this through a little bit more, I think FuseJS is the best option for our needs, but we can discuss this more in-depth tomorrow or on our engineering meeting.

PR merged! I am leaving this in the Review column for the other PR, unless you want to create a separate ticket for it

PR merged! I am leaving this in the Review column for the other PR, unless you want to create a separate ticket for it

Just to clarify, which PR is merged?

Oops, I totally thought this was another ticket

We can move this to done since I am already working on T285676