TypeError: undefined is not a function (in Minerva renderEditButton)
Closed, DeclinedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	• nray
	Jul 29 2021, 4:11 PM

Description

Error

mwversion: undefined
Single document: https://logstash.wikimedia.org/app/discover#/doc/logstash-*/logstash-2021.07.29?id=T9_Y8XoBCxLmWkI6lpP_

normalized_message

TypeError: undefined is not a function

exception.trace

at renderEditButton  <anonymous>:138:128
at Object.render  <anonymous>:137:809
at HTMLDocument.<anonymous>  <anonymous>:117:918
at mightThrow  https://fa.m.wikipedia.org/w/load.php?lang=fa&modules=jquery&skin=minerva&version=8v0mf:49:833
at process  https://fa.m.wikipedia.org/w/load.php?lang=fa&modules=jquery&skin=minerva&version=8v0mf:50:498

Source: https://gerrit.wikimedia.org/g/mediawiki/skins/MinervaNeue/+/b1a5a03473e21b550966e783f5aec1762e2d2743/resources/skins.minerva.scripts/Toolbar.js#49

Impact

At the time of this writing, most errors are coming from fa.m.wikipedia.org

Notes

Related Objects

Mentioned Here: T178356: Raise Grade A JavaScript requirement from ES5 (2009) to ES6 (2015)

Event Timeline

• nray created this task.Jul 29 2021, 4:11 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptJul 29 2021, 4:11 PM

Krinkle renamed this task from TypeError: undefined is not a function to TypeError: undefined is not a function (in Minerva renderEditButton).Jul 29 2021, 8:20 PM

Krinkle updated the task description. (Show Details)

Krinkle moved this task from Untriaged to July 2021 on the Wikimedia-production-error board.

Probably a gadget. Will take a look later today.

I took a look at this one. All the errors were coming from Grade B browsers.
These usually relate to gadgets running ES6 code so I booted up a copy of IE11 and sure enough I started to see some issues...

Arabic Wikipedia (362/443 of the errors in the last 12hr) complained about a startsWith usage. Fixed with:
https://ar.wikipedia.org/w/index.php?title=%D9%85%D9%8A%D8%AF%D9%8A%D8%A7%D9%88%D9%8A%D9%83%D9%8A%3ACommon.js&type=revision&diff=54670455&oldid=53790926

The other wikis didn't have much volume and not enough volume to debug, presumably these are lesser used gadgets not compatible with ES5 browsers.

Side note, the editing workflow of the mobile site is unusable in IE11. You can't even save or close it.

Declining in favor of T178356 given about 50% of our errors are already coming from browsers of this quality it doesn't make sense to completely fix this issue given the scale.

Jdlrobson moved this task from Incoming to Kanbanana-FY-2021-22 on the Web-Team-Backlog board.Aug 2 2021, 10:38 PM

Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog.

TypeError: undefined is not a function (in Minerva renderEditButton)Closed, DeclinedPublicPRODUCTION ERRORActions