Page MenuHomePhabricator

Wikimedia\Rdbms\Database::normalizeUpsertKeys called with deprecated parameter style: the unique key array should be a string or array of string arrays generating lots of warning
Open, Needs TriagePublic

Description

We got around 90k warnings in the last 24h with the follow trace:

from /srv/mediawiki/php-1.37.0-wmf.16/includes/libs/rdbms/database/Database.php(2294)
#0 /srv/mediawiki/php-1.37.0-wmf.16/includes/libs/rdbms/database/Database.php(3353): Wikimedia\Rdbms\Database->normalizeUpsertKeys(array)
#1 /srv/mediawiki/php-1.37.0-wmf.16/extensions/ProofreadPage/includes/Index/UpdateIndexQualityStats.php(81): Wikimedia\Rdbms\Database->replace(string, array, array, string)
#2 /srv/mediawiki/php-1.37.0-wmf.16/includes/deferred/DeferredUpdates.php(515): ProofreadPage\Index\UpdateIndexQualityStats->doUpdate()
#3 /srv/mediawiki/php-1.37.0-wmf.16/includes/deferred/RefreshSecondaryDataUpdate.php(101): DeferredUpdates::attemptUpdate(ProofreadPage\Index\UpdateIndexQualityStats, Wikimedia\Rdbms\LBFactoryMulti)
#4 /srv/mediawiki/php-1.37.0-wmf.16/includes/deferred/DeferredUpdates.php(515): RefreshSecondaryDataUpdate->doUpdate()
#5 /srv/mediawiki/php-1.37.0-wmf.16/includes/deferred/DeferredUpdates.php(391): DeferredUpdates::attemptUpdate(RefreshSecondaryDataUpdate, Wikimedia\Rdbms\LBFactoryMulti)
#6 /srv/mediawiki/php-1.37.0-wmf.16/includes/deferred/DeferredUpdates.php(221): DeferredUpdates::run(RefreshSecondaryDataUpdate, Wikimedia\Rdbms\LBFactoryMulti, Monolog\Logger, BufferingStatsdDataFactory, string)
#7 /srv/mediawiki/php-1.37.0-wmf.16/includes/deferred/DeferredUpdatesScope.php(264): DeferredUpdates::{closure}(RefreshSecondaryDataUpdate, integer)
#8 /srv/mediawiki/php-1.37.0-wmf.16/includes/deferred/DeferredUpdatesScope.php(196): DeferredUpdatesScope->processStageQueue(integer, integer, Closure)
#9 /srv/mediawiki/php-1.37.0-wmf.16/includes/deferred/DeferredUpdates.php(242): DeferredUpdatesScope->processUpdates(integer, Closure)
#10 /srv/mediawiki/php-1.37.0-wmf.16/includes/MediaWiki.php(1136): DeferredUpdates::doUpdates(string)
#11 /srv/mediawiki/php-1.37.0-wmf.16/includes/MediaWiki.php(846): MediaWiki->restInPeace()
#12 /srv/mediawiki/php-1.37.0-wmf.16/includes/MediaWiki.php(584): MediaWiki->doPostOutputShutdown()
#13 /srv/mediawiki/php-1.37.0-wmf.16/index.php(53): MediaWiki->run()
#14 /srv/mediawiki/php-1.37.0-wmf.16/index.php(46): wfIndexMain()
#15 /srv/mediawiki/w/index.php(3): require(string)
#16 {main}


message
Wikimedia\Rdbms\Database::normalizeUpsertKeys called with deprecated parameter style: the unique key array should be a string or array of string arrays

The majority of them seem to be affecting zhwikisource: https://logstash.wikimedia.org/goto/ded4ff9a0a43193d61135fb67b0cbd35

Similar occurrences:

I am using the same tags from T280525 and tagging some of the people that were there too as I am not really sure who would own this.
Please feel free to modify subscribers and tags accordingly

Event Timeline

Change 709049 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/ProofreadPage@master] UpdateIndexQualityStats: Call db->replace() with a string for uniqueKeys

https://gerrit.wikimedia.org/r/709049

Change 709049 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] UpdateIndexQualityStats: Call db->replace() with a string for uniqueKeys

https://gerrit.wikimedia.org/r/709049