Page MenuHomePhabricator
Create Task
Maniphest T287742

wrong section in the link causes eternal loading
Closed, ResolvedPublicBUG REPORT
Actions

Description

Section translation supports linking to a specific section to translate (T260143). However, if we put a wrong section in the link, it kinda breaks sx (eternal loading of the section) but the user can always go back
https://sx.wmflabs.org/index.php/Special:ContentTranslation?page=Moon&section=WRONGSECTION&from=en&to=es&sx=true#/sx

*what should be the correct behaviour in this case?*

We should avoid the dead-end:

  • Check for the presence of such section in the article
  • When the section does not exist, show the regular confirmation step (with article selected, but no specific section)
  • Show a bubble notification with the message "Section "Wrongsection" not found in the article"

Details

SubjectRepoBranchLines +/-
CX3 Build 0.1.0+20211018mediawiki/extensions/ContentTranslationmaster+1 K -355
SXTranslationConfirmer: Clear prefilled section from URL if invalidmediawiki/extensions/ContentTranslationmaster+31 -6
SX: Remove section URL param when selecting invalid sectionmediawiki/extensions/ContentTranslationmaster+70 -38
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Jpita created this task.Jul 30 2021, 9:18 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 30 2021, 9:18 AM
Pginer-WMF added a project: Language-Team (Language-2021-July-September).Jul 30 2021, 9:26 AM
Pginer-WMF triaged this task as Medium priority.Jul 30 2021, 9:31 AM
Pginer-WMF updated the task description. (Show Details)
Pginer-WMF added a parent task: T286641: Entry points to improve discoverability of Section Translation.
Pginer-WMF moved this task from Backlog to Entry points on the SectionTranslation board.Jul 30 2021, 10:55 AM
Pginer-WMF moved this task from Quarter Backlog to Priority: SX Adoption on the Language-Team (Language-2021-July-September) board.Jul 30 2021, 11:52 AM
Pginer-WMF mentioned this in T260143: New translation: Direct access to translate a specific section.Aug 2 2021, 10:36 AM
gerritbot added a comment.Aug 31 2021, 4:12 PM

Change 715758 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX: Remove section URL param when selecting invalid section

https://gerrit.wikimedia.org/r/715758

gerritbot added a project: Patch-For-Review.Aug 31 2021, 4:12 PM
ngkountas claimed this task.Aug 31 2021, 4:14 PM
ngkountas moved this task from Priority: SX Adoption to In Progress on the Language-Team (Language-2021-July-September) board.
ngkountas moved this task from In Progress to In Review on the Language-Team (Language-2021-July-September) board.
gerritbot added a comment.Sep 7 2021, 7:20 AM

Change 715758 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Remove section URL param when selecting invalid section

https://gerrit.wikimedia.org/r/715758

Maintenance_bot removed a project: Patch-For-Review.Sep 7 2021, 8:10 AM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 7 2021, 3:01 PM
Pginer-WMF edited projects, added Language-Team (Language-2021-October-December); removed Language-Team (Language-2021-July-September).Oct 1 2021, 12:32 PM
Pginer-WMF moved this task from Quarter Backlog to In Review on the Language-Team (Language-2021-October-December) board.
ngkountas moved this task from In Review to Needs QA on the Language-Team (Language-2021-October-December) board.Oct 5 2021, 1:41 PM
• Jpita moved this task from Needs QA to Pending input for QA on the Language-Team (Language-2021-October-December) board.Oct 11 2021, 2:54 PM
• Jpita added a subscriber: Pginer-WMF.

@Pginer-WMF right now the behaviour is:

  1. go to wrong section link
  2. get the wrong section confirmation step
    Screenshot 2021-10-11 at 15.49.47.png (560×748 px, 50 KB)
  3. when we click the "Translate section" button we get no bubble notification, instead we are redirected to the "regular confirmation step" page
    Screenshot 2021-10-11 at 15.50.10.png (636×802 px, 82 KB)

is this ok?

Pginer-WMF added a comment.Oct 11 2021, 3:28 PM
In T287742#7417599, @Jpita wrote:

@Pginer-WMF right now the behaviour is:

  1. go to wrong section link
  2. get the wrong section confirmation step
    Screenshot 2021-10-11 at 15.49.47.png (560×748 px, 50 KB)
  3. when we click the "Translate section" button we get no bubble notification, instead we are redirected to the "regular confirmation step" page
    Screenshot 2021-10-11 at 15.50.10.png (636×802 px, 82 KB)

is this ok?

The step 2 should be avoided. From clicking the link the expected result would be to reach step 3.

ngkountas moved this task from Pending input for QA to In Progress on the Language-Team (Language-2021-October-December) board.Oct 12 2021, 8:15 AM
gerritbot added a comment.Oct 12 2021, 8:54 AM

Change 730148 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXTranslationConfirmer: Clear prefilled section from URL if invalid

https://gerrit.wikimedia.org/r/730148

gerritbot added a project: Patch-For-Review.Oct 12 2021, 8:54 AM
gerritbot added a comment.Oct 13 2021, 7:11 AM

Change 730148 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXTranslationConfirmer: Clear prefilled section from URL if invalid

https://gerrit.wikimedia.org/r/730148

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.5; 2021-10-19).Oct 13 2021, 8:00 AM
gerritbot added a comment.Oct 18 2021, 5:45 AM

Change 731310 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.1.0+20211018

https://gerrit.wikimedia.org/r/731310

gerritbot added a comment.Oct 18 2021, 9:24 AM

Change 731310 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.1.0+20211018

https://gerrit.wikimedia.org/r/731310

ngkountas moved this task from In Progress to In Review on the Language-Team (Language-2021-October-December) board.Oct 19 2021, 8:13 PM
ngkountas moved this task from In Review to Needs QA on the Language-Team (Language-2021-October-December) board.Nov 1 2021, 2:42 PM
• Jpita moved this task from Needs QA to Done on the Language-Team (Language-2021-October-December) board.Nov 4 2021, 4:12 PM
Pginer-WMF closed this task as Resolved.Nov 12 2021, 10:13 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL