Remove SkinTemplateOutputPageBeforeExec hook
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Jul 30 2021, 5:22 PM

Description

Deprecated in 1.35
Time to remove as only 2 usages:
https://codesearch.wmcloud.org/search/?q=%22SkinTemplateOutputPageBeforeExec&i=nope&files=&excludeFiles=&repos=

TODO

Remove includes/skins/Hook/SkinTemplateOutputPageBeforeExecHook.php
Remove code in SkinTemplate

if ( !$this->getHookRunner()->onSkinTemplateOutputPageBeforeExec( $this, $tpl ) ) {
			wfDebug( __METHOD__ . ": Hook SkinTemplateOutputPageBeforeExec broke outputPage execution!" );
		}

Remove line in includes/HookContainer/DeprecatedHooks.php

'SkinTemplateOutputPageBeforeExec' => [ 'deprecatedVersion' => '1.35' ],

Details

	Subject	Repo	Branch	Lines +/-
	Remove SkinTemplateOutputPageBeforeExec Hook	mediawiki/core	master	+1 -47

Customize query in gerrit

Event Timeline

Jdlrobson created this task.Jul 30 2021, 5:22 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 30 2021, 5:22 PM

Jdlrobson triaged this task as High priority.Jul 30 2021, 5:22 PM

Jdlrobson renamed this task from Remove SkinTemplateOutputPageBeforeExec to Remove SkinTemplateOutputPageBeforeExec hook.Jul 30 2021, 5:35 PM

Change 709112 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] Remove SkinTemplateOutputPageBeforeExec Hook

https://gerrit.wikimedia.org/r/709112

gerritbot added a project: Patch-For-Review.Jul 30 2021, 9:32 PM

Change 709112 merged by jenkins-bot:

[mediawiki/core@master] Remove SkinTemplateOutputPageBeforeExec Hook

https://gerrit.wikimedia.org/r/709112

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.17; 2021-08-02).Jul 30 2021, 11:00 PM

Jdlrobson closed this task as Resolved.Jul 30 2021, 11:00 PM

Jdlrobson claimed this task.

Thanks @Ammarpad

Maintenance_bot removed a project: Patch-For-Review.Jul 30 2021, 11:10 PM

Remove SkinTemplateOutputPageBeforeExec hookClosed, ResolvedPublicActions

Description

TODO

Details

Event Timeline

Remove SkinTemplateOutputPageBeforeExec hook
Closed, ResolvedPublic
Actions