Remove skin static methods Skin::getSkinNames, Skin::getAllowedSkins, Skin::makeVariablesScript
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Jdlrobson
	Jul 30 2021, 5:33 PM

Description

Deprecated in 1.36 can be removed in 1.38
https://codesearch.wmcloud.org/search/?q=Skin%3A%3A(getAllowedSkins%7CgetSkinNames)&i=nope&files=&excludeFiles=&repos=
https://codesearch.wmcloud.org/search/?q=Skin%3A%3A(makeVariablesScript)&i=nope&files=&excludeFiles=&repos=

TODO

Remove the code
Update RELEASE_NOTES

Details

	Subject	Repo	Branch	Lines +/-
	Remove deprecated skin methods 3	mediawiki/core	master	+2 -48

Customize query in gerrit

Event Timeline

Jdlrobson created this task.Jul 30 2021, 5:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 30 2021, 5:33 PM

Jdlrobson renamed this task from Remove Skin::getSkinNames and Skin::getAllowedSkins to Remove skin static methods Skin::getSkinNames, Skin::getAllowedSkins, Skin::makeVariablesScript.Jul 30 2021, 5:43 PM

Jdlrobson added a project: patch-welcome.

Jdlrobson updated the task description. (Show Details)

Jdlrobson triaged this task as High priority.Sep 22 2021, 3:21 PM

Jdlrobson added a project: good first task.

Change 723040 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] Remove deprecated skin methods 3

https://gerrit.wikimedia.org/r/723040

gerritbot added a project: Patch-For-Review.Sep 23 2021, 7:13 AM

Change 723040 merged by jenkins-bot:

[mediawiki/core@master] Remove deprecated skin methods 3

https://gerrit.wikimedia.org/r/723040

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.2; 2021-09-28).Sep 23 2021, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 23 2021, 5:10 PM

Jdlrobson closed this task as Resolved.Sep 23 2021, 6:53 PM