Page MenuHomePhabricator

Reply tool should recognize user talk self-links
Closed, ResolvedPublic

Description

Behavior

  1. Visit the user talk page of someone who has customized their signature to only include a link to their user talk page (e.g. en:User talk:Black Kite#Miss Grand pageant article) [i]
  2. Try to reply to any of the page owner's (User:Black Kite) comments

Expected

  1. ✅ There are (working) [ reply ] links after the talk page owner’s comments.

Actual

  1. ❗️No [ reply ] links appear after the talk page owner’s comments.

Approaches

A living list of ways in which this issue could be fixed.

  1. Adjust the comment parser so that it renders the page without removing self-links.
    • Note: what a reader/viewer sees would remain the same: self-links would remain black, bolded and unclickable.

Done

  • Expected behavior is implemented

Examples of affected pages


i. Note: such a signature DOES comply with the new signature requirements.

Event Timeline

@Tacsipacsi this is the first time I'm seeing this case...if/when you encounter this issue on other pages, can you please add links to them on this ticket?

@Tacsipacsi this is the first time I'm seeing this case...if/when you encounter this issue on other pages, can you please add links to them on this ticket?

I added one, and will keep an eye out for more. I don’t expect it to be very common, but when it happens, it’s very annoying.

I also fixed some inaccuracies in the description:

  • The problem is not that nothing happens when one clicks the [ reply ] link, but that there’s no link to click in the first place.
  • The self-links are already rendered as links (at least by the legacy parser) since 9f5309605163: black, bold and unclickable <a> elements. Thus “not be rendered as links” cannot be preserved, but it’s not the goal either, just to keep the actually user-facing behavior. (By the way, this makes engineers’ life easier: simply hrefless links should be treated as the talk page owner’s talk link on user talk pages instead of dropping them.)

@Tacsipacsi this is the first time I'm seeing this case...if/when you encounter this issue on other pages, can you please add links to them on this ticket?

I added one, and will keep an eye out for more. I don’t expect it to be very common, but when it happens, it’s very annoying.

Understood and thank you, @Tacsipacsi.

I also fixed some inaccuracies in the description:

Oh, wonderful – I value how close attention you pay. Thank you.

Change 753089 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Handle selflinks by returning the current page's title

https://gerrit.wikimedia.org/r/753089

Change 753089 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Handle selflinks by returning the current page's title

https://gerrit.wikimedia.org/r/753089

Ryasmeen subscribed.

The original page that was mentioned on the task has been archived. So, clicking on the reply links for the talk page owner's comment does not open the Reply tool. But the reply link is appearing now which previously was not.
Also, checked on this page: https://en.wikipedia.org/wiki/User_talk:Czar, where the reply links are also appearing next to the talk page owner's signature and the Reply tool is opening up when you click on them.

After checking with @matmarex, considering this as fixed.

ppelberg claimed this task.