Page MenuHomePhabricator
Create Task
Maniphest T287870

Language selector: Reduce separator after header
Closed, ResolvedPublic
Actions

Assigned To
Pginer-WMF
Authored By
Pginer-WMF
Aug 2 2021, 2:20 PM
Tags
Referenced Files
F34877547: Screen Shot 2021-12-10 at 4.52.33 PM.png
Dec 11 2021, 12:56 AM
F34877536: Screen Shot 2021-12-10 at 4.18.43 PM.png
Dec 11 2021, 12:56 AM
F34573749: test.m.wikipedia.org_wiki_Special_ContentTranslation(iPhone 6_7_8) copy.png
Aug 2 2021, 2:20 PM
F34573751: Screenshot 2021-08-02 at 16.00.43 2.png
Aug 2 2021, 2:20 PM
Subscribers
Aklapper
Etonkovidova
Jpita
ovasileva
Pginer-WMF
santhosh

Description

Looking at the initial implementation of the language selector (T253303) available for Section Translation at test wiki, the header field shows a separator element between the header and the search field.

This is a 2px line that adds up to the search field top border, making the separator visually heavy.
This ticket proposes to adjust the separator to make it:

  • 1px height.
  • Use Base70 (#C8CCD1) as color.
test.m.wikipedia.org_wiki_Special_ContentTranslation(iPhone 6_7_8) copy.png (416×750 px, 28 KB)
Screenshot 2021-08-02 at 16.00.43 2.png (468×996 px, 93 KB)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/ContentTranslationwmf/1.38.0-wmf.9+7 -7CX3 Build 0.1.0+20211129
mediawiki/extensions/ContentTranslationmaster+7 -7CX3 Build 0.1.0+20211129
mediawiki/extensions/ContentTranslationmaster+1 -1MWDivider: Avoid thick line because of double border
Customize query in gerrit

Related Objects
Search...

Event Timeline

Pginer-WMF triaged this task as Medium priority.Aug 2 2021, 2:20 PM
Pginer-WMF created this task.
Pginer-WMF moved this task from Quarter Backlog to Priority: CX Quality & Maintenance on the Language-Team (Language-2021-July-September) board.Aug 2 2021, 4:43 PM
Pginer-WMF mentioned this in T253303: Basic support for a responsive language selector.
Pginer-WMF edited projects, added Language-Team (Language-2021-October-December); removed Language-Team (Language-2021-July-September).Oct 1 2021, 12:34 PM
Pginer-WMF moved this task from Quarter Backlog to Priority: CX Quality & Maintenance on the Language-Team (Language-2021-October-December) board.
gerritbot added a comment.Nov 18 2021, 5:46 AM

Change 739700 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] MWDivider: Avoid thick line because of double border

https://gerrit.wikimedia.org/r/739700

gerritbot added a project: Patch-For-Review.Nov 18 2021, 5:46 AM
santhosh claimed this task.Nov 18 2021, 5:50 AM
santhosh removed santhosh as the assignee of this task.
santhosh moved this task from Priority: CX Quality & Maintenance to In Review on the Language-Team (Language-2021-October-December) board.
gerritbot added a comment.Nov 22 2021, 2:37 PM

Change 739700 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] MWDivider: Avoid thick line because of double border

https://gerrit.wikimedia.org/r/739700

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Nov 22 2021, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 22 2021, 3:10 PM
santhosh moved this task from In Review to Needs QA on the Language-Team (Language-2021-October-December) board.Nov 26 2021, 6:53 AM
gerritbot added a comment.Nov 29 2021, 6:36 AM

Change 742284 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.1.0+20211129

https://gerrit.wikimedia.org/r/742284

gerritbot added a project: Patch-For-Review.Nov 29 2021, 6:36 AM
gerritbot added a comment.Nov 29 2021, 4:19 PM

Change 742284 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.1.0+20211129

https://gerrit.wikimedia.org/r/742284

Maintenance_bot removed a project: Patch-For-Review.Nov 29 2021, 5:11 PM
gerritbot added a comment.Dec 1 2021, 3:04 AM

Change 742849 had a related patch set uploaded (by KartikMistry; author: Santhosh):

[mediawiki/extensions/ContentTranslation@wmf/1.38.0-wmf.9] CX3 Build 0.1.0+20211129

https://gerrit.wikimedia.org/r/742849

gerritbot added a project: Patch-For-Review.Dec 1 2021, 3:04 AM
gerritbot added a comment.Dec 1 2021, 3:19 AM

Change 742849 abandoned by KartikMistry:

[mediawiki/extensions/ContentTranslation@wmf/1.38.0-wmf.9] CX3 Build 0.1.0+20211129

Reason:

Need to fix Merge Conflict first.

https://gerrit.wikimedia.org/r/742849

Maintenance_bot removed a project: Patch-For-Review.Dec 1 2021, 4:11 AM
gerritbot added a comment.Dec 1 2021, 6:09 AM

Change 742849 restored by KartikMistry:

[mediawiki/extensions/ContentTranslation@wmf/1.38.0-wmf.9] CX3 Build 0.1.0+20211129

https://gerrit.wikimedia.org/r/742849

gerritbot added a project: Patch-For-Review.Dec 1 2021, 6:09 AM
gerritbot added a comment.Dec 2 2021, 12:47 PM

Change 742849 abandoned by KartikMistry:

[mediawiki/extensions/ContentTranslation@wmf/1.38.0-wmf.9] CX3 Build 0.1.0+20211129

Reason:

https://gerrit.wikimedia.org/r/742849

Etonkovidova moved this task from Needs QA to Pending input for QA on the Language-Team (Language-2021-October-December) board.Dec 11 2021, 12:56 AM
Etonkovidova added a subscriber: Etonkovidova.

Checked on testwiki wmf.12

  • the color ( (#C8CCD1)) is in place
  • border-top-width1px
Screen Shot 2021-12-10 at 4.18.43 PM.png (738×958 px, 58 KB)
Screen Shot 2021-12-10 at 4.52.33 PM.png (867×1 px, 334 KB)

It seems that some additional border is added to to the top, right and left. @santhosh - should all borders be the same ?

Pginer-WMF edited projects, added Language-Team (Language-2022-January-March); removed Language-Team (Language-2021-October-December).Jan 10 2022, 3:21 PM
Pginer-WMF moved this task from Quarter Backlog to Pending input for QA on the Language-Team (Language-2022-January-March) board.
Pginer-WMF closed this task as Resolved.Feb 4 2022, 9:10 AM
Pginer-WMF claimed this task.
Pginer-WMF moved this task from Pending input for QA to Done on the Language-Team (Language-2022-January-March) board.
In T287870#7564262, @Etonkovidova wrote:

Checked on testwiki wmf.12

  • the color ( (#C8CCD1)) is in place
  • border-top-width1px
Screen Shot 2021-12-10 at 4.18.43 PM.png (738×958 px, 58 KB)
Screen Shot 2021-12-10 at 4.52.33 PM.png (867×1 px, 334 KB)

It seems that some additional border is added to to the top, right and left. @santhosh - should all borders be the same ?

Thanks for checking this @Etonkovidova. The pending aspects are covered in T287862: Language selector: search field needs adjustment

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL