Page MenuHomePhabricator

Language selector: Reduce separator after header
Closed, ResolvedPublic

Description

Looking at the initial implementation of the language selector (T253303) available for Section Translation at test wiki, the header field shows a separator element between the header and the search field.

This is a 2px line that adds up to the search field top border, making the separator visually heavy.
This ticket proposes to adjust the separator to make it:

  • 1px height.
  • Use Base70 (#C8CCD1) as color.
test.m.wikipedia.org_wiki_Special_ContentTranslation(iPhone 6_7_8) copy.png (416×750 px, 28 KB)
Screenshot 2021-08-02 at 16.00.43 2.png (468×996 px, 93 KB)

Event Timeline

Pginer-WMF triaged this task as Medium priority.Aug 2 2021, 2:20 PM
Pginer-WMF created this task.

Change 739700 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] MWDivider: Avoid thick line because of double border

https://gerrit.wikimedia.org/r/739700

Change 739700 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] MWDivider: Avoid thick line because of double border

https://gerrit.wikimedia.org/r/739700

Change 742284 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.1.0+20211129

https://gerrit.wikimedia.org/r/742284

Change 742284 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.1.0+20211129

https://gerrit.wikimedia.org/r/742284

Change 742849 had a related patch set uploaded (by KartikMistry; author: Santhosh):

[mediawiki/extensions/ContentTranslation@wmf/1.38.0-wmf.9] CX3 Build 0.1.0+20211129

https://gerrit.wikimedia.org/r/742849

Change 742849 abandoned by KartikMistry:

[mediawiki/extensions/ContentTranslation@wmf/1.38.0-wmf.9] CX3 Build 0.1.0+20211129

Reason:

Need to fix Merge Conflict first.

https://gerrit.wikimedia.org/r/742849

Change 742849 restored by KartikMistry:

[mediawiki/extensions/ContentTranslation@wmf/1.38.0-wmf.9] CX3 Build 0.1.0+20211129

https://gerrit.wikimedia.org/r/742849

Change 742849 abandoned by KartikMistry:

[mediawiki/extensions/ContentTranslation@wmf/1.38.0-wmf.9] CX3 Build 0.1.0+20211129

Reason:

https://gerrit.wikimedia.org/r/742849

Etonkovidova added a subscriber: Etonkovidova.

Checked on testwiki wmf.12

  • the color ( (#C8CCD1)) is in place
  • border-top-width1px
Screen Shot 2021-12-10 at 4.18.43 PM.png (738×958 px, 58 KB)
Screen Shot 2021-12-10 at 4.52.33 PM.png (867×1 px, 334 KB)

It seems that some additional border is added to to the top, right and left. @santhosh - should all borders be the same ?

Pginer-WMF claimed this task.

Checked on testwiki wmf.12

  • the color ( (#C8CCD1)) is in place
  • border-top-width1px
Screen Shot 2021-12-10 at 4.18.43 PM.png (738×958 px, 58 KB)
Screen Shot 2021-12-10 at 4.52.33 PM.png (867×1 px, 334 KB)

It seems that some additional border is added to to the top, right and left. @santhosh - should all borders be the same ?

Thanks for checking this @Etonkovidova. The pending aspects are covered in T287862: Language selector: search field needs adjustment