Page MenuHomePhabricator

[BUG] Newcomer tasks: Warning and error messages in the Suggested edits module are displayed incorrectly
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  1. Open Newcomer homepage
  2. Open the Suggested edits task difficulty filter and set it so that there are very few article results (e.g., by setting the task difficulty to the hard task)
  3. Navigate after the last suggested edit to see the "No more suggestions" message and illustration.
  4. Open the topic filter and set it so that there are zero article results (e.g., by choosing a single topic for which there are no suggestions)
  5. Close the filter to see the "No suggestions found" message and illustration

What happens?:
On steps 3 and 5, there is a large gap between the message header and the illustration and message

Desktop
image.png (1×1 px, 98 KB)
image.png (1×1 px, 96 KB)
Mobile
image.png (1×780 px, 84 KB)
image.png (1×770 px, 81 KB)

What should have happened instead?:
The expected spacing is 1em between message and illustration.

image.png (1×1 px, 132 KB)

Event Timeline

MMiller_WMF added a subscriber: MMiller_WMF.

This is a snack-sized task that we are moving to Current Sprint, to potentially fit in between other work.

Change 711699 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Remove min-height on .se-card-title & .se-card-text

https://gerrit.wikimedia.org/r/711699

Updated desktop UIs:

Screen Shot 2021-08-11 at 2.27.09 PM.png (1×1 px, 104 KB)

Screen Shot 2021-08-11 at 2.23.06 PM.png (1×1 px, 104 KB)

Updated mobile UIs:

Screen Shot 2021-08-11 at 2.26.49 PM.png (1×734 px, 87 KB)

Screen Shot 2021-08-11 at 2.23.45 PM.png (1×732 px, 85 KB)

Change 711699 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Remove min-height on .se-card-title & .se-card-text

https://gerrit.wikimedia.org/r/711699

Etonkovidova added a subscriber: Etonkovidova.

Checked on testwikii and hewiki (wmf.19). The production is identical to the screenshots in the comment above. Here are additional screenshots (on mobile) for @RHo quick review (you may close this task as Resolved if no follow-ups are needed):

wmf.19 with the fixwmf.18 - no fix
Screenshot_20210818-142833_Chrome.jpg (2×1 px, 213 KB)
Screenshot_20210818-143317_Chrome.jpg (2×1 px, 218 KB)
Screenshot_20210818-143104_Chrome.jpg (2×1 px, 180 KB)
Screen Shot 2021-08-18 at 2.43.59 PM.png (648×366 px, 34 KB)

Thanks all, LGTM!