Hi there.

Can I work this item?

From what I understand on this task, the small section in CirrusSearch README recommends setting $wgJobQueueAggregator in the Job Queue section will need to be removed entirely from the README file?

Does this includes the Jenkins Test called tests/jenkins/FullyFeaturedConfig.php which also reference the same lines of code on line 58:

 $wgJobQueueAggregator = [
	'class'       => 'JobQueueAggregatorRedis',
	'redisServer' => 'localhost',
	'redisConfig' => [
		'password' => $redisPassword,
	],
 ];

Will those lines of code need to be removed so that the test pipeline will not run this particular code anymore?

Could someone from the Discovery-Search team please answer Aacaldwell's question above? Thanks a lot!

In T287950#7256431, @Aacaldwell wrote:

Hi there.

Can I work this item?

From what I understand on this task, the small section in CirrusSearch README recommends setting $wgJobQueueAggregator in the Job Queue section will need to be removed entirely from the README file?

Yes, any reference to the variable in this file will be removed.

Does this includes the Jenkins Test called tests/jenkins/FullyFeaturedConfig.php which also reference the same lines of code on line 58:

 $wgJobQueueAggregator = [
	'class'       => 'JobQueueAggregatorRedis',
	'redisServer' => 'localhost',
	'redisConfig' => [
		'password' => $redisPassword,
	],
 ];

Will those lines of code need to be removed so that the test pipeline will not run this particular code anymore?

Yes, this will need to be removed as well. While this code is run it should have no effect today, as the code it controls was removed. Removing it should be safe and have no effect, beyond making the code easier to read and understand in the future.

@EBernhardson Hi thanks for the reply, I apologize that it took until now for me to see that there was a reply. I will work on this.

Change 771084 had a related patch set uploaded (by Aacaldwell; author: Aacaldwell):

[mediawiki/extensions/CirrusSearch@master] Removed $wgJobQueueAggregator from CirrusSearch

https://gerrit.wikimedia.org/r/771084

Change 771084 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Removed $wgJobQueueAggregator from CirrusSearch

https://gerrit.wikimedia.org/r/771084