Page MenuHomePhabricator

error handling for Item ID input
Closed, ResolvedPublic

Description

As a mismatch reviewer
I want to be notified of errors in my list of Item IDs I provide
in order to submit a valid list of IDs

Problem:
We need to handle cases where someone enters something in the Item ID input field that is not an Item ID. Cases that we should think about:

  • syntactical errors (the user gets the same error message below the input field for all of these):
    • some lines are valid IDs but others are not
    • several IDs on one line instead of one per line
  • the input field is empty -> we show a warning below the input field

Screenshots/mockups:

Syntactic validation of input (error):

Screenshot 2021-08-25 at 15.33.21.png (412×1 px, 40 KB)

Link to Figma for error message
Copy: One or more Item identifiers couldn't be processed. Please make sure to add only one identifier per line, without spaces or commas.
Item identifiers should only be a set of valid numbers preceded by the letter Q (for example: Q1256).


Empty submission attempt (warning):

Screenshot 2021-08-25 at 15.37.38.png (383×1 px, 21 KB)

Link to Figma for warning message
Copy: Please provide the Item identifiers in order to perform the check.


BDD
GIVEN an Item ID input field
AND the user inputs syntactically incorrect IDs
WHEN clicking submit
THEN an error is shown below the Item ID input field informing the user that the input has syntax issues

GIVEN an Item ID input field
AND the user leaves it empty
WHEN clicking submit
THEN a warning is shown below the Item ID input field informing the user that they need to input an Item ID

Acceptance criteria:

  • Input is syntactically validated on submit
    • We consider a line as syntactically incorrect if it is not "Q+natural numbers"
    • We only accept one ID per line, not several IDs per line
  • Warning is shown when submitting an empty list of Item IDs

Notes:

  • We only do syntactical checking. We do not check for example if an Item exists for a given Item ID.
  • The validation should happen when the button is clicked, but before the form is sent.

Event Timeline

Lydia_Pintscher renamed this task from Wikidata Ticket Template to error handling for Item ID input.Aug 3 2021, 12:05 PM

The content of this task (meaning the screenshot and the copy) is UX-approved and ready to be worked upon.

If mistakes or different content are encountered on Figma, this ticket can be treated as the ultimate source of truth.

\o/
Looking good from my side.
@Mattia_Capozzi_WMDE Please have a look and close if it is good from your side as well.

Great from my side as well :)
Closinging it! Great job!