Maniphest T287965

Skins not loading content-media feature misaligned?
Closed, ResolvedPublic
Actions

Description

In T51097#7255599, @TheDJ wrote:

Also the following features broken alignment:

https://test.wikipedia.org/wiki/Rusa_test_page_2?useskin=timeless

https://test.wikipedia.org/wiki/Rusa_test_page_2?useskin=modern

~~As well and most importantly and I think a blocker: printing in Vector is not aligning correctly.~~

Details

	Subject	Repo	Branch	Lines +/-
	Yoink 'content-media' feature from core	mediawiki/skins/Timeless	master	+504 -0
	Add content-media print styles	mediawiki/core	master	+181 -118
	Avoid use of :not selector to allow support for figure elements	mediawiki/skins/Vector	master	+5 -1
	Use sans-serif for figures	mediawiki/skins/Vector	master	+1 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Arlolra	T51097 Use figure and figcaption HTML5 elements when possible
		Resolved		Arlolra	T71353 Magnify button goes to wrong image if thumbnail caption contains images
		Resolved	BUG REPORT	TheDJ	T321442 MMV uses incorrect caption for images included in the caption of an image
		Resolved		Arlolra	T314318 Disable wgParserEnableLegacyMediaDOM on all wikis
		Resolved		Arlolra	T287965 Skins not loading content-media feature misaligned?
		Resolved		Arlolra	T318300 Media alignment broken with MinervaNeue since disabling wgParserEnableLegacyMediaDOM

Event Timeline

Arlolra created this task.Aug 3 2021, 3:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 3 2021, 3:24 PM

MBinder_WMF added a project: Parsoid-Read-Views-Deprecated-Project (Phase 0 - Parsoid-Media-Structure).Sep 3 2021, 9:30 PM

MBinder_WMF edited projects, added Parsoid; removed Parsoid-Read-Views-Deprecated-Project (Phase 0 - Parsoid-Media-Structure).Sep 3 2021, 9:37 PM

MBinder_WMF added a project: Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure).Sep 3 2021, 9:58 PM

Arlolra moved this task from Needs Triage to Media Structure on the Parsoid board.Sep 3 2021, 10:24 PM

TheDJ mentioned this in T51097: Use figure and figcaption HTML5 elements when possible.Sep 27 2021, 2:52 PM

Change 725374 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] [WIP] Add content-media print styles

https://gerrit.wikimedia.org/r/725374

gerritbot added a project: Patch-For-Review.Oct 1 2021, 9:16 PM

Arlolra mentioned this in T292577: Unexpected vertical alignment of images in mobile version.Oct 5 2021, 9:42 PM

Izno subscribed.Oct 5 2021, 10:02 PM

Change 743245 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/skins/Vector@master] Use sans-serif for figures

https://gerrit.wikimedia.org/r/743245

Change 743245 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Use sans-serif for figures

https://gerrit.wikimedia.org/r/743245

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.13; 2021-12-13).Dec 7 2021, 11:00 PM

Arlolra moved this task from Backlog to In Progress on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.Dec 8 2021, 7:36 PM

Change 745338 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Avoid use of :not selector to allow support for figure elements

https://gerrit.wikimedia.org/r/745338

Change 745338 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] Avoid use of :not selector to allow support for figure elements

Reason:

no longer needed

https://gerrit.wikimedia.org/r/745338

Change 725374 merged by jenkins-bot:

[mediawiki/core@master] Add content-media print styles

https://gerrit.wikimedia.org/r/725374

Maintenance_bot removed a project: Patch-For-Review.Dec 9 2021, 6:10 PM

As well and most importantly and I think a blocker: printing in Vector is not aligning correctly.

That part is fixed now with the above merged patch

Arlolra updated the task description. (Show Details)Dec 9 2021, 6:33 PM

Arlolra mentioned this in T305357: Long captions overflow their parent.Apr 4 2022, 4:26 PM

Arlolra merged a task: T305357: Long captions overflow their parent.

Arlolra updated the task description. (Show Details)

Arlolra updated the task description. (Show Details)Apr 4 2022, 7:46 PM

• JMcLeod_WMF moved this task from Todo to Backlog on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.May 16 2022, 3:43 PM

Also the following features broken alignment:

https://test.wikipedia.org/wiki/Rusa_test_page_2?useskin=modern

This one seems to have been fixed by Ib3b21972a41205adce5cc91e602d6f99e1b2c44b for T287410

Arlolra updated the task description. (Show Details)Jul 22 2022, 9:01 PM

Arlolra claimed this task.Jul 26 2022, 2:48 AM

Arlolra moved this task from Backlog to In Progress on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.

Change 819201 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/skins/Timeless@master] Yoink 'content-media' feature from core

https://gerrit.wikimedia.org/r/819201

gerritbot added a project: Patch-For-Review.Aug 1 2022, 11:42 PM

Arlolra moved this task from In Progress to Code Review on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.Aug 1 2022, 11:44 PM

ssastry mentioned this in T314318: Disable wgParserEnableLegacyMediaDOM on all wikis.Aug 4 2022, 4:36 PM

Arlolra added a parent task: T314318: Disable wgParserEnableLegacyMediaDOM on all wikis.Aug 4 2022, 5:18 PM

Change 819201 merged by jenkins-bot:

[mediawiki/skins/Timeless@master] Yoink 'content-media' feature from core

https://gerrit.wikimedia.org/r/819201

Maintenance_bot removed a project: Patch-For-Review.Aug 4 2022, 5:30 PM

Arlolra moved this task from Code Review to To Deploy on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.Aug 4 2022, 5:33 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 4 2022, 6:00 PM

Arlolra moved this task from To Deploy to To Verify on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.Aug 17 2022, 7:24 PM

https://test.wikipedia.org/wiki/Rusa_test_page_2?useskin=timeless

Looks good with T287965#8132059

Arlolra updated the task description. (Show Details)Aug 17 2022, 9:06 PM

This now seems ok for all the skins deployed on the wmf production cluster.

Arlolra mentioned this in T318300: Media alignment broken with MinervaNeue since disabling wgParserEnableLegacyMediaDOM.Sep 21 2022, 11:58 PM

Arlolra added a subtask: T318300: Media alignment broken with MinervaNeue since disabling wgParserEnableLegacyMediaDOM.

Arlolra closed subtask T318300: Media alignment broken with MinervaNeue since disabling wgParserEnableLegacyMediaDOM as Resolved.Oct 25 2022, 8:07 PM

Arlolra reopened subtask T318300: Media alignment broken with MinervaNeue since disabling wgParserEnableLegacyMediaDOM as Open.Nov 2 2022, 4:51 PM

Arlolra closed subtask T318300: Media alignment broken with MinervaNeue since disabling wgParserEnableLegacyMediaDOM as Resolved.Nov 3 2022, 1:58 PM