Page MenuHomePhabricator
Create Task
Maniphest T288023

GrowthExperiments: GEHelpPanelLinks causing "PHP Notice: Undefined offset: 0"
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

initGrowthConfig.php somehow resulted in a GEHelpPanelLinks array with keys starting from 1, causing this error:

normalized_message
[{reqId}] {exception_url}   PHP Notice: Undefined offset: 0
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.16/extensions/GrowthExperiments/includes/Specials/SpecialEditGrowthConfig.php(578)
#0 /srv/mediawiki/php-1.37.0-wmf.16/extensions/GrowthExperiments/includes/Specials/SpecialEditGrowthConfig.php(578): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.37.0-wmf.16/extensions/GrowthExperiments/includes/Specials/SpecialEditGrowthConfig.php(646): GrowthExperiments\Specials\SpecialEditGrowthConfig->getFormFields()
#2 /srv/mediawiki/php-1.37.0-wmf.16/extensions/GrowthExperiments/includes/Specials/SpecialEditGrowthConfig.php(723): GrowthExperiments\Specials\SpecialEditGrowthConfig->preprocessSubmittedData(array)
#3 /srv/mediawiki/php-1.37.0-wmf.16/includes/htmlform/HTMLForm.php(719): GrowthExperiments\Specials\SpecialEditGrowthConfig->onSubmit(array, OOUIHTMLForm)
#4 /srv/mediawiki/php-1.37.0-wmf.16/includes/htmlform/HTMLForm.php(609): HTMLForm->trySubmit()
#5 /srv/mediawiki/php-1.37.0-wmf.16/includes/htmlform/HTMLForm.php(625): HTMLForm->tryAuthorizedSubmit()
#6 /srv/mediawiki/php-1.37.0-wmf.16/includes/specialpage/FormSpecialPage.php(187): HTMLForm->show()
#7 /srv/mediawiki/php-1.37.0-wmf.16/extensions/GrowthExperiments/includes/Specials/SpecialEditGrowthConfig.php(114): FormSpecialPage->execute(NULL)
#8 /srv/mediawiki/php-1.37.0-wmf.16/includes/specialpage/SpecialPage.php(646): GrowthExperiments\Specials\SpecialEditGrowthConfig->execute(NULL)
#9 /srv/mediawiki/php-1.37.0-wmf.16/includes/specialpage/SpecialPageFactory.php(1365): SpecialPage->run(NULL)
#10 /srv/mediawiki/php-1.37.0-wmf.16/includes/MediaWiki.php(314): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#11 /srv/mediawiki/php-1.37.0-wmf.16/includes/MediaWiki.php(925): MediaWiki->performRequest()
#12 /srv/mediawiki/php-1.37.0-wmf.16/includes/MediaWiki.php(559): MediaWiki->main()
#13 /srv/mediawiki/php-1.37.0-wmf.16/index.php(53): MediaWiki->run()
#14 /srv/mediawiki/php-1.37.0-wmf.16/index.php(46): wfIndexMain()
#15 /srv/mediawiki/w/index.php(3): require(string)
#16 {main}

Details

Request URL
https://lt.wikipedia.org/wiki/Specialus:EditGrowthConfig
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix array key handling for GEHelpPanelLinks in on-wiki configmediawiki/extensions/GrowthExperimentswmf/1.37.0-wmf.17+5 -5
Fix array key handling for GEHelpPanelLinks in on-wiki configmediawiki/extensions/GrowthExperimentswmf/1.37.0-wmf.16+5 -5
Fix array key handling for GEHelpPanelLinks in on-wiki configmediawiki/extensions/GrowthExperimentsmaster+5 -5
Customize query in gerrit

Related Objects

Event Timeline

Tgr created this task.Aug 4 2021, 3:31 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 4 2021, 3:31 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Tgr edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Aug 4 2021, 3:38 AM
Tgr moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Aug 4 2021, 6:12 AM

Change 709880 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Fix array key handling for GEHelpPanelLinks in on-wiki config

https://gerrit.wikimedia.org/r/709880

gerritbot added a project: Patch-For-Review.Aug 4 2021, 6:12 AM
Tgr moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 4 2021, 6:12 AM
Urbanecm_WMF triaged this task as High priority.Aug 4 2021, 3:26 PM
gerritbot added a comment.Aug 4 2021, 3:47 PM

Change 709880 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Fix array key handling for GEHelpPanelLinks in on-wiki config

https://gerrit.wikimedia.org/r/709880

gerritbot added a comment.Aug 4 2021, 3:55 PM

Change 709983 had a related patch set uploaded (by Urbanecm; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.17] Fix array key handling for GEHelpPanelLinks in on-wiki config

https://gerrit.wikimedia.org/r/709983

gerritbot added a comment.Aug 4 2021, 3:56 PM

Change 709984 had a related patch set uploaded (by Urbanecm; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.16] Fix array key handling for GEHelpPanelLinks in on-wiki config

https://gerrit.wikimedia.org/r/709984

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.18; 2021-08-09).Aug 4 2021, 4:00 PM
gerritbot added a comment.Aug 4 2021, 6:20 PM

Change 709984 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.16] Fix array key handling for GEHelpPanelLinks in on-wiki config

https://gerrit.wikimedia.org/r/709984

Stashbot added a comment.Aug 4 2021, 6:30 PM

Mentioned in SAL (#wikimedia-operations) [2021-08-04T18:30:57Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.16/extensions/GrowthExperiments/: rEGRE36a2b9f58148: Fix array key handling for GEHelpPanelLinks in on-wiki config (T288023) (duration: 01m 06s)

gerritbot added a comment.Aug 4 2021, 6:38 PM

Change 709983 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.17] Fix array key handling for GEHelpPanelLinks in on-wiki config

https://gerrit.wikimedia.org/r/709983

Stashbot added a comment.Aug 4 2021, 6:41 PM

Mentioned in SAL (#wikimedia-operations) [2021-08-04T18:41:24Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.17/extensions/GrowthExperiments/: rEGRE5c3ac5823352: Fix array key handling for GEHelpPanelLinks in on-wiki config (T288023) (duration: 01m 08s)

Urbanecm_WMF closed this task as Resolved.Aug 4 2021, 6:44 PM
Urbanecm_WMF assigned this task to Tgr.
Urbanecm_WMF subscribed.

The error should no logner happen (manually verified by introducing the old config to a prod wiki temporarily).

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.17; 2021-08-02); removed MW-1.37-notes (1.37.0-wmf.18; 2021-08-09).Aug 4 2021, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 4 2021, 7:10 PM
Krinkle moved this task from Untriaged to Aug 2021 on the Wikimedia-production-error board.Aug 26 2021, 9:21 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits