| fgiunchedi | |
| Aug 4 2021, 8:23 AM |
| F34575555: gerrit_chip.png | |
| Aug 4 2021, 9:29 AM |
| F34575510: 2021-08-04-095442_221x67_scrot.png | |
| Aug 4 2021, 8:23 AM |
Upstream https://bugs.chromium.org/p/gerrit/issues/detail?id=14872
Noticed this morning after the upgrade (thank you for that!). The circles around names are misaligned on the left (only if no "icon" is next to the name? not sure), this isn't a big deal by any stretch of imagination but good to have filed.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | hashar | T288035 Gerrit names misalignment in 3.3.5 | |||
| Resolved | hashar | T290236 Upgrade Gerrit from 3.3.5 to 3.3.6 |
By default there should be a user avatar in front of the name which is made to stick to the border of the ship:
That is done by removing the left padding:
/* If the first element is the avatar, then we cancel the left padding, so we can fit nicely into the gr-account-chip rounding. The obvious alternative of 'chip has padding' and 'avatar gets negative margin' does not work, because we need 'overflow:hidden' on the label. */ :host([cancel-left-padding]) { padding-left: 0; }
Since our setup does not have the avatar icon, it is not displayed. The <span> holding the name is on its own and end up stick to the border of the chip since there is no left padding.
The change got introduced by https://gerrit-review.googlesource.com/c/gerrit/+/278254 (3.3.0 and later).
Change is merged. Backported to 3.3 here https://gerrit-review.googlesource.com/c/gerrit/+/314022
This has been fixed upstream and released in Gerrit 3.3.6 which I have deployed some minutes ago. I have confirmed it is no more happening.