Maniphest T28804

ResourceLoader should not fail when registering module by name of empty string
Closed, ResolvedPublic
Actions

Description

Author: mdale

Description:

( multiple methods calls to generate local variables ) in ResourceLoader::preloadModuleInfo you set $skin to $context->getSkin(); then for db select call $context->getSkin(); again.

In the register call you should check and throw an error for an empty $name argument since it fails in mysterious ways if you happen to mess up your array merges before your register calls.

Version: 1.18.x
Severity: enhancement

Details

Reference: bz26804

	Subject	Repo	Branch	Lines +/-
	resourceloader: Add tests to verify empty string works	mediawiki/core	master	+29 -0

Customize query in gerrit

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 11:15 PM

• bzimport added a project: MediaWiki-ResourceLoader.

• bzimport set Reference to bz26804.

• bzimport added a subscriber: Unknown Object (MLST).

• bzimport created this task.Jan 19 2011, 3:26 AM

First one fixed in r87453.

mhershberger wrote:

Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734

Krinkle moved this task from Inbox to Accepted Enhancement on the MediaWiki-ResourceLoader board.Apr 28 2015, 6:52 PM

Peter subscribed.Dec 1 2015, 5:03 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 1 2015, 5:03 PM

Change 322032 had a related patch set uploaded (by Krinkle):
resourceloader: Add tests to verify empty string works

https://gerrit.wikimedia.org/r/322032

gerritbot added a project: Patch-For-Review.Nov 17 2016, 1:15 AM

Krinkle closed this task as Resolved.Nov 17 2016, 1:15 AM

Krinkle claimed this task.

Krinkle added a project: Performance-Team.

Krinkle set Security to None.

Krinkle removed a subscriber: • wikibugs-l-list.

Change 322032 merged by jenkins-bot:
resourceloader: Add tests to verify empty string works

https://gerrit.wikimedia.org/r/322032

ReleaseTaggerBot added projects: MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)).Nov 17 2016, 2:00 AM