Page MenuHomePhabricator
Create Task
Maniphest T288076

Add restAPI endpoint that displays the popup contents
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

After discussion with @Pchelolo the new mw restapi seems to be better suited as the action API used in the original patch

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Math/+/527556/20/src/MathWikibaseConnector.php#1

Details

Due Date
Jul 14 2022, 10:00 PM
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
REST API endpoint for popupsmediawiki/extensions/Mathmaster+5 K -4 K
Make math tests dependent on Popupsintegration/configmaster+1 -1
REST API endpoint for popupsmediawiki/extensions/Mathmaster+244 -8 K
Customize query in gerrit

Related Objects
Search...

Event Timeline

Physikerwelt created this task.Aug 4 2021, 11:55 AM
Physikerwelt triaged this task as Medium priority.
Physikerwelt removed projects: Web-Team-Backlog-Archived (Tracking), Patch-Needs-Improvement, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Platform Team Workboards (Clinic Duty Team).
Physikerwelt moved this task from Inbox to Code Review on the Math board.
Physikerwelt set the point value for this task to 2.
Physikerwelt mentioned this in T208758: Display popups for annotated <math> tags without touching popups extension code.Aug 4 2021, 11:58 AM
Jdlrobson edited projects, added Page-Previews (Tracking); removed Page-Previews.Aug 5 2021, 2:48 AM
gerritbot added a comment.Aug 11 2021, 9:02 PM

Change 711691 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/Math@master] REST API endpoint for popups

https://gerrit.wikimedia.org/r/711691

gerritbot added a project: Patch-For-Review.Aug 11 2021, 9:02 PM
gerritbot added a comment.Aug 11 2021, 9:10 PM

Change 710329 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/Math@master] REST API endpoint for popups

https://gerrit.wikimedia.org/r/710329

gerritbot added a comment.Aug 11 2021, 9:11 PM

Change 711691 abandoned by Physikerwelt:

[mediawiki/extensions/Math@master] REST API endpoint for popups

Reason:

https://gerrit.wikimedia.org/r/711691

Physikerwelt removed Physikerwelt as the assignee of this task.May 19 2022, 7:56 AM
Physikerwelt added a subscriber: Stegmujo.

@Andreg-p @Stegmujo can you discuss how to proceed here? @Pchelolo left the foundation and we need to get this done on our own. Just propose a new patch and we can review this thereafter.

Physikerwelt mentioned this in T310249: Review stalled Math Patches in Gerrit.Jun 9 2022, 9:54 AM
Physikerwelt assigned this task to Andreg-p.Jun 10 2022, 9:09 AM
Physikerwelt set Due Date to Jul 14 2022, 10:00 PM.
gerritbot added a comment.Jul 12 2022, 5:47 AM

Change 813118 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[integration/config@master] Make math tests dependent on popus

https://gerrit.wikimedia.org/r/813118

gerritbot added a comment.Jul 12 2022, 9:51 AM

Change 813118 merged by jenkins-bot:

[integration/config@master] Make math tests dependent on Popups

https://gerrit.wikimedia.org/r/813118

gerritbot added a comment.Aug 6 2022, 5:56 AM

Change 710329 merged by jenkins-bot:

[mediawiki/extensions/Math@master] REST API endpoint for popups

https://gerrit.wikimedia.org/r/710329

Maintenance_bot removed a project: Patch-For-Review.Aug 6 2022, 6:30 AM
Aklapper added a comment.Aug 29 2022, 7:02 AM

@Physikerwelt / @Andreg-p: Hi, the Due Date set for this open task passed a while ago.
Could you please either update or reset the Due Date (by clicking Edit Task), or set the status of this task to resolved in case this task is done? Thanks!

Physikerwelt closed this task as Resolved.Aug 29 2022, 11:05 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits