Page MenuHomePhabricator

Notifications by a muted user are still delivered when they edit a subpage of your user talk page
Closed, ResolvedPublic

Description

Notifications by a muted user are still delivered when they edit a subpage of your user talk page (e.g. if they mention you, or comment in a topic you have subscribed to using DiscussionTools). They should only be delivered regardless of mutes when the user edits your user talk page itself (not subpages).

We've noticed this while testing the topic subscriptions feature (T285997).


The code looks like this, with a helpful comment too: (unchanged since it was added in 2017 for T150419: Allow users to restrict who can send them notifications)

[mediawiki/extensions/Echo]/includes/controller/NotificationController.php
						// Still notify for posts anywhere in
						// user's talk space
						$title->getRootText() === $user->getName() &&
						$title->getNamespace() === NS_USER_TALK

But all of the documentation I could find states that muting only has no effect on your own user talk page:

You will still receive notifications if a muted user writes or participates on your user talk page (no matter if the page uses Flow or unstructured wikitext) […]

If Bananas writes a message on User_talk:Apples or participates on their Flow page, Apples will receive a notification. This is the only type of notification that Apples will receive.

As I understand, the purpose of the muting exception is to prevent users from muting everyone else and pretending that they don't see messages (the same reason why the "Talk page message" notifications can't be disabled). If that's the case, there's no reason to ignore muting on the subpages.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 710057 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/Echo@master] Only ignore user muting for notifications on your talk page (not subpages)

https://gerrit.wikimedia.org/r/710057

Etonkovidova added a subscriber: Etonkovidova.

Confirmed - the mention from a muted user from User talk subpages will be visible; other subpages (other than User talk subpages) behave as expected - no mention notifications would be received if a sender is muted.

@Niharika -- we think that the AHT team had hands on the development of the "mute" feature, and wanted to know if you have an opinion on the correct implementation here. To sum up:

  1. Current behavior: if a muted user pings you from your user talk page or any of its subpages, you get a notification. If they ping you from anywhere else, you get no notification.
  2. Behavior in the pending patch: if a muted user pings you from your user talk page, you get a notification. If they ping you from any subpages or anywhere else, you get no notification.

Do you know which one is the desired behavior? Or if you don't know, which do you think should be the behavior?

@Niharika -- we think that the AHT team had hands on the development of the "mute" feature, and wanted to know if you have an opinion on the correct implementation here. To sum up:

  1. Current behavior: if a muted user pings you from your user talk page or any of its subpages, you get a notification. If they ping you from anywhere else, you get no notification.
  2. Behavior in the pending patch: if a muted user pings you from your user talk page, you get a notification. If they ping you from any subpages or anywhere else, you get no notification.

Do you know which one is the desired behavior? Or if you don't know, which do you think should be the behavior?

This project precedes me on the AHT team. I don't know which is the desired behavior. @SPoore maybe you recall what we decided to do and why.

@Niharika -- even though it predates you, I am still interested in what you think would be best from an AHT perspective! Thank you!

We talked as a team and decided that we do want to merge this patch, which extends muting to more pages. @Niharika -- let us know if you think differently! We're moving this to Code Review.

Change 710057 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Only ignore user muting for notifications on your talk page (not subpages)

https://gerrit.wikimedia.org/r/710057

Thanks for the patch @matmarex! Do you think this is Tech News-worthy?

Probably not… I think that users already thought it worked this way, if they thought about it at all.

Thanks for the patch @matmarex! Do you think this is Tech News-worthy?

Probably not… I think that users already thought it worked this way, if they thought about it at all.

@Tgr I think this is worthy of including in Tech News.

Thinking:

  1. I agree with @matmarex in assuming many people might have thought they would not receive notifications about edits to their subpages made by people they've muted.
  2. The software did not work in the way "1." describes.
  3. Considering "2.", I assume some people will have come to depend on the current behavior. As such, I think it would be worthwhile to broadcast this change so this group of people is more likely to know why the wiki doesn't work in the way they had gotten used to since it's unlikely they'd discover this otherwise.

Ack. A possible Tech News summary:

In the past, edits to any page in your user talk space ignored your mute list. Starting this week, this is only true for edits to your talk page. (1)

Ack. A possible Tech News summary:

In the past, edits to any page in your user talk space ignored your mute list. Starting this week, this is only true for edits to your talk page. (1)

The above looks good to me, @Tgr.

What – if anything – is left to be done to ensure the message above gets included in this week's Tech News?

What – if anything – is left to be done to ensure the message above gets included in this week's Tech News?

Usually, adding the User-notice tag is enough. Ideally, that is accompanied by suggested wording (Thank you!).
I have now added it to https://meta.wikimedia.org/wiki/Tech/News/2021/33 with a small tweak.
I will 'freeze' it for translations in about an hour, so if any further edits are needed, please ping me or do so very soon. :)

What – if anything – is left to be done to ensure the message above gets included in this week's Tech News?

Usually, adding the User-notice tag is enough. Ideally, that is accompanied by suggested wording (Thank you!).

Seamless. Okay, noted for the future!

I have now added it to https://meta.wikimedia.org/wiki/Tech/News/2021/33 with a small tweak.

"e.g. sub-pages" <-- nice addition, @Quiddity.

Etonkovidova claimed this task.

Checked on testwiki wmf.19 - works as expected. Marking the task as Resolved.

We talked as a team and decided that we do want to merge this patch, which extends muting to more pages. @Niharika -- let us know if you think differently! We're moving this to Code Review.

So sorry, I didn't see this until now. The decision makes sense to me.