Page MenuHomePhabricator
Create Task
Maniphest T288119

Office wiki and vote wiki missing logged-out user menu / log-in link
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  1. Go to https://office.wikimedia.org/

What happens?:

  1. No logged-out user menu / log-in link present

QA

This can be QAed on https://vote.wikimedia.beta.wmflabs.org/wiki/Main_Page for beta cluster, and office wiki for production.

Developer notes

the HTML is present, but it's being hidden because of the emptyPortlet class. Since the user links has special behaviour it should either override this rule with !important or remove the class before rendering.

Screen Shot 2021-08-04 at 10.54.57 AM.png (212×1 px, 56 KB)

What should have happened instead?:

Log in link should appear in user menu

QA Results - Beta

ACStatusDetails
1✅T288119#7271164

QA Results - Prod

ACStatusDetails
1✅T288119#7277833

Related Objects

Event Timeline

ovasileva created this task.Aug 4 2021, 4:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 4 2021, 4:02 PM
ovasileva triaged this task as High priority.Aug 4 2021, 4:02 PM
• alexhollender_WMF renamed this task from Office wiki missing log-in link to Office wiki missing logged-out user menu / log-in link.Aug 4 2021, 4:41 PM
• alexhollender_WMF updated the task description. (Show Details)
Jdlrobson claimed this task.Aug 4 2021, 4:41 PM
Jdlrobson removed Jdlrobson as the assignee of this task.Aug 4 2021, 5:54 PM
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Jdlrobson updated the task description. (Show Details)
Jdlrobson subscribed.
Jdlrobson renamed this task from Office wiki missing logged-out user menu / log-in link to Office wiki and vote wiki missing logged-out user menu / log-in link.Aug 5 2021, 2:19 PM
Jdlrobson merged a task: T288199: Login link missing on votewiki and loginwiki.
Jdlrobson added a subscriber: dom_walden.
Jdlrobson mentioned this in T287585: Log-in button appears twice on user links in officewiki.Aug 5 2021, 3:41 PM
LGoto set the point value for this task to 2.Aug 5 2021, 5:20 PM
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
bwang claimed this task.Aug 5 2021, 5:38 PM
bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
bwang moved this task from Doing to Code Review on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.Aug 5 2021, 6:01 PM
Jdlrobson reassigned this task from bwang to Edtadros.Aug 5 2021, 7:31 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: bwang.
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.Aug 10 2021, 12:34 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

This can be QAed on https://vote.wikimedia.beta.wmflabs.org/wiki/Main_Page for beta cluster, and office wiki for production.

✅ AC1: Log in link should appear in user menu

Screen Shot 2021-08-09 at 5.32.31 PM.png (715×944 px, 95 KB)

ovasileva mentioned this in T286732: User links: QA entire feature.Aug 10 2021, 4:44 PM
Krinkle subscribed.Aug 11 2021, 3:03 AM
In T28819#7264788, @gerritbot wrote:

Change 710320 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Ensure emptyPortlet class cannot hide user links menu

https://gerrit.wikimedia.org/r/710320

Edtadros reassigned this task from Edtadros to ovasileva.Aug 12 2021, 2:11 AM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: officewiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

This can be QAed on https://vote.wikimedia.beta.wmflabs.org/wiki/Main_Page for beta cluster, and office wiki for production.

✅ AC1: Log in link should appear in user menu

Screen Shot 2021-08-11 at 7.10.59 PM.png (301×1 px, 124 KB)

Edtadros updated the task description. (Show Details)Aug 12 2021, 2:13 AM
ovasileva closed this task as Resolved.Aug 12 2021, 5:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits