Page MenuHomePhabricator

Parameter search also filters main content area
Closed, ResolvedPublic2 Estimated Story Points

Description

Background

The parameter search as implemented in T272481: Add parameter search to sidebar of VE TemplateDialog only filters the parameter list in the sidebar. We would like to change it so that it also filters the parameter fields in the main right-side editing area. This solves a few issues and has some added benefits:

  • It will not be possible to keep editing parameters which are no longer in the list (avoiding focus issues and the possible blocked workflow of wanting to delete a parameter not in the list)
  • It will help users compare and understand the parameters which show up as a result of searching/filtering. Otherwise if they are in very different parts of the template in the order, without right-side filtering these could not be seen side-by-side.]

Requirements

  • When a search term is entered, both the sidebar and main area parameters are filtered. The parameters shown and their order should match exactly.
  • When a search term is cleared, all parameters are shown in both the sidebar and main area.

Event Timeline

Change 710249 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Filter right content side of the template dialog as well

https://gerrit.wikimedia.org/r/710249

thiemowmde moved this task from Sprint Backlog to Review on the WMDE-TechWish-Sprint-2021-08-04 board.
thiemowmde set the point value for this task to 2.

The design feels very functional, but I'm having growing pains using it. As you type, both the sidebar and content lists grow smaller:

image.png (535×990 px, 102 KB)

but the reptilian part of my brain wants both lists to match, for example in the shot below I was looking for "Exclude cover?" in the content pane. I'll need to check the box before seeing this parameter, clearly.

I think I like it, overall!

Change 710249 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Filter right content side of the template dialog as well

https://gerrit.wikimedia.org/r/710249

Change 711260 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Change filterParameter(s) event to work with a list

https://gerrit.wikimedia.org/r/711260

Change 711260 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Change filterParameter(s) event to work with a list

https://gerrit.wikimedia.org/r/711260

WMDE-Fisch moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-08-04 board.