Create a Property ID interface and use it
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Jakob_WMDE
	Aug 5 2021, 12:54 PM

Description

Per ADR 22 we want to create a new Property ID interface and use it to type hint any service that accepts both "local" and federated properties.

Decide on names for the interface and its two implementations ( URIPropertyId (federated) and NumericPropertyid ("local") were some favorites that came up during the aforementioned meeting. )
Make changes to DataModel and DataModelServices accordingly (note: might need several steps for forward compatibility)
Use the updated interface and implementations in all relevant code bases

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	DNM: test commit of squashed merge of datamodel	mediawiki/extensions/Wikibase	master	+17 K -0
	Premtively disable linting for data-model package	mediawiki/extensions/Wikibase	master	+1 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T288234 Create a Property ID interface and use it
Resolved	Tarrow	T289040 Migrate DataModel, DataModelServices, DataModelSerialization, WBInternalSerialization to Wikibase.git
Resolved	• Tonina_Zhelyazkova_WMDE	T289125 Make PropertyId into an interface and introduce NumericPropertyId
Resolved	Jakob_WMDE	T290980 Use NumericPropertyId in WikibaseLexeme
Resolved	Jakob_WMDE	T291810 Change the abstract class EntityId into an interface
Open	None	T291811 Rename `FederatedPropertyId` to `URIPropertyId`
Invalid	None	T289126 Update documentation to reflect the new PropertyId changes

Event Timeline

Jakob_WMDE created this task.Aug 5 2021, 12:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 5 2021, 12:54 PM

Rosalie_WMDE edited projects, added Wikibase - Federated Properties (Federation v2 - Sprint 4); removed Wikibase - Federated Properties.Aug 11 2021, 10:46 AM

Tarrow mentioned this in T288598: Save a statement with a federated property when Federation v2 is enabled.Aug 11 2021, 12:27 PM

Rosalie_WMDE updated the task description. (Show Details)Aug 11 2021, 2:07 PM

Rosalie_WMDE claimed this task.Aug 11 2021, 2:26 PM

Rosalie_WMDE moved this task from To do to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 4) board.

A possible plan is:

Change DataModel
- Create NumericPropertyId class in DataModel
- Change PropertyId class in DataModel to become an interface
- Release DataModel with major version bump
Change DataModelServices
- To create new NumericPropertyId()
- To use new version of DataModel
Make patch for mediawiki-vendor to use new DataModel and DataModelServices
Make patch for all Wikibase extensions with a Depends-On the vendor patch(es)

An alternative plan could be:

Add DataModel, DataModel Serialization, Internal Serialization and DataModel Services to mono-repo packages
Remove dependency from wikibase composer.json
Do refactoring of PropertyId into an interface and introduce NumericPropertyId all in one GO.

Change 713264 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/Wikibase@master] DNM: test commit of squashed merge of datamodel

https://gerrit.wikimedia.org/r/713264

gerritbot added a project: Patch-For-Review.Aug 16 2021, 2:10 PM

Looks like we plan to have a "a go" at the alternative plan of following ADR 14 and trying to make these repos part of the monorepo

https://gerrit.wikimedia.org/r/713264 is the result of using git filter-repo to rewrite the commits in datamodel before git merging into Wikibase and then subsequently squashing down.

An copy of the complete merged branch is temporarily available at: https://github.com/tarrow/Wikibase-clone/tree/includeDataModel

Specifically

Change 713277 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/Wikibase@master] Premtively disable linting for data-model package

https://gerrit.wikimedia.org/r/713277

Change 713277 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Premtively disable linting for data-model package

https://gerrit.wikimedia.org/r/713277

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.19; 2021-08-16).Aug 16 2021, 4:00 PM

• Samantha_Alipio_WMDE edited projects, added Wikibase - Federated Properties (Federation v2 - Sprint 5); removed Wikibase - Federated Properties (Federation v2 - Sprint 4).Aug 18 2021, 9:04 AM

• Samantha_Alipio_WMDE moved this task from To do to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 5) board.

Rosalie_WMDE removed Rosalie_WMDE as the assignee of this task.Aug 19 2021, 8:55 AM