1.37.0-wmf.17 deployment moved footer from bottom of the page to left column in Monobook
Closed, ResolvedPublicBUG REPORT
Actions

Description

Open https://en.wikipedia.org/wiki/Wikipedia?useskin=monobook and scroll to the bottom. The footer including license note seems to have disappeared. But it moved to the left column, have a look under the the interwiki list. It seems to be related to the recent 1.37.0-wmf.17 deployment.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/skins/MonoBook	wmf/1.37.0-wmf.17	+5 -0	Add visualClear style to MonoBook
	mediawiki/skins/MonoBook	master	+5 -0	Add visualClear style to MonoBook

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	dduvall	T281158 1.37.0-wmf.17 deployment blockers
		Resolved	BUG REPORT	Jdlrobson	T288288 1.37.0-wmf.17 deployment moved footer from bottom of the page to left column in Monobook

Event Timeline

DerHexer created this task.Aug 5 2021, 8:26 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 5 2021, 8:26 PM

DC added a subscriber: DC.Aug 5 2021, 8:28 PM

Raymond added a parent task: T281158: 1.37.0-wmf.17 deployment blockers.Aug 5 2021, 8:28 PM

This may be an instance of fallout from T287410: ResourceLoaderSkinModule: Skins should not use the legacy styling feature as mentioned by @Jdlrobson in T281158#7253330:

In T281158#7253330, @Jdlrobson wrote:

FYI to the train conductor:

This week might see some bug reports around missing user interface styles in MonoBook, Modern and CologneBlue skins relating to T287410.
This week might also see some complaints from MonoBook users due to a disruption caused by a user preference switchover which users were notified about in T285991. This is not a regression and is easily fixed by a visit to Special:Preferences.

Neither of these should be treated as deploy blockers if encountered but please redirect any users or bug reports to me and/or the relevant tickets as appropriate.

mmodell mentioned this in T287410: ResourceLoaderSkinModule: Skins should not use the legacy styling feature.Aug 5 2021, 8:45 PM

Jdforrester-WMF renamed this task from 1.37.0-wmf.17 deployment moved footer from bottom of the page to left column to 1.37.0-wmf.17 deployment moved footer from bottom of the page to left column in Monobook.Aug 5 2021, 9:00 PM

Jdforrester-WMF added a project: MonoBook.

Patch on the way..

Jdlrobson claimed this task.Aug 5 2021, 9:09 PM

Change 710359 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MonoBook@master] Add visualClear style to MonoBook

https://gerrit.wikimedia.org/r/710359

gerritbot added a project: Patch-For-Review.Aug 5 2021, 9:11 PM

Yep that ticket is the reason. Sorry for missing during code review and QA.

Jdlrobson added a project: Web-Team-Backlog (Kanbanana-FY-2021-22).Aug 5 2021, 9:12 PM

Jdlrobson moved this task from Needs Analysis to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Change 710105 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MonoBook@wmf/1.37.0-wmf.17] Add visualClear style to MonoBook

https://gerrit.wikimedia.org/r/710105

Change 710359 merged by jenkins-bot:

[mediawiki/skins/MonoBook@master] Add visualClear style to MonoBook

https://gerrit.wikimedia.org/r/710359

Jdlrobson mentioned this in rSMNB38c49703f1e8: Add visualClear style to MonoBook.Aug 5 2021, 9:28 PM

Jdforrester-WMF triaged this task as Unbreak Now! priority.Aug 5 2021, 9:30 PM

Change 710105 merged by jenkins-bot:

[mediawiki/skins/MonoBook@wmf/1.37.0-wmf.17] Add visualClear style to MonoBook

https://gerrit.wikimedia.org/r/710105

Jdforrester-WMF mentioned this in rSMNBef575d7dfdc3: Add visualClear style to MonoBook.Aug 5 2021, 9:33 PM

Mentioned in SAL (#wikimedia-operations) [2021-08-05T21:41:22Z] <jforrester@deploy1002> Synchronized php-1.37.0-wmf.17/skins/MonoBook/resources/screen-common.less: T288288 Restore visualClear style to MonoBook so that footer doesn't show in the interwiki list (duration: 01m 24s)

Jdforrester-WMF closed this task as Resolved.Aug 5 2021, 9:49 PM