Page MenuHomePhabricator

Minerva AMC User Menu and Page Actions menu labels are not vertically centered
Closed, ResolvedPublic

Description

Visit https://en.m.wikipedia.org/wiki/Barack_Obama and turn AMC on. Both the user menu and the page actions menu labels are not vertically centered with the icons:

user-menu.png (692×970 px, 93 KB)

page-actions.png (776×936 px, 211 KB)

Developer Notes

.toggle-list-item__icon is a parent span of .toggle-list-item__label (also a span) and both have a vertical-align: middle property which contributes to the label not being vertically centered. It looks like we can just remove the toggle-list-item__icon selector/element altogether as its only purpose appears to be to apply that (unneeded) style.

Acceptance Criteria

  • The labels are vertically centered with the icons.

Details

Event Timeline

Change 710363 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/skins/MinervaNeue@master] Remove .toggle-list-item__icon selector

https://gerrit.wikimedia.org/r/710363

Change 710363 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Remove .toggle-list-item__icon selector

https://gerrit.wikimedia.org/r/710363

• nray claimed this task.

This was actually fixed as part of T287522