Closing New Discussion Tool requires you to click "Cancel" twice (on pages too short to be scrollable)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• ppelberg
	Aug 6 2021, 12:03 AM

Description

Behavior

Visit a talk page that has not yet been created (e.g. https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Talk:Duke_University&action=edit&redlink=1)
- Note: it should not matter what namespace this talk page exists in.
Click the Start a discussion button within the new empty state design
Click Cancel
- Note: it is important that you have NOT entered any text into either the Title or Description fields.

Actual

❗️Notice the ⚠️ Please provide a title for your discussion topic. If you click "Add topic", your topic will be added without a title. warning appears beneath the Title field: https://youtu.be/-bppg-cGL9U.

Expected

✅ Notice the New Discussion Tool closes and you are returned to the empty state experience you saw in "Step 2."

Approaches

#1: Add a set timeout before validating
#2: Only show warning message when moving into the description field.

Done

Expected behavior is implemented

Details

	Subject	Repo	Branch	Lines +/-
	New topic tool: Show empty title warning only when focussing the description	mediawiki/extensions/DiscussionTools	master	+15 -5

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T276497 Scale DiscussionTools to all projects
Open	None	T251207 [Epic] Scale DiscussionTools to all Wikipedias
Open	None	T233446 [Epic] New Discussion Tool
Open	None	T275256 Make New Topic Tool (desktop) available as opt-out feature at all wikis
Resolved	• LZaman	T271964 [Release ticket] Make New Discussion Tool available as opt-out feature at partner wikis
Resolved	matmarex	T288316 Closing New Discussion Tool requires you to click "Cancel" twice (on pages too short to be scrollable)

Event Timeline

• ppelberg created this task.Aug 6 2021, 12:03 AM

• ppelberg updated the task description. (Show Details)

• ppelberg moved this task from Incoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.

I couldn’t reproduce it (Firefox 78.12.0esr and Chromium 90.0.4430.212 on Debian 10). But even if I could, I’m pretty sure it wasn’t constrained to not yet created talk pages, the warning appears also when starting new topics on existing talk pages.

This is the warning appearing when the focus is lost from the title, moving the cancel button out of the way before your click on it can happen. You don't actually have to click the cancel button twice, just click anywhere at all outside the title and then the cancel button.

I feel like I remember us having fixed this before somewhere...

Resolving T287901 would resolve this as well.

In T288316#7265641, @DLynch wrote:

I feel like I remember us having fixed this before somewhere...

Probably T275923.

• ppelberg moved this task from Ready to Be Worked On to Incoming on the Editing-team (Kanban Board) board.Aug 9 2021, 7:22 PM

• ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Aug 12 2021, 3:45 PM

Probably T275923.

Ah, right, and that's not working here because an empty page will be too short to be scrollable. This makes sense.

• LZaman mentioned this in T271964: [Release ticket] Make New Discussion Tool available as opt-out feature at partner wikis.Aug 26 2021, 5:43 PM

To start, we're going to implement "Approach #2".

matmarex renamed this task from Closing New Discussion Tool requires you to click "Cancel" twice to Closing New Discussion Tool requires you to click "Cancel" twice (on pages too short to be scrollable).Sep 1 2021, 6:43 PM

Change 716019 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] New topic tool: Show empty title warning only when focussing the description

https://gerrit.wikimedia.org/r/716019

gerritbot added a project: Patch-For-Review.Sep 1 2021, 7:27 PM

matmarex claimed this task.Sep 1 2021, 7:28 PM

matmarex mentioned this in T287901: Revise empty Title field warning message display logic.

matmarex moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.

Test wiki created on Patch Demo by Matma Rex using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/8f3a3d5941/w/

DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Sep 2 2021, 7:28 PM

DLynch added a project: Editing QA.

Change 716019 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] New topic tool: Show empty title warning only when focussing the description

https://gerrit.wikimedia.org/r/716019

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 2 2021, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 2 2021, 8:10 PM

Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Sep 2 2021, 9:20 PM

Ryasmeen edited projects, added Verified; removed Editing QA.Sep 2 2021, 9:23 PM

• ppelberg closed this task as Resolved.Sep 4 2021, 12:31 AM

Test wiki on Patch Demo by Matma Rex using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/8f3a3d5941/w/~~

Closing New Discussion Tool requires you to click "Cancel" twice (on pages too short to be scrollable)Closed, ResolvedPublicActions