Page MenuHomePhabricator

Improve experience when publishing a new topic to an empty talk page
Closed, InvalidPublic

Description

In T288314, we improved the experience people have when publishing a new topic to an empty talk page.

This ticket is about iterating on that initial implementation to create something that feels a bit more fluid.

Where "fluid" in this context means someone does not see an "intermediate" Loading... view in between pressing the Add topic button and the topic they've drafted being published successfully to the page. //More details in the ===Behavior section below.

Behavior

Current

1. Press Add topic and notice the NDT enters loading state❗️2. Notice the NDT and a Loading... page appears3. Notice the topic you drafted is posted to the page
Screen Shot 2021-08-09 at 5.41.49 PM.png (950×1 px, 660 KB)
Screen Shot 2021-08-09 at 5.41.58 PM.png (884×1 px, 199 KB)
Screen Shot 2021-08-09 at 5.42.06 PM.png (986×1 px, 471 KB)

Desired

1. Press Add topic and notice the NDT enters loading state✅2. Notice the topic you drafted is posted to the page
Screen Shot 2021-08-09 at 5.41.49 PM.png (950×1 px, 660 KB)
Screen Shot 2021-08-09 at 5.42.06 PM.png (986×1 px, 471 KB)

Done

  • Desired behavior is implemented

Note: you can see what's currently implemented here: https://youtu.be/aUCPBHUUCfs.

Event Timeline

This is probably the most-trivial approach: https://youtu.be/aUCPBHUUCfs

The awkward bit is that the teardown does some necessary things -- it cleans up the storage for autosave, most importantly. Could refactor the widget so that this is done elsewhere and separately-callable, of course.

Change 710385 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/DiscussionTools@master] Don't detach the reply widget when posting to an empty page

https://gerrit.wikimedia.org/r/710385

Test wiki created on Patch Demo by PPelberg (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/2889ede3b7/w/

Change 710385 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Don't detach the reply widget when posting to an empty page

https://gerrit.wikimedia.org/r/710385

matmarex added a subscriber: matmarex.

The original approach in T288314 has already been improved in that task, not sure if there's anything else we want to do.

What specifically is the concern that this task is addressing? What part of the experience does not feel fluid to you?

The original approach in T288314 has already been improved in that task, not sure if there's anything else we want to do.

While what was implemented in T288314 is an improvement, I think there is more that could be done (see the task description's newly-created ===Behavior section).

What specifically is the concern that this task is addressing? What part of the experience does not feel fluid to you?

@iamjessklein thank you for prompting – does the task description's newly-created ===Behavior section make it clear what part of the experience I think could be further improved? [i]

Moving this to Needs Discussion / Investigation so we can discuss the level of effort required to implement what this task is now asking for.

More context...

The awkward bit is that the teardown does some necessary things -- it cleans up the storage for autosave, most importantly. Could refactor the widget so that this is done elsewhere and separately-callable, of course.

While what was implemented in T288314 is an improvement, I think there is more that could be done (see the task description's newly-created ===Behavior section).

T288314 already did this, no? I think Bartosz is right that there's nothing to do here.

While what was implemented in T288314 is an improvement, I think there is more that could be done (see the task description's newly-created ===Behavior section).

T288314 already did this, no? I think Bartosz is right that there's nothing to do here.

Y'all are correct. I'm closing this task as invalid.

Reason: the current experience works in the way that is described in the task description's Desired behavior section.