Page MenuHomePhabricator

Remove use of global state in BlockErrorFormatter
Open, Needs TriagePublic

Description

Its a service, so everything should be injected...

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I'm failing to identify a single bit of global state in the class...

I'm failing to identify a single bit of global state in the class...

The direct constructor of Message objects should be replaced with an injected MessageFormatterFactory

Change 710558 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] BlockErrorFormatter: inject and use IMessageFormatterFactory

https://gerrit.wikimedia.org/r/710558

I'm failing to identify a single bit of global state in the class...

The direct constructor of Message objects should be replaced with an injected MessageFormatterFactory

Noted. Thanks.