Page MenuHomePhabricator
Create Task
Maniphest T288332

Remove use of global state in BlockErrorFormatter
Open, Needs TriagePublic
Actions

Description

Its a service, so everything should be injected...

Details

SubjectRepoBranchLines +/-
BlockErrorFormatter: inject and use IMessageFormatterFactorymediawiki/coremaster+55 -11
Customize query in gerrit

Event Timeline

DannyS712 created this task.Aug 6 2021, 8:42 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptAug 6 2021, 8:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
matej_suchanek subscribed.Aug 6 2021, 1:16 PM

I'm failing to identify a single bit of global state in the class...

DannyS712 added a comment.Aug 6 2021, 7:44 PM
In T288332#7266500, @matej_suchanek wrote:

I'm failing to identify a single bit of global state in the class...

The direct constructor of Message objects should be replaced with an injected MessageFormatterFactory

gerritbot added a comment.Aug 6 2021, 8:42 PM

Change 710558 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] BlockErrorFormatter: inject and use IMessageFormatterFactory

https://gerrit.wikimedia.org/r/710558

gerritbot added a project: Patch-For-Review.Aug 6 2021, 8:43 PM
matej_suchanek added a comment.Aug 7 2021, 10:08 AM
In T288332#7267307, @DannyS712 wrote:
In T288332#7266500, @matej_suchanek wrote:

I'm failing to identify a single bit of global state in the class...

The direct constructor of Message objects should be replaced with an injected MessageFormatterFactory

Noted. Thanks.

DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Aug 20 2021, 12:51 AM
DannyS712 removed DannyS712 as the assignee of this task.Oct 5 2023, 9:41 PM

I'm sorry that I haven't handled this task. I recently returned from a long bout of unexpected inactivity, and while I plan to resume my contributions here on Phabricator its unfair to claim tasks that I might not work on when others may be interested in handling them. I'm removing myself as the assignee in a batch-action, but if someone feels that I really should be the one to handle this task feel free to re-assign me and I'll take a look.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL