Tab font-size is not applied to menu item links
Closed, DeclinedPublicBUG REPORT
Actions

Assigned To

None

Authored By

	BrandonXLF
	Aug 6 2021, 9:04 AM

Description

Right now the tab font size is applied to the individual li elements in the vector menu list in Legacy Vector and not at all in normal Vector.

Issues

In Legacy Vector, this causes the tab font size to be applied to submenu items multiple times, making the text smaller for submenus.

In normal Vector, the tab font size is not applied to any menu items, causing menu item text to appear larger than the tab text.

Cause

Both of these issues were caused by T191021's commit, https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/702456/, which for some reason only applies the correct font size to span elements inside the links inside the menu items even though those span elements are never added anywhere. T287052 tried to fix this for Legacy Vector only, but it caused the above issue with submenus.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Apply tab font size to dropdown item links	mediawiki/skins/Vector	master	+1 -8

Customize query in gerrit

Related Objects

Mentioned In: T288367: More menu items are too large in modern Vector skin
Mentioned Here: T288367: More menu items are too large in modern Vector skin
T191021: User links: Standardize `.mw-ui-icon` to overhauled icon canvas size 20x20
T287052: Regression: More menu dropdown font-size is too big in legacy Vector

Event Timeline

BrandonXLF created this task.Aug 6 2021, 9:04 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 6 2021, 9:04 AM

Change 710500 had a related patch set uploaded (by BrandonXLF; author: BrandonXLF):

[mediawiki/skins/Vector@master] Apply tab font size to dropdown item links

https://gerrit.wikimedia.org/r/710500

gerritbot added a project: Patch-For-Review.Aug 6 2021, 9:15 AM

DMacks subscribed.Aug 6 2021, 9:21 AM

Nardog subscribed.Aug 6 2021, 9:28 AM

Vector doesn't officially support nested dropdowns. Why can this not be done as part of the gadget that adds that nested dropdown?

Possibly some overlap with T287052

cjming triaged this task as Medium priority.Aug 6 2021, 4:33 PM

cjming added a project: Web-Team-Backlog-Archived.

In T288336#7266567, @Jdlrobson wrote:

Vector doesn't officially support nested dropdowns. Why can this not be done as part of the gadget that adds that nested dropdown?

Possibly some overlap with T287052

Sure they can, but there are multiple gadgets and scripts that use submenu and I don't see a reason why this simple fix can't be made. Anyways, the fix for the font size on normal Vector also happens to resolve the issue with submenu font size, and that is definitely an issue that Vector needs to fix.

Sure they can, but there are multiple gadgets and scripts that use submenu and I don't see a reason why this simple fix can't be made. Anyways, the fix for the font size on normal Vector also happens to resolve the issue with submenu font size, and that is definitely an issue that Vector needs to fix.

The fix you provided interferes with a future planned feature that changes how menus operate (giving them icons) and turns certain menus into dropdowns where nesting is not going to work. This got broken because Vector doesn't support nested menus out the box, it only supports adding menu items through the mw.util.addPortletItem method.

It's not a good idea going forward for the maintainers of Vector to maintain nested menus on behalf of a few gadgets. Updating the gadget is just as simple and the gadget developer is in a better place to maintain this on the long run than the Vector engineers.

BrandonXLF mentioned this in T288367: More menu items are too large in modern Vector skin.Aug 6 2021, 6:48 PM

@Jdlrobson I split the part of this task about the new Vector skin off into T288367 since it was not addressed by the reason you closed this task and its really a separate issue.

Couldn't this be solved just by refining the selector .vector-menu-dropdown li to .vector-menu-dropdown li a in Legacy Vector only? Would that still interfere with the new dropdown?

Change 710500 abandoned by BrandonXLF:

[mediawiki/skins/Vector@master] Apply tab font size to dropdown item links

Reason:

Conflicts with other changes to the skin