| Jdlrobson | |
| Aug 6 2021, 2:30 PM |
| F34586177: Screenshot_20210806-072848_Chrome.jpg | |
| Aug 6 2021, 2:30 PM |
On Special:Preferences a responsive setting appears out of place.
What happens?:
What should have happened instead?:
It should be listed in the same section as the legacy Vector setting
Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| preferences: Move `skin-responsive` to the skin preferences sub-section | mediawiki/core | master | +1 -1 |
It should probably also be made first in the list (given it's a more general option than the other individual skin options that may appear there).
Hi @Baalamurgan I'm happy to help guide you with this change. Have you setup MediaWiki and Gerrit?
The line you'll want to change is this one:
https://gerrit.wikimedia.org/g/mediawiki/core/+/916c0307a06e64b49d4b7f0340808a38b6d5b9a4/includes/preferences/DefaultPreferencesFactory.php#855
I thought the code I would have to change was styling(CSS). To be honest I
am hanging up a little as I have never had gerrit before. I am analysing
and setting up my environment yet.
This will be a PHP change but should require little knowledge of PHP to fix. Once you are set up with a working MediaWiki and Gerrit I can help guide you. You can ping me on IRC (same username) if you need any help with getting itsetup. If you don't feel comfortable with PHP changes, let me know.
Change 719303 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/core@master] Responsive skin preference is in wrong place
Change 719303 merged by jenkins-bot:
[mediawiki/core@master] preferences: Move `skin-responsive` to the skin preferences sub-section