SecurePoll: Tallying an encrypted election on votewiki produces no results
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Niharika
	Aug 6 2021, 5:26 PM

Description

What's the problem?

While doing a test run for the upcoming Board election, we created "JS - Testing with encryption" election on votewiki. The election is encrypted, as the name says. It has 9 votes.
The Tally for the election did not appear to have finished (even ~an hour later). Hitting the Tally button shows:

Expected behavior:

Tally completes rather quickly given the low number of votes.

Observed behavior:

Tally did not apparently finish.

Things to note:

showJobs.php did not list any running jobs for SecurePoll when it was tried ~10 mins after kicking off the tally job

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	tallyElectionJob: Catch and log exceptions	mediawiki/extensions/SecurePoll	wmf/1.37.0-wmf.18	+141 -99
	tallyElectionJob: Catch and log exceptions	mediawiki/extensions/SecurePoll	master	+141 -99

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T277226 Make Echo notification for when tallying is done
Resolved	Tchanders	T277224 Check on TallyPage.php for tally results and display them
Resolved	• AGueyte	T277222 Create job to tally elections [M]
Resolved	phuedx	T288361 SecurePoll: Tallying an encrypted election on votewiki produces no results
Resolved	STran	T288366 Add more logging to determine what happens to jobs in the wild
Resolved	tstarling	T288711 /wiki/Special:SecurePoll/create Error: Call to a member function getId() on null

Event Timeline

Niharika created this task.Aug 6 2021, 5:26 PM

Niharika triaged this task as Medium priority.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 6 2021, 5:26 PM

Niharika raised the priority of this task from Medium to High.Aug 6 2021, 5:32 PM

Niharika edited projects, added Anti-Harassment-Team (The Letter Song); removed Anti-Harassment-Team.Aug 6 2021, 6:25 PM

• imaigwilo subscribed.Aug 6 2021, 7:54 PM

• 4nn1l2 subscribed.Aug 9 2021, 6:21 AM

For comparison, this election is also encrypted but only has 1 vote, and it finished almost immediately: https://vote.wikimedia.org/wiki/Special:SecurePoll/tally/1055

• drochford subscribed.Aug 9 2021, 6:12 PM

phuedx claimed this task.Aug 9 2021, 6:16 PM

phuedx moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment-Team (The Letter Song) board.

• AGueyte mentioned this in T277222: Create job to tally elections [M].Aug 10 2021, 7:06 PM

• AGueyte added a parent task: T277222: Create job to tally elections [M].

phuedx added a subtask: T288366: Add more logging to determine what happens to jobs in the wild.Aug 11 2021, 4:09 PM

Change 711177 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/SecurePoll@master] tallyElectionJob: Catch and log exceptions

https://gerrit.wikimedia.org/r/711177

gerritbot added a project: Patch-For-Review.Aug 11 2021, 4:11 PM

Reedy moved this task from Backlog to Immediate WMF elections needs on the MediaWiki-extensions-SecurePoll board.Aug 12 2021, 3:44 AM

Change 711177 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] tallyElectionJob: Catch and log exceptions

https://gerrit.wikimedia.org/r/711177

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.19; 2021-08-16).Aug 16 2021, 1:00 AM

Maintenance_bot removed a project: Patch-For-Review.Aug 16 2021, 1:10 AM

Change 713361 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/SecurePoll@wmf/1.37.0-wmf.18] tallyElectionJob: Catch and log exceptions

https://gerrit.wikimedia.org/r/713361

gerritbot added a project: Patch-For-Review.Aug 17 2021, 10:17 AM

Change 713361 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@wmf/1.37.0-wmf.18] tallyElectionJob: Catch and log exceptions

https://gerrit.wikimedia.org/r/713361

Maintenance_bot removed a project: Patch-For-Review.Aug 17 2021, 11:10 AM

Mentioned in SAL (#wikimedia-operations) [2021-08-17T11:29:42Z] <phuedx@deploy1002> Synchronized php-1.37.0-wmf.18/extensions/SecurePoll/includes/Jobs/TallyElectionJob.php: Backport: [[gerrit:713361|tallyElectionJob: Catch and log exceptions (T288361)]] (duration: 00m 58s)

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.18; 2021-08-09); removed MW-1.37-notes (1.37.0-wmf.19; 2021-08-16).Aug 17 2021, 12:00 PM

Niharika closed subtask T288366: Add more logging to determine what happens to jobs in the wild as Resolved.Aug 17 2021, 6:04 PM

phuedx moved this task from In Progress 💪 to QA/Testing 🐞 on the Anti-Harassment-Team (The Letter Song) board.Aug 18 2021, 11:36 AM

If we are not going to be doing UI tallying in the future, we can safely close this ticket.

If we are, we can reopen this ticket or raise another.

In T288361#7344508, @dom_walden wrote:

If we are not going to be doing UI tallying in the future, we can safely close this ticket.

If we are, we can reopen this ticket or raise another.

We do want to have UI tallying. We talked in the team meeting today and said we will test this more with T287976: [M] Add UI fallbacks for failed tally jobs and investigate the issues that make tallying unreliable at the moment.
I'll close this ticket since this specific issue has not been reproducible.

• 4nn1l2 unsubscribed.Sep 20 2021, 7:00 PM

SecurePoll: Tallying an encrypted election on votewiki produces no resultsClosed, ResolvedPublicActions