Page MenuHomePhabricator
Create Task
Maniphest T288362

[a11y] Provide a label for the logo inside MinervaNeue's footer
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
bwang
Aug 6 2021, 5:39 PM
Tags
Referenced Files
F34679438: Screen Shot 2021-10-08 at 1.28.12 PM.png
Oct 8 2021, 8:31 PM
F34673230: Screen Shot 2021-10-05 at 10.20.15 AM.png
Oct 5 2021, 5:22 PM
F34673235: Screen Shot 2021-10-05 at 10.21.59 AM.png
Oct 5 2021, 5:22 PM
Subscribers
Aklapper
bwang
Edtadros
Jdlrobson
Masumrezarock100
• nray

Description

Description

The wordmark logo inside the mobile footer is unlabeled. It is also in an h2 element, which is unnecessary and makes the heading structure of the page less clear. This was observed using VO in Chrome and Safari, but this issue should be reproducible in all screen reader/OS combinations.
https://phabricator.wikimedia.org/F34586280

Expected

  • The logo inside the footer uses the sitetitle message.
  • The logo is placed inside a div or another element instead of an h2 element

QA

QA Results - Beta

ACStatusDetails
1✅T288362#7403091
2✅T288362#7403091

QA Results - Prod

ACStatusDetails
1✅T288362#7413690
2✅T288362#7413690

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Change footer logo from a heading element to a divmediawiki/skins/MinervaNeuemaster+1 -3
Add alt attribute to logomediawiki/skins/MinervaNeuemaster+10 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

bwang created this task.Aug 6 2021, 5:39 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptAug 6 2021, 5:39 PM
bwang updated the task description. (Show Details)Aug 6 2021, 5:39 PM
Jdlrobson added a parent task: T253650: Screen reader is announcing VectorMenu dropdown as checkbox.Aug 6 2021, 7:22 PM
Jdlrobson edited parent tasks, added: T287097: [GOAL] Accessibility compliance focus (new development & fixes); removed: T253650: Screen reader is announcing VectorMenu dropdown as checkbox.Aug 6 2021, 8:03 PM
Jdlrobson added a project: Web-Team-Backlog-Archived.
Jdlrobson moved this task from Incoming to unsed on the Web-Team-Backlog-Archived board.
Jdlrobson moved this task from unsed to Needs Prioritization (Tech) on the Web-Team-Backlog-Archived board.Aug 10 2021, 8:49 PM
Jdlrobson edited projects, added Web-Team-Backlog-Archived (Needs Prioritization (Tech)); removed Web-Team-Backlog-Archived.
Jdlrobson triaged this task as Medium priority.Aug 11 2021, 2:16 PM
Jdlrobson moved this task from Backlog to Accessibility on the Web-Team-Backlog-Archived (Needs Prioritization (Tech)) board.Aug 11 2021, 6:01 PM
Jdlrobson updated the task description. (Show Details)Aug 18 2021, 7:33 PM
Jdlrobson edited projects, added Web-Team-Backlog-Archived (Kanbanana-FY-2021-22); removed Web-Team-Backlog-Archived (Needs Prioritization (Tech)).
Jdlrobson subscribed.

The logo is placed inside a div or another element instead of an h2 element

I believe the reason for the h2 is because it degrades to a heading if no logo is given. I think this could be made conditional but we'd need to test both cases.

Jdlrobson renamed this task from Provide a label for the logo inside MinervaNeue's footer to [a11y] Provide a label for the logo inside MinervaNeue's footer.Aug 18 2021, 7:34 PM
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Jdlrobson updated the task description. (Show Details)Aug 19 2021, 5:20 PM
LGoto set the point value for this task to 2.Aug 19 2021, 5:20 PM
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
bwang added a comment.Aug 19 2021, 5:31 PM

Thinking about this more, even if there's no logo and it's just text is there a particular reason why we want to use an h2? The text doesn't really describe any content, and as far as I can tell it functions more like a logo than as a section heading. If possible, I'd err on the side of using less headings to avoid complicating the page's heading structure.

• nray claimed this task.Sep 20 2021, 3:51 PM
• nray removed • nray as the assignee of this task.
• nray claimed this task.
• nray moved this task from Ready for Development to Doing on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
• nray subscribed.
gerritbot added a comment.Sep 22 2021, 12:44 AM

Change 722704 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/skins/MinervaNeue@master] Add alt attribute to logo

https://gerrit.wikimedia.org/r/722704

gerritbot added a project: Patch-For-Review.Sep 22 2021, 12:44 AM
• nray removed • nray as the assignee of this task.Sep 22 2021, 12:45 AM
• nray moved this task from Doing to Code Review on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.Sep 22 2021, 2:03 AM
• nray moved this task from Needs More Work to Code Review on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.Sep 22 2021, 4:00 PM
gerritbot added a comment.Sep 22 2021, 4:34 PM

Change 722704 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Add alt attribute to logo

https://gerrit.wikimedia.org/r/722704

Jdlrobson assigned this task to Edtadros.Sep 22 2021, 4:34 PM
Jdlrobson reassigned this task from Edtadros to • nray.
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Jdlrobson moved this task from QA to Doing on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Jdlrobson moved this task from Doing to Needs More Work on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Jdlrobson moved this task from Needs More Work to Blocked on Others on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Jdlrobson added a subscriber: Edtadros.

I thinks this is now blocked on the train, right?

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.2; 2021-09-28).Sep 22 2021, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 22 2021, 5:11 PM
• nray added a comment.Sep 23 2021, 4:58 PM

@Jdlrobson yes, blocked on train 👍

gerritbot added a comment.Sep 27 2021, 9:06 PM

Change 724179 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/skins/MinervaNeue@master] Change footer logo from a heading element to a div

https://gerrit.wikimedia.org/r/724179

gerritbot added a project: Patch-For-Review.Sep 27 2021, 9:06 PM
• nray removed • nray as the assignee of this task.Sep 28 2021, 5:13 PM
• nray moved this task from Blocked on Others to Code Review on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Jdlrobson assigned this task to Edtadros.Sep 28 2021, 5:14 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Sep 28 2021, 5:31 PM

Change 724179 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Change footer logo from a heading element to a div

https://gerrit.wikimedia.org/r/724179

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.3; 2021-10-05); removed MW-1.38-notes (1.38.0-wmf.2; 2021-09-28).Sep 28 2021, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 28 2021, 6:11 PM
PatchDemoBot added a comment.Sep 28 2021, 7:17 PM

Test wiki created on Patch Demo by NRay (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/1053c9ce83/w/

• nray updated the task description. (Show Details)Sep 28 2021, 7:24 PM
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.Oct 5 2021, 5:22 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta/patchdemo
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain. Ensure that footer still has the text "Wikipedia".

Screen Shot 2021-10-05 at 10.20.15 AM.png (931×1 px, 217 KB)

✅ AC2: Visit https://patchdemo.wmflabs.org/wikis/1053c9ce83/w/index.php?title=Main_Page&mobileaction=toggle_view_mobile. Inspect the html of the footer 's logo. The img tag should have an alt attribute set. This img element should be inside a div element.
Screen Shot 2021-10-05 at 10.21.59 AM.png (931×1 px, 195 KB)

Edtadros updated the task description. (Show Details)Oct 5 2021, 5:23 PM
Edtadros reassigned this task from Edtadros to ovasileva.Oct 8 2021, 8:31 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain. Ensure that footer still has the text "Wikipedia".

✅ AC2: Visit https://patchdemo.wmflabs.org/wikis/1053c9ce83/w/index.php?title=Main_Page&mobileaction=toggle_view_mobile. Inspect the html of the footer 's logo. The img tag should have an alt attribute set. This img element should be inside a div element.

Screen Shot 2021-10-08 at 1.28.12 PM.png (1×971 px, 440 KB)

Edtadros updated the task description. (Show Details)Oct 8 2021, 8:41 PM
ovasileva closed this task as Resolved.Oct 12 2021, 8:48 PM
PatchDemoBot added a comment.Feb 21 2022, 4:04 PM

Test wiki on Patch demo by NRay (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/1053c9ce83/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits