Page MenuHomePhabricator

[betalabs] Link recommendation edits made after saved edits in VE will have only Visual edit tag
Open, Needs TriagePublic

Description

The sequence of steps is important.

  1. Go to an article with link recommendations. Do not submit (publish) any 'yes' or 'no' answers.
  2. Switch to VE mode and made an edit. Publish it.
  3. Click on Edit and switch to Suggestions mode again.
  4. Answer 'yes' to some of the links and publish your changes.

Check View history - there will be an edit summary, e.g. Link suggestions feature: 1 link added, but the edit will be tagged only with Visual Edit tag.

Screen Shot 2021-08-06 at 1.24.24 PM.png (218×2 px, 129 KB)

Screen Shot 2021-08-06 at 2.32.00 PM.png (1×2 px, 429 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@Etonkovidova -- this issue only happens with the "edit mode toggle" work from T269653: Add a link: edit mode toggle (machine suggestions & visual), right? If so, then I think this should be a subtask of that one so @mewoph can think about it.

This is not really related to the toggle (other than that it makes interspersing normal and structured edits possible). The change tags are currently based on tracking which articles the user initiated a suggested edits worflow for; for Add Link, tracking is abandoned when the user does a normal edit to the article. The relevant behavior was added in T284217: "newcomer task add link" is assigned to edits irrelevant to structured edits.

We should probably look into adding the change tag for structured edits in a less roundabout way.

We think this is a valid problem, but for a rare use-case. Therefore, we are putting it into Triaged because we're not going to work on this within the next quarter. We may revisit it in the future.