Running update.php fails
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Tarrow
	Aug 9 2021, 9:40 AM

Description

List of steps to reproduce (step by step, including full links if applicable):

Start with a clean, empty Mediawiki install
Enable Wikibase in LocalSettings.php
Set $wgWBRepoSettings['federatedPropertiesEnabled'] = true;
Run php update.php

Work Around

set up as above
Set $wgWBRepoSettings['federatedPropertiesEnabled'] = false;
Run php update.php
Set $wgWBRepoSettings['federatedPropertiesEnabled'] = true;
Run php update.php

What happens?:
[5f9ec436b7b226e031b69051] [no req] Error: Call to a member function getSourceName() on null
Backtrace:
from /var/www/html/w/extensions/Wikibase/repo/includes/Store/Sql/DatabaseSchemaUpdater.php(171)
#0 /var/www/html/w/includes/installer/DatabaseUpdater.php(533): Wikibase\Repo\Store\Sql\DatabaseSchemaUpdater::rebuildPropertyTerms(MysqlUpdater)
#1 /var/www/html/w/includes/installer/DatabaseUpdater.php(501): DatabaseUpdater->runUpdates(array, boolean)
#2 /var/www/html/w/maintenance/update.php(193): DatabaseUpdater->doUpdates(array)
#3 /var/www/html/w/maintenance/doMaintenance.php(108): UpdateMediaWiki->execute()
#4 /var/www/html/w/maintenance/update.php(264): require_once(string)
#5 {main}

What should have happened instead?:
update.php should have exited successfully

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
Wikibase - 3239a0ce72719bf808af42a8988b441c13abb771

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Introduce and use DefaultFederatedPropertiesEntitySourceAdder	mediawiki/extensions/Wikibase	master	+134 -267

Customize query in gerrit

Related Objects

Mentioned Here: rEWBA3239a0ce7271: Localisation updates from https://translatewiki.net.

Event Timeline

Tarrow created this task.Aug 9 2021, 9:40 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 9 2021, 9:40 AM

Tarrow claimed this task.Aug 9 2021, 9:41 AM

Tarrow moved this task from To do to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 4) board.

Addshore subscribed.Aug 9 2021, 9:46 AM

Tarrow updated the task description. (Show Details)Aug 9 2021, 9:55 AM

Tarrow updated the task description. (Show Details)

Tarrow updated the task description. (Show Details)Aug 9 2021, 10:02 AM

@Jakob_WMDE correctly identified that:

so the example settings contain an entity source config for local items and properties. with $wgWBRepoSettings['federatedPropertiesEnabled'] = true; FederatedPropertiesEntitySourceDefinitionsConfigParser unsets the local property source and turns it into a fed prop source (an API source) which is why getDatabaseSourceForEntityType comes back empty

Looks like extensions/Wikibase/repo/includes/FederatedProperties/FederatedPropertiesEntitySourceDefinitionsConfigParser.php:87 is doing the wrong thing and always unsetting the db source. Of course this only happens with the default setting of sourceScriptUrl !== 'https://www.wikidata.org/w/'

Change 711128 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/Wikibase@master] Introduce and use DefaultFederatedPropertiesEntitySourceAdder

https://gerrit.wikimedia.org/r/711128

gerritbot added a project: Patch-For-Review.Aug 10 2021, 1:04 PM

Tarrow moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Federation v2 - Sprint 4) board.Aug 17 2021, 8:34 AM

Change 711128 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Introduce and use DefaultFederatedPropertiesEntitySourceAdder

https://gerrit.wikimedia.org/r/711128

• Tonina_Zhelyazkova_WMDE moved this task from Peer Review to Done on the Wikibase - Federated Properties (Federation v2 - Sprint 4) board.Aug 17 2021, 3:41 PM

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.20; 2021-08-23).Aug 17 2021, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 17 2021, 4:10 PM

Addshore closed this task as Resolved.Aug 24 2021, 9:34 AM