Page MenuHomePhabricator
Create Task
Maniphest T288443

Create a new wdio-wikibase release and update usages
Closed, ResolvedPublic
Actions

Description

In the context Google Summer of Code 2021 (GSoC '21), the webdriver.io dependencies were updated to wdio v7, including the dependency in wdio-wikibase, see wdio-wikibase#38 and T274579: Upgrade WebdriverIO to v7 in all repositories.

For this to actually be used, we still need to make a new minor(?) release of wdio-wikibase and update this dependency everywhere it is used.

Acceptance criteria 🏕️🌟(10 August 2021)

  • Released new version of wdio-wikibase to npm -> https://www.npmjs.com/package/wdio-wikibase
  • Update all of our usages (1, 2) to the newest version (not forks etc):
    • top-level Wikibase
    • Wikidata bridge
    • Tainted references -> never actually used its wdio-wikibase dependency and that dependency was also removed in the meantime
    • Termbox
    • Wikibase Lexeme
    • Wikibase release pipeline

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Update wdio-wikibase in termbox to 5.1.0Dat Nguyenwikibase/termboxmaster+12 -6
update wdio-wikibase in termbox to 5.1.0Dat Nguyenwikibase/termboxmaster+1 -1
Update wdio-wikibase in WikibaseLexeme to 5.1.0Dat Nguyenmediawiki/extensions/WikibaseLexememaster+4 -4
Update wdio-wikibase to 5.1.0Dat Nguyenmediawiki/extensions/Wikibasemaster+4 -4
Update wdio-wikibase in data-bridge to 5.1.0Dat Nguyenmediawiki/extensions/Wikibasemaster+244 -257
Update wdio-wikibase to 5.1.0 and unexpected to 12.0.3Dat Nguyenmediawiki/extensions/WikibaseLexememaster+24 -54
Update wdio-wikibase in termbox to 5.1.0Dat Nguyenwikibase/termboxmaster+117 -119
Customize query in gerrit

Related Objects

Event Timeline

Michael created this task.Aug 9 2021, 10:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 9 2021, 10:03 AM
Addshore moved this task from Inbox to To Prioritize on the [DEPRECATED] wdwb-tech board.Aug 10 2021, 8:35 AM
Tarrow mentioned this in T288512: Reduce the time to update wdio-wikibase and dependees.Aug 10 2021, 10:19 AM
Addshore triaged this task as Medium priority.Aug 10 2021, 11:46 AM
Addshore added a project: Wikidata-Campsite.
Addshore moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.
Addshore updated the task description. (Show Details)Aug 10 2021, 12:06 PM
Addshore moved this task from To Prioritize to Triaged Medium (50+) on the [DEPRECATED] wdwb-tech board.Aug 17 2021, 9:42 AM
Addshore removed a project: Wikidata-Campsite.Aug 18 2021, 8:03 AM
• zeljkofilipin added a project: User-zeljkofilipin.Aug 20 2021, 2:58 PM
• zeljkofilipin moved this task from Backlog 🪒 to Quarter 👔 on the User-zeljkofilipin board.
Addshore added a project: Wikidata-Campsite.Aug 24 2021, 10:42 AM
• toan edited projects, added: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed: Wikidata-Campsite.Aug 30 2021, 9:50 AM
dang claimed this task.Aug 30 2021, 9:51 AM
• zeljkofilipin moved this task from Quarter 👔 to Watching 📺 on the User-zeljkofilipin board.Aug 30 2021, 10:47 AM
dang moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 30 2021, 11:45 AM

Before I can release wdio-wikibase, I have to update glob-parent to 5.1.2 for security purpose

https://github.com/wmde/wdio-wikibase/pull/39

dang updated the task description. (Show Details)Aug 30 2021, 12:38 PM
dang added a comment.Aug 30 2021, 1:47 PM

Hey @Michael,
in Wikibase there is a folder named data-bridge using wdio-wikibase@3.0.1. Is it what you mean Wikidata bridge in AC?

Michael added a comment.Aug 30 2021, 1:54 PM
In T288443#7318763, @dang wrote:

Hey @Michael,
in Wikibase there is a folder named data-bridge using wdio-wikibase@3.0.1. Is it what you mean Wikidata bridge in AC?

Yes, exactly!

If you want to play around with it a bit, have a look at https://en.wikipedia.beta.wmflabs.org/wiki/Wikidata_Bridge_Showcase and https://en.wikipedia.beta.wmflabs.org/wiki/Data_bridge.

gerritbot added a comment.Aug 30 2021, 2:44 PM

Change 715528 had a related patch set uploaded (by Dat Nguyen; author: Dat Nguyen):

[mediawiki/extensions/Wikibase@master] Update wdio-wikibase to 5.1.0

https://gerrit.wikimedia.org/r/715528

gerritbot added a project: Patch-For-Review.Aug 30 2021, 2:44 PM
Addshore moved this task from Triaged Medium (50+) to Active on the [DEPRECATED] wdwb-tech board.Aug 31 2021, 11:21 AM
gerritbot added a comment.Aug 31 2021, 11:36 AM

Change 715722 had a related patch set uploaded (by Dat Nguyen; author: Dat Nguyen):

[mediawiki/extensions/Wikibase@master] Update wdio-wikibase in data-bridge to 5.1.0

https://gerrit.wikimedia.org/r/715722

dang updated the task description. (Show Details)Aug 31 2021, 12:37 PM
gerritbot added a comment.Aug 31 2021, 1:37 PM

Change 715737 had a related patch set uploaded (by Dat Nguyen; author: Dat Nguyen):

[mediawiki/extensions/WikibaseLexeme@master] Update wdio-wikibase to 5.1.0 and unexpected to 12.0.3

https://gerrit.wikimedia.org/r/715737

dang added a comment.Aug 31 2021, 1:50 PM

@Michael what do you mean by "Tainted references"?

dang updated the task description. (Show Details)Aug 31 2021, 1:53 PM
gerritbot added a comment.Aug 31 2021, 4:37 PM

Change 715762 had a related patch set uploaded (by Dat Nguyen; author: Dat Nguyen):

[wikibase/termbox@master] Update wdio-wikibase in termbox to 5.1.0

https://gerrit.wikimedia.org/r/715762

dang updated the task description. (Show Details)Aug 31 2021, 4:42 PM
dang added a comment.Aug 31 2021, 5:04 PM

Update wdio-wikibase in wikibase-release-pipeline

https://github.com/wmde/wikibase-release-pipeline/pull/211

dang updated the task description. (Show Details)Aug 31 2021, 6:06 PM
• zeljkofilipin subscribed.Sep 1 2021, 10:20 AM
In T288443#7321615, @dang wrote:

@Michael what do you mean by "Tainted references"?

A commit I created recently (714772) removed webdriverio from view/lib/wikibase-tainted-ref/package.json. I'm not sure if that's it.

dang added a comment.Sep 1 2021, 10:52 AM
In T288443#7324184, @zeljkofilipin wrote:
In T288443#7321615, @dang wrote:

@Michael what do you mean by "Tainted references"?

A commit I created recently (714772) removed webdriverio from view/lib/wikibase-tainted-ref/package.json. I'm not sure if that's it.

I just took a look at the wikibase-tainted-ref and see no wdio-wikibase too :)))))) So it means wdio-wikibase is no longer needed in wikibase-tainted-ref, right?

• zeljkofilipin added a comment.Sep 1 2021, 12:05 PM
In T288443#7324267, @dang wrote:

I just took a look at the wikibase-tainted-ref and see no wdio-wikibase too :)))))) So it means wdio-wikibase is no longer needed in wikibase-tainted-ref, right?

I think so, but I really don't know. 😄

dang updated the task description. (Show Details)Sep 1 2021, 12:05 PM
dang moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Michael added a comment.Sep 1 2021, 12:39 PM
In T288443#7324267, @dang wrote:
In T288443#7324184, @zeljkofilipin wrote:
In T288443#7321615, @dang wrote:

@Michael what do you mean by "Tainted references"?

A commit I created recently (714772) removed webdriverio from view/lib/wikibase-tainted-ref/package.json. I'm not sure if that's it.

I just took a look at the wikibase-tainted-ref and see no wdio-wikibase too :)))))) So it means wdio-wikibase is no longer needed in wikibase-tainted-ref, right?

Sorry, somehow I missed @dang's initial ping.
After asking around internally, it turned out that the tainted references browser tests are located at repo/tests/selenium/specs/tainted-ref.js, and so are probably using the dependencies defined in Wikibase's root package.json. That would mean that removing those dependencies from view/lib/wikibase-tainted-ref/package.json was indeed the right thing to do and no updating is needed there anymore.

Thank you both for looking into it 🙏

Michael updated the task description. (Show Details)Sep 1 2021, 12:41 PM
gerritbot added a comment.Sep 1 2021, 12:54 PM

Change 715953 had a related patch set uploaded (by Dat Nguyen; author: Dat Nguyen):

[wikibase/termbox@master] Update wdio-wikibase in termbox to 5.1.0

https://gerrit.wikimedia.org/r/715953

gerritbot added a comment.Sep 1 2021, 12:56 PM

Change 715762 abandoned by Dat Nguyen:

[wikibase/termbox@master] Update wdio-wikibase in termbox to 5.1.0

Reason:

redundant

https://gerrit.wikimedia.org/r/715762

gerritbot added a comment.Sep 1 2021, 1:50 PM

Change 715737 abandoned by Dat Nguyen:

[mediawiki/extensions/WikibaseLexeme@master] Update wdio-wikibase to 5.1.0 and unexpected to 12.0.3

Reason:

fail test

https://gerrit.wikimedia.org/r/715737

gerritbot added a comment.Sep 1 2021, 1:51 PM

Change 715964 had a related patch set uploaded (by Dat Nguyen; author: Dat Nguyen):

[mediawiki/extensions/WikibaseLexeme@master] Update wdio-wikibase in WikibaseLexeme to 5.1.0

https://gerrit.wikimedia.org/r/715964

gerritbot added a comment.Sep 1 2021, 4:43 PM

Change 715528 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Update wdio-wikibase to 5.1.0

https://gerrit.wikimedia.org/r/715528

gerritbot added a comment.Sep 1 2021, 4:44 PM

Change 715722 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Update wdio-wikibase in data-bridge to 5.1.0

https://gerrit.wikimedia.org/r/715722

gerritbot added a comment.Sep 1 2021, 4:44 PM

Change 715964 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Update wdio-wikibase in WikibaseLexeme to 5.1.0

https://gerrit.wikimedia.org/r/715964

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 1 2021, 5:00 PM
dang added a comment.Sep 3 2021, 11:08 AM

This one also need to be reviewed

https://github.com/wmde/wikibase-release-pipeline/pull/211

• toan subscribed.Sep 3 2021, 12:52 PM

I think everything has been updated now except https://gerrit.wikimedia.org/r/c/715953

dang added a comment.Sep 6 2021, 11:02 AM
In T288443#7330890, @toan wrote:

I think everything has been updated now except https://gerrit.wikimedia.org/r/c/715953

check again :D I re-push the earlier changes

gerritbot added a comment.Sep 13 2021, 12:58 PM

Change 720748 had a related patch set uploaded (by Dat Nguyen; author: Dat Nguyen):

[wikibase/termbox@master] update wdio-wikibase in termbox to 5.1.0

https://gerrit.wikimedia.org/r/720748

gerritbot added a comment.Sep 13 2021, 1:14 PM

Change 715953 merged by jenkins-bot:

[wikibase/termbox@master] Update wdio-wikibase in termbox to 5.1.0

https://gerrit.wikimedia.org/r/715953

• toan added a comment.Sep 13 2021, 1:15 PM

I think we've done everything here now.

• toan moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Sep 13 2021, 1:15 PM
gerritbot added a comment.Sep 13 2021, 1:15 PM

Change 720748 abandoned by Dat Nguyen:

[wikibase/termbox@master] update wdio-wikibase in termbox to 5.1.0

Reason:

Wrong commit

https://gerrit.wikimedia.org/r/720748

Lucas_Werkmeister_WMDE mentioned this in rWBTB165b9418908d: Update wdio-wikibase in termbox to 5.1.0.Sep 13 2021, 1:49 PM
Addshore closed this task as Resolved.Sep 15 2021, 2:46 PM
• zeljkofilipin mentioned this in T274579: Upgrade WebdriverIO to v7 in all repositories.Sep 15 2021, 3:42 PM
• zeljkofilipin mentioned this in T283597: Update wdio-mediawiki to 1.1.1 in all repositories.Sep 15 2021, 3:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits