Page MenuHomePhabricator

Create a new wdio-wikibase release and update usages
Closed, ResolvedPublic

Description

In the context Google Summer of Code 2021 (GSoC '21), the webdriver.io dependencies were updated to wdio v7, including the dependency in wdio-wikibase, see wdio-wikibase#38 and T274579: Upgrade WebdriverIO to v7 in all repositories.

For this to actually be used, we still need to make a new minor(?) release of wdio-wikibase and update this dependency everywhere it is used.

Acceptance criteria 🏕️🌟(10 August 2021)

  • Released new version of wdio-wikibase to npm -> https://www.npmjs.com/package/wdio-wikibase
  • Update all of our usages (1, 2) to the newest version (not forks etc):
    • top-level Wikibase
    • Wikidata bridge
    • Tainted references -> never actually used its wdio-wikibase dependency and that dependency was also removed in the meantime
    • Termbox
    • Wikibase Lexeme
    • Wikibase release pipeline

Event Timeline

Hey @Michael,
in Wikibase there is a folder named data-bridge using wdio-wikibase@3.0.1. Is it what you mean Wikidata bridge in AC?

Hey @Michael,
in Wikibase there is a folder named data-bridge using wdio-wikibase@3.0.1. Is it what you mean Wikidata bridge in AC?

Yes, exactly!

If you want to play around with it a bit, have a look at https://en.wikipedia.beta.wmflabs.org/wiki/Wikidata_Bridge_Showcase and https://en.wikipedia.beta.wmflabs.org/wiki/Data_bridge.

Change 715528 had a related patch set uploaded (by Dat Nguyen; author: Dat Nguyen):

[mediawiki/extensions/Wikibase@master] Update wdio-wikibase to 5.1.0

https://gerrit.wikimedia.org/r/715528

Change 715722 had a related patch set uploaded (by Dat Nguyen; author: Dat Nguyen):

[mediawiki/extensions/Wikibase@master] Update wdio-wikibase in data-bridge to 5.1.0

https://gerrit.wikimedia.org/r/715722

Change 715737 had a related patch set uploaded (by Dat Nguyen; author: Dat Nguyen):

[mediawiki/extensions/WikibaseLexeme@master] Update wdio-wikibase to 5.1.0 and unexpected to 12.0.3

https://gerrit.wikimedia.org/r/715737

@Michael what do you mean by "Tainted references"?

Change 715762 had a related patch set uploaded (by Dat Nguyen; author: Dat Nguyen):

[wikibase/termbox@master] Update wdio-wikibase in termbox to 5.1.0

https://gerrit.wikimedia.org/r/715762

@Michael what do you mean by "Tainted references"?

A commit I created recently (714772) removed webdriverio from view/lib/wikibase-tainted-ref/package.json. I'm not sure if that's it.

@Michael what do you mean by "Tainted references"?

A commit I created recently (714772) removed webdriverio from view/lib/wikibase-tainted-ref/package.json. I'm not sure if that's it.

I just took a look at the wikibase-tainted-ref and see no wdio-wikibase too :)))))) So it means wdio-wikibase is no longer needed in wikibase-tainted-ref, right?

I just took a look at the wikibase-tainted-ref and see no wdio-wikibase too :)))))) So it means wdio-wikibase is no longer needed in wikibase-tainted-ref, right?

I think so, but I really don't know. 😄

@Michael what do you mean by "Tainted references"?

A commit I created recently (714772) removed webdriverio from view/lib/wikibase-tainted-ref/package.json. I'm not sure if that's it.

I just took a look at the wikibase-tainted-ref and see no wdio-wikibase too :)))))) So it means wdio-wikibase is no longer needed in wikibase-tainted-ref, right?

Sorry, somehow I missed @dang's initial ping.
After asking around internally, it turned out that the tainted references browser tests are located at repo/tests/selenium/specs/tainted-ref.js, and so are probably using the dependencies defined in Wikibase's root package.json. That would mean that removing those dependencies from view/lib/wikibase-tainted-ref/package.json was indeed the right thing to do and no updating is needed there anymore.

Thank you both for looking into it 🙏

Change 715953 had a related patch set uploaded (by Dat Nguyen; author: Dat Nguyen):

[wikibase/termbox@master] Update wdio-wikibase in termbox to 5.1.0

https://gerrit.wikimedia.org/r/715953

Change 715762 abandoned by Dat Nguyen:

[wikibase/termbox@master] Update wdio-wikibase in termbox to 5.1.0

Reason:

redundant

https://gerrit.wikimedia.org/r/715762

Change 715737 abandoned by Dat Nguyen:

[mediawiki/extensions/WikibaseLexeme@master] Update wdio-wikibase to 5.1.0 and unexpected to 12.0.3

Reason:

fail test

https://gerrit.wikimedia.org/r/715737

Change 715964 had a related patch set uploaded (by Dat Nguyen; author: Dat Nguyen):

[mediawiki/extensions/WikibaseLexeme@master] Update wdio-wikibase in WikibaseLexeme to 5.1.0

https://gerrit.wikimedia.org/r/715964

Change 715528 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Update wdio-wikibase to 5.1.0

https://gerrit.wikimedia.org/r/715528

Change 715722 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Update wdio-wikibase in data-bridge to 5.1.0

https://gerrit.wikimedia.org/r/715722

Change 715964 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Update wdio-wikibase in WikibaseLexeme to 5.1.0

https://gerrit.wikimedia.org/r/715964

I think everything has been updated now except https://gerrit.wikimedia.org/r/c/715953

check again :D I re-push the earlier changes

Change 720748 had a related patch set uploaded (by Dat Nguyen; author: Dat Nguyen):

[wikibase/termbox@master] update wdio-wikibase in termbox to 5.1.0

https://gerrit.wikimedia.org/r/720748

Change 715953 merged by jenkins-bot:

[wikibase/termbox@master] Update wdio-wikibase in termbox to 5.1.0

https://gerrit.wikimedia.org/r/715953

I think we've done everything here now.

Change 720748 abandoned by Dat Nguyen:

[wikibase/termbox@master] update wdio-wikibase in termbox to 5.1.0

Reason:

Wrong commit

https://gerrit.wikimedia.org/r/720748