Page MenuHomePhabricator

Font-size rules apply to headings in the interface as well as content area (User menu not aligned on bnwiki)
Closed, ResolvedPublic2 Estimated Story Points

Description

Background

The new user menu is misaligned on bnwiki

Steps to reproduce

Go to https://bn.wikipedia.org/wiki/%E0%A6%AA%E0%A7%8D%E0%A6%B0%E0%A6%A7%E0%A6%BE%E0%A6%A8_%E0%A6%AA%E0%A6%BE%E0%A6%A4%E0%A6%BE?vectoruserlinks=1&useskinversion=2&uselang=bn as a logged-in users (bug also happens when logged-out)

Observed

Screen Shot 2021-08-10 at 11.36.25 AM.png (446×1 px, 85 KB)

Expected

User menu should be aligned with other icons

Developer notes

Option 1 (suggested)

Override line height to 0 for the heading in this context.

Option 2 (rejected as significant work/risk)

Don't use h3 in usermenu. Requires refactoring of menu code

Option 3 (rejected as the line height rules should apply to headings in sidebar)

This appears to relate to rules in MediaWiki core relating to font-sizes in certain languages:
https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki.skinning/i18n-headings.less#L49

These rules should be scoped to the article content area and not apply to headings outside the content e.g. .mw-body-content
line-height: 1.4em;

Related to T285972

QA Results - Beta

ACStatusDetails
1T288540#7303680

QA Results - Beta

ACStatusDetails
1T288540#7308341

Event Timeline

Jdlrobson renamed this task from User menu not aligned on bnwiki to Font-size rules apply to headings in the interface as well as content area (User menu not aligned on bnwiki).Aug 10 2021, 5:33 PM
Jdlrobson updated the task description. (Show Details)
bwang removed bwang as the assignee of this task.
bwang added a subscriber: bwang.

Change 712554 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Override user menu line height

https://gerrit.wikimedia.org/r/712554

Change 712554 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Override user menu line height

https://gerrit.wikimedia.org/r/712554

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: User menu should be aligned with the rest of the menu.

Screen Shot 2021-08-23 at 7.44.55 PM.png (307×1 px, 70 KB)

Screen Shot 2021-08-23 at 7.44.50 PM.png (307×1 px, 88 KB)

Edtadros added a subscriber: Edtadros.

Test Result - Prod

Status: ✅ PASS
Environment: bnwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: User menu should be aligned with the rest of the menu.

Screen Shot 2021-08-25 at 6.57.41 AM.png (698×1 px, 120 KB)

Screen Shot 2021-08-25 at 6.57.27 AM.png (698×1 px, 260 KB)