Page MenuHomePhabricator

Add a link: additional impression event recorded for onboarding dialog
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Load article w/link suggestions
  • Switch to VE or reload the page

What happens?:
There is a stray event recorded from the intro tour - action: "impression", action_data: "dont_show_again=false".
It gets recorded every time a user switches between VE mode and Suggestions mode and the intro tour is not shown to a user.

What should have happened instead?:
No impression event should be recorded when the onboarding dialog is not shown.

Event Timeline

AddLinkOnboardingDialog is initialized (thus an impression event is recorded) even if it's not shown, since the dialog is included all the time instead of lazy loaded so that it can be shown as soon as possible.

Change 711203 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add a link: only record impression event for onboarding dialog panel when it's shown

https://gerrit.wikimedia.org/r/711203

Change 711203 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add a link: only record impression event for onboarding dialog panel when it's shown

https://gerrit.wikimedia.org/r/711203