Page MenuHomePhabricator
Create Task
Maniphest T288563

TypeError: Argument 1 passed to MediaWiki\Revision\RevisionStore::newRevisionFromRowAndSlots() must be an instance of stdClass
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   TypeError: Argument 1 passed to MediaWiki\Revision\RevisionStore::newRevisionFromRowAndSlots() must be an instance of stdClass, instance of Flow\Formatter\ContributionsRow given, called in /srv/mediawiki/php-1.37.0-wmf.18/inclu
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.18/includes/Revision/RevisionStore.php(1653)
#0 /srv/mediawiki/php-1.37.0-wmf.18/includes/Revision/RevisionStore.php(1556): MediaWiki\Revision\RevisionStore->newRevisionFromRowAndSlots(Flow\Formatter\ContributionsRow, NULL, integer, NULL, boolean)
#1 /srv/mediawiki/php-1.37.0-wmf.18/includes/specials/pagers/ContribsPager.php(601): MediaWiki\Revision\RevisionStore->newRevisionFromRow(Flow\Formatter\ContributionsRow, integer, NULL)
#2 /srv/mediawiki/php-1.37.0-wmf.18/includes/specials/pagers/ContribsPager.php(635): ContribsPager->tryCreatingRevisionRecord(Flow\Formatter\ContributionsRow, NULL)
#3 /srv/mediawiki/php-1.37.0-wmf.18/includes/pager/IndexPager.php(611): ContribsPager->formatRow(Flow\Formatter\ContributionsRow)
#4 /srv/mediawiki/php-1.37.0-wmf.18/includes/specials/SpecialContributions.php(318): IndexPager->getBody()
#5 /srv/mediawiki/php-1.37.0-wmf.18/includes/poolcounter/PoolCounterWorkViaCallback.php(74): SpecialContributions->{closure}()
#6 /srv/mediawiki/php-1.37.0-wmf.18/includes/poolcounter/PoolCounterWork.php(162): PoolCounterWorkViaCallback->doWork()
#7 /srv/mediawiki/php-1.37.0-wmf.18/includes/specials/SpecialContributions.php(333): PoolCounterWork->execute()
#8 /srv/mediawiki/php-1.37.0-wmf.18/includes/specialpage/SpecialPage.php(646): SpecialContributions->execute(string)
#9 /srv/mediawiki/php-1.37.0-wmf.18/includes/specialpage/SpecialPageFactory.php(1365): SpecialPage->run(string)
#10 /srv/mediawiki/php-1.37.0-wmf.18/includes/MediaWiki.php(314): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#11 /srv/mediawiki/php-1.37.0-wmf.18/includes/MediaWiki.php(925): MediaWiki->performRequest()
#12 /srv/mediawiki/php-1.37.0-wmf.18/includes/MediaWiki.php(559): MediaWiki->main()
#13 /srv/mediawiki/php-1.37.0-wmf.18/index.php(53): MediaWiki->run()
#14 /srv/mediawiki/php-1.37.0-wmf.18/index.php(46): wfIndexMain()
#15 /srv/mediawiki/w/index.php(3): require(string)
#16 {main}
Impact

10 erros in the last 30 min on group0

Notes

Details

Request URL
https://www.mediawiki.org/wiki/Special:Contributions/Micki
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
ContribsPager row filtering with RevisionStore::isRevisionRowmediawiki/corewmf/1.37.0-wmf.18+113 -19
ContribsPager row filtering with RevisionStore::isRevisionRowmediawiki/coremaster+113 -19
Fix TypeError in Special:Contirbutionsmediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

jeena created this task.Aug 10 2021, 7:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 10 2021, 7:29 PM
jeena added a parent task: T281159: 1.37.0-wmf.18 deployment blockers.Aug 10 2021, 7:38 PM
Zabe subscribed.Aug 10 2021, 7:45 PM
Etonkovidova subscribed.EditedAug 10 2021, 7:46 PM

On testwiki wmf.18 - Special:Contirbutions will produce the error.
mediwiki wmg.18 Special:Contiributions will display [648913f3-a1fd-4b14-bb87-78807ced0197] 2021-08-10 19:43:46: Fatal exception of type "TypeError".

Other Special pages seem to be fine.

Zabe triaged this task as Unbreak Now! priority.Aug 10 2021, 8:19 PM
kostajh added a project: StructuredDiscussions.Aug 10 2021, 8:24 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 10 2021, 8:24 PM
Legoktm added subscribers: tchin, Legoktm.Aug 10 2021, 8:32 PM

I think it's caused by rMW077b9af96018: Replace Assert::parameterType with typehints by @tchin

Urbanecm subscribed.Aug 10 2021, 8:53 PM

FYI this breaks special:Contributions (in certain cases), which means patrollers cannot really do their jobs with this bug in place. I'd appreciate a rollback.

Tgr subscribed.Aug 10 2021, 8:58 PM

The trivial fix is to drop the stdClass typehint from the first parameter of RevisionStore::newRevisionFromRowAndSlots(). Seems like Flow is doing something quite messy here, though - the object comes from a DB query result in IndexPager::getBody() so no idea how it ends up with the type Flow\Formatter\ContributionsRow.

Tgr added a comment.Aug 10 2021, 9:01 PM

Also the class had a Assert::parameterType( \stdClass::class, $row, '$row' ); check previously, so how is that different from a type hint?

gerritbot added a comment.Aug 10 2021, 9:05 PM

Change 711204 had a related patch set uploaded (by TChin; author: TChin):

[mediawiki/core@master] Fix TypeError in Special:Contirbutions

https://gerrit.wikimedia.org/r/711204

gerritbot added a project: Patch-For-Review.Aug 10 2021, 9:05 PM
tchin edited subscribers, added: • Pchelolo; removed: Tgr.Aug 10 2021, 9:05 PM

TIL that exceptions and throwables are different things in PHP. ContribsPager.php just needs to catch a Throwable now instead of Exception.

tchin added a subscriber: Tgr.Aug 10 2021, 9:06 PM
Tgr added a comment.Aug 10 2021, 9:31 PM

Throwable is relatively recent (PHP 7). Any code trying to catch Exception has probably been written before that and should be fixed. Filed as T288582: Most try-catch clauses in MediaWiki should use Throwable instead of Exception.

gerritbot added a comment.Aug 10 2021, 10:16 PM

Change 711204 abandoned by TChin:

[mediawiki/core@master] Fix TypeError in Special:Contirbutions

Reason:

Taking a different approach to the issue -- patch will be submitted by someone else

https://gerrit.wikimedia.org/r/711204

gerritbot added a comment.Aug 10 2021, 10:35 PM

Change 711219 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] ContribsPager row filtering with RevisionStore::isRevisionRow

https://gerrit.wikimedia.org/r/711219

PatchDemoBot added a comment.Aug 10 2021, 11:40 PM

Test wiki created on Patch Demo by PPchelko (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/451fed4188/w/

gerritbot added a comment.Aug 11 2021, 3:31 AM

Change 711219 merged by jenkins-bot:

[mediawiki/core@master] ContribsPager row filtering with RevisionStore::isRevisionRow

https://gerrit.wikimedia.org/r/711219

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.19; 2021-08-16).Aug 11 2021, 4:00 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 11 2021, 4:10 AM
gerritbot added a comment.Aug 11 2021, 5:01 PM

Change 710722 had a related patch set uploaded (by Jforrester; author: Tim Starling):

[mediawiki/core@wmf/1.37.0-wmf.18] ContribsPager row filtering with RevisionStore::isRevisionRow

https://gerrit.wikimedia.org/r/710722

gerritbot added a project: Patch-For-Review.Aug 11 2021, 5:01 PM
gerritbot added a comment.Aug 11 2021, 5:27 PM

Change 710722 merged by jenkins-bot:

[mediawiki/core@wmf/1.37.0-wmf.18] ContribsPager row filtering with RevisionStore::isRevisionRow

https://gerrit.wikimedia.org/r/710722

Stashbot added a comment.Aug 11 2021, 5:32 PM

Mentioned in SAL (#wikimedia-operations) [2021-08-11T17:32:31Z] <jforrester@deploy1002> Synchronized php-1.37.0-wmf.18/includes/Revision/RevisionStore.php: T288563 Don't explode Special:Contributions on extension-formatted rows (1/3) (duration: 01m 09s)

Stashbot added a comment.Aug 11 2021, 5:34 PM

Mentioned in SAL (#wikimedia-operations) [2021-08-11T17:34:01Z] <jforrester@deploy1002> Synchronized php-1.37.0-wmf.18/includes/Revision/RevisionFactory.php: T288563 Don't explode Special:Contributions on extension-formatted rows (2/3) (duration: 01m 08s)

Stashbot added a comment.Aug 11 2021, 5:35 PM

Mentioned in SAL (#wikimedia-operations) [2021-08-11T17:35:42Z] <jforrester@deploy1002> Synchronized php-1.37.0-wmf.18/includes/specials/pagers/ContribsPager.php: T288563 Don't explode Special:Contributions on extension-formatted rows (3/3) (duration: 01m 06s)

Jdforrester-WMF closed this task as Resolved.Aug 11 2021, 5:36 PM
Jdforrester-WMF assigned this task to tstarling.
ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.18; 2021-08-09); removed MW-1.37-notes (1.37.0-wmf.19; 2021-08-16).Aug 11 2021, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 11 2021, 6:10 PM
• mewoph merged a task: T289014: TypeError: Argument 1 passed to MediaWiki\Revision\RevisionStore::newRevisionFromArchiveRowAndSlots() must be an instance of stdClass, instance of Flow\Formatter\DeletedContributionsRow given, called in /srv/mediawiki/php-1.37.0-wmf.18/includes/Revision/RevisionStore.php on line 1535.Aug 16 2021, 10:06 PM
• mewoph subscribed.
Zabe reopened this task as Open.Aug 16 2021, 10:12 PM

It looks like DeletedContribsPager.php also needs a fix. I get a TypeError when I go to https://www.mediawiki.org/wiki/Special:DeletedContributions/Matin235.

• mewoph moved this task from Inbox to Needs Discussion on the Growth-Team board.Aug 16 2021, 10:13 PM
Zabe moved this task from Untriaged to Aug 2021 on the Wikimedia-production-error board.Aug 17 2021, 12:28 PM
Urbanecm closed this task as Resolved.Aug 17 2021, 12:49 PM
In T288563#7286912, @Zabe wrote:

It looks like DeletedContribsPager.php also needs a fix. I get a TypeError when I go to https://www.mediawiki.org/wiki/Special:DeletedContributions/Matin235.

Confirmed:

[60cec1f4-8b88-49e1-a0eb-b68b84121cd5] /wiki/Special:DeletedContributions/Matin235   TypeError: Argument 1 passed to MediaWiki\Revision\RevisionStore::newRevisionFromArchiveRowAndSlots() must be an instance of stdClass, instance of Flow\Formatter\DeletedContributionsRow given, called in /srv/mediawiki/php-1.37.0-wmf.18/includes/Revision/RevisionStore.php on line 1535
from /srv/mediawiki/php-1.37.0-wmf.18/includes/Revision/RevisionStore.php(1578)
#0 /srv/mediawiki/php-1.37.0-wmf.18/includes/Revision/RevisionStore.php(1535): MediaWiki\Revision\RevisionStore->newRevisionFromArchiveRowAndSlots(Flow\Formatter\DeletedContributionsRow, NULL, integer, NULL, array)
#1 /srv/mediawiki/php-1.37.0-wmf.18/includes/specials/pagers/DeletedContribsPager.php(267): MediaWiki\Revision\RevisionStore->newRevisionFromArchiveRow(Flow\Formatter\DeletedContributionsRow)
#2 /srv/mediawiki/php-1.37.0-wmf.18/includes/pager/IndexPager.php(611): DeletedContribsPager->formatRow(Flow\Formatter\DeletedContributionsRow)
#3 /srv/mediawiki/php-1.37.0-wmf.18/includes/specials/SpecialDeletedContributions.php(170): IndexPager->getBody()
#4 /srv/mediawiki/php-1.37.0-wmf.18/includes/specialpage/SpecialPage.php(646): SpecialDeletedContributions->execute(string)
#5 /srv/mediawiki/php-1.37.0-wmf.18/includes/specialpage/SpecialPageFactory.php(1365): SpecialPage->run(string)
#6 /srv/mediawiki/php-1.37.0-wmf.18/includes/MediaWiki.php(314): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#7 /srv/mediawiki/php-1.37.0-wmf.18/includes/MediaWiki.php(925): MediaWiki->performRequest()
#8 /srv/mediawiki/php-1.37.0-wmf.18/includes/MediaWiki.php(559): MediaWiki->main()
#9 /srv/mediawiki/php-1.37.0-wmf.18/index.php(53): MediaWiki->run()
#10 /srv/mediawiki/php-1.37.0-wmf.18/index.php(46): wfIndexMain()
#11 /srv/mediawiki/w/index.php(3): require(string)
#12 {main}

I'm going to close this task again, and reopen @mewoph's one, as this is currently flagged as a past train blocker (and an UBN), and I don't think neither of those flags should apply for the new bug (and I don't want to simply declassify this as a train blocker).

Urbanecm mentioned this in T289014: TypeError: Argument 1 passed to MediaWiki\Revision\RevisionStore::newRevisionFromArchiveRowAndSlots() must be an instance of stdClass, instance of Flow\Formatter\DeletedContributionsRow given, called in /srv/mediawiki/php-1.37.0-wmf.18/includes/Revision/RevisionStore.php on line 1535.Aug 17 2021, 12:50 PM
PatchDemoBot added a comment.Jan 20 2022, 2:59 PM

Test wiki on Patch demo by PPchelko (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/451fed4188/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits