Wikimedia\Rdbms\DBQueryError: Error 1066: Not unique table/alias: 'page'
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	jeena
	Aug 10 2021, 7:33 PM

Description

Error

mwversion: 1.37.0-wmf.18
reqId: dfa51ed1-da5c-42fe-8dfd-5fed929d2a87
Find reqId in Logstash
Find normalized_message in Logstash

normalized_message

[{reqId}] {exception_url}   Wikimedia\Rdbms\DBQueryError: Error 1066: Not unique table/alias: 'page' (db2127)
Function: SpecialWhatLinksHere::showIndirectLinks
Query: SELECT  page_id,page_namespace,page_title,rd_from,rd_fragment,page_is_redirect  FROM `re

exception.trace

from /srv/mediawiki/php-1.37.0-wmf.18/includes/libs/rdbms/database/Database.php(1794)
#0 /srv/mediawiki/php-1.37.0-wmf.18/includes/libs/rdbms/database/Database.php(1778): Wikimedia\Rdbms\Database->getQueryException(string, integer, string, string)
#1 /srv/mediawiki/php-1.37.0-wmf.18/includes/libs/rdbms/database/Database.php(1753): Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, integer, string, string)
#2 /srv/mediawiki/php-1.37.0-wmf.18/includes/libs/rdbms/database/Database.php(1312): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean)
#3 /srv/mediawiki/php-1.37.0-wmf.18/includes/libs/rdbms/database/Database.php(1997): Wikimedia\Rdbms\Database->query(string, string, integer)
#4 /srv/mediawiki/php-1.37.0-wmf.18/includes/libs/rdbms/querybuilder/SelectQueryBuilder.php(620): Wikimedia\Rdbms\Database->select(array, array, array, string, array, array)
#5 /srv/mediawiki/php-1.37.0-wmf.18/includes/specials/SpecialWhatLinksHere.php(262): Wikimedia\Rdbms\SelectQueryBuilder->fetchResultSet()
#6 /srv/mediawiki/php-1.37.0-wmf.18/includes/specials/SpecialWhatLinksHere.php(146): SpecialWhatLinksHere->showIndirectLinks(integer, Title, integer, integer, string)
#7 /srv/mediawiki/php-1.37.0-wmf.18/includes/specialpage/SpecialPage.php(646): SpecialWhatLinksHere->execute(string)
#8 /srv/mediawiki/php-1.37.0-wmf.18/includes/specialpage/SpecialPageFactory.php(1365): SpecialPage->run(string)
#9 /srv/mediawiki/php-1.37.0-wmf.18/includes/MediaWiki.php(314): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#10 /srv/mediawiki/php-1.37.0-wmf.18/includes/MediaWiki.php(925): MediaWiki->performRequest()
#11 /srv/mediawiki/php-1.37.0-wmf.18/includes/MediaWiki.php(559): MediaWiki->main()
#12 /srv/mediawiki/php-1.37.0-wmf.18/index.php(53): MediaWiki->run()
#13 /srv/mediawiki/php-1.37.0-wmf.18/index.php(46): wfIndexMain()
#14 /srv/mediawiki/w/index.php(3): require(string)
#15 {main}

Impact

3 errors in the last 30 min on group0

Notes

Details

Request URL: https://www.mediawiki.org/w/index.php?title=*&hidelinks=*

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+1 -1	Fix SelectQueryBuilder use in SpecialWhatLinksHere
	mediawiki/core	wmf/1.37.0-wmf.18	+1 -1	Fix SelectQueryBuilder use in SpecialWhatLinksHere

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	jeena	T281159 1.37.0-wmf.18 deployment blockers
		Resolved	PRODUCTION ERROR	• Lucas_Werkmeister_WMDE	T288565 Wikimedia\Rdbms\DBQueryError: Error 1066: Not unique table/alias: 'page'

Event Timeline

jeena created this task.Aug 10 2021, 7:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 10 2021, 7:33 PM

jeena triaged this task as Unbreak Now! priority.Aug 10 2021, 9:15 PM

jeena added a parent task: T281159: 1.37.0-wmf.18 deployment blockers.

Full error:

Error 1066: Not unique table/alias: 'page' (db2127)
Function: SpecialWhatLinksHere::showIndirectLinks
Query: SELECT  page_id,page_namespace,page_title,rd_from,rd_fragment,page_is_redirect  FROM `redirect` JOIN `page` ON ((rd_from = page_id)) JOIN `page` ON ((rd_from = page_id))   WHERE rd_namespace = […] AND rd_title = '[…]'  ORDER BY rd_from ASC LIMIT 51

File touched by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/675998 which landed this train. Presumably it's not happy about the secondary join on the same table, but it's not clear to me how this patch makes that happen?

Jdforrester-WMF added subscribers: Mmeller, tstarling.Aug 10 2021, 11:16 PM

Change 711373 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/core@master] Fix SelectQueryBuilder use in SpecialWhatLinksHere

https://gerrit.wikimedia.org/r/711373

gerritbot added a project: Patch-For-Review.Aug 11 2021, 8:23 AM

• Lucas_Werkmeister_WMDE added a subscriber: • Lucas_Werkmeister_WMDE.Aug 11 2021, 8:23 AM

I guess that might trip up a number of people (the tendency to use 'tables(...)' instead of relying on join() to add those other tables.

Can be reproduced at https://test.wikipedia.org/wiki/Special:WhatLinksHere/Main_Page?hidelinks=1 – I’ll backport my change soon and see if that fixes it.

Change 711373 merged by jenkins-bot:

[mediawiki/core@master] Fix SelectQueryBuilder use in SpecialWhatLinksHere

https://gerrit.wikimedia.org/r/711373

Change 710719 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/core@wmf/1.37.0-wmf.18] Fix SelectQueryBuilder use in SpecialWhatLinksHere

https://gerrit.wikimedia.org/r/710719

Change 710719 merged by jenkins-bot:

[mediawiki/core@wmf/1.37.0-wmf.18] Fix SelectQueryBuilder use in SpecialWhatLinksHere

https://gerrit.wikimedia.org/r/710719

Mentioned in SAL (#wikimedia-operations) [2021-08-11T09:50:29Z] <lucaswerkmeister-wmde@deploy1002> Synchronized php-1.37.0-wmf.18/includes/specials/SpecialWhatLinksHere.php: Backport: [[gerrit:710719|Fix SelectQueryBuilder use in SpecialWhatLinksHere (T288565)]] (duration: 01m 08s)

Seems to be fixed now.

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.19; 2021-08-16).Aug 11 2021, 10:00 AM

Maintenance_bot removed a project: Patch-For-Review.Aug 11 2021, 10:10 AM

brennen mentioned this in T307037: DBQueryError: Error 1066: Not unique table/alias: 'page' ([db]) Function: SpecialExport::getLinksQuery.Apr 27 2022, 7:59 PM

Wikimedia\Rdbms\DBQueryError: Error 1066: Not unique table/alias: 'page' Closed, ResolvedPublicPRODUCTION ERRORActions