Page MenuHomePhabricator

Swap all our process logging to Civi::log('wmf') from watchdog()
Closed, ResolvedPublic4 Estimated Story Points

Description

We have some process control inconsistencies at the moment :-( and it's logging it all at the end

Note the monolog extension is what is outputting the Civi::log('wmf')

Relevant code

/**
  * Add FirePhp Logger.
  *
  * See https://firephp.org/
  *
  * @param string $channel
  * @param \Monolog\Logger $logger
  * @param string $minimumLevel
  * @param bool $isFinal
  *
  * @noinspection PhpUnusedParameterInspection
  */
 protected function addStdOutLogger(string $channel, Logger $logger, string $minimumLevel, bool $isFinal): void {
   if (PHP_SAPI === 'cli') {
     global $argv;
     // The wordpress handler has this rather nice idea of respecting command
     // line efforts to increase or decrease logging levels.
     $modifiers = [
       // Drush parameters https://groups.drupal.org/drush/commands
       '-v' =>  'notice',
       '--verbose' => 'notice',
       '--debug' => 'debug',
       '-d' => 'debug',
       '-q' => 'error',
       '--quiet' => 'error',
       // https://symfony.com/doc/current/logging/monolog_console.html
       '-vv' => 'info',
       '-vvv' => 'debug',
     ];
     foreach ($argv as $argument) {
       if (isset($modifiers[$argument])) {
         $minimumLevel = $modifiers[$argument];
       }
     }
     $formatter = new LineFormatter("%channel%.%level_name%: %message% %extra%", NULL, TRUE, TRUE);
     $handler = new StreamHandler('php://stdout', $minimumLevel, !$isFinal);
     $handler->setFormatter($formatter);
     $logger->pushHandler($handler);
   }
 }

Details

ProjectBranchLines +/-Subject
wikimedia/fundraising/crmmaster+12 -6
wikimedia/fundraising/crmmaster+0 -10
wikimedia/fundraising/crmmaster+2 -2
wikimedia/fundraising/crmmaster+0 -39
wikimedia/fundraising/crmmaster+9 -8
wikimedia/fundraising/crmmaster+10 -10
wikimedia/fundraising/crmmaster+7 -9
wikimedia/fundraising/crmmaster+9 -8
wikimedia/fundraising/crmmaster+2 -4
wikimedia/fundraising/crmmaster+22 -31
wikimedia/fundraising/crmmaster+7 -6
wikimedia/fundraising/crmmaster+8 -13
wikimedia/fundraising/crmmaster+4 -5
wikimedia/fundraising/crmmaster+4 -6
wikimedia/fundraising/crmmaster+10 -113
wikimedia/fundraising/crmmaster+3 -5
wikimedia/fundraising/crmmaster+22 -23
wikimedia/fundraising/crmmaster+1 -1
wikimedia/fundraising/crmmaster+1 -1
wikimedia/fundraising/crmmaster+7 -4
wikimedia/fundraising/crmmaster+2 -2
wikimedia/fundraising/crmmaster+20 -18
wikimedia/fundraising/crmmaster+6 -5
wikimedia/fundraising/crmmaster+8 -5
wikimedia/fundraising/crmmaster+31 -29
wikimedia/fundraising/crmmaster+6 -11
wikimedia/fundraising/crmmaster+4 -6
wikimedia/fundraising/crmmaster+5 -6
wikimedia/fundraising/crmmaster+2 -2
wikimedia/fundraising/crmmaster+33 -31
wikimedia/fundraising/crmmaster+7 -11
wikimedia/fundraising/crmmaster+6 -10
wikimedia/fundraising/crmmaster+5 -4
wikimedia/fundraising/crmmaster+4 -1
wikimedia/fundraising/crmmaster+2 -2
wikimedia/fundraising/crmmaster+2 -4
wikimedia/fundraising/crmmaster+6 -12
wikimedia/fundraising/crmmaster+8 -4
wikimedia/fundraising/crmmaster+9 -20
wikimedia/fundraising/crmmaster+14 -11
wikimedia/fundraising/crmmaster+10 -10
wikimedia/fundraising/crmmaster+16 -14
wikimedia/fundraising/crmmaster+2 -50
wikimedia/fundraising/crmmaster+5 -2
wikimedia/fundraising/crmmaster+167 -161
wikimedia/fundraising/crmmaster+44 -41
wikimedia/fundraising/crmmaster+7 -12
wikimedia/fundraising/crmmaster+3 -3
wikimedia/fundraising/crmmaster+55 -53
wikimedia/fundraising/crmmaster+3 -4
wikimedia/fundraising/crmmaster+16 -3
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 892591 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Update OptInQueueConsumer to use Civi::log

https://gerrit.wikimedia.org/r/892591

Change 892592 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Reformat code prior to any actual changes

https://gerrit.wikimedia.org/r/892592

Change 893095 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove drupal functions from our exception class

https://gerrit.wikimedia.org/r/893095

Change 892559 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Reformat code, preliminary to code fix

https://gerrit.wikimedia.org/r/892559

Change 892560 abandoned by Eileen:

[wikimedia/fundraising/crm@master] Replace watchdog calls in exchange_rates_module

Reason:

https://gerrit.wikimedia.org/r/892560

Change 894759 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Convert merge to Civi::log

https://gerrit.wikimedia.org/r/894759

Change 892596 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove old exchange_rates_backfill function

https://gerrit.wikimedia.org/r/892596

Change 892600 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Replace watchdog with Civi::log

https://gerrit.wikimedia.org/r/892600

Change 895372 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove call to watchdog by removing call to legacy civicrm_api_class()

https://gerrit.wikimedia.org/r/895372

Change 895372 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove call to watchdog by removing call to legacy civicrm_api_class()

https://gerrit.wikimedia.org/r/895372

Change 895866 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Replace more watchdogs, add a couple of type hints

https://gerrit.wikimedia.org/r/895866

Change 895873 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Fully remove wmf_get_civi_id

https://gerrit.wikimedia.org/r/895873

Change 894759 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Convert merge to Civi::log

https://gerrit.wikimedia.org/r/894759

Change 895866 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Replace more watchdogs, add a couple of type hints

https://gerrit.wikimedia.org/r/895866

Change 897976 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove watchdogs from templating

https://gerrit.wikimedia.org/r/897976

Change 897977 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove some more watchdogs

https://gerrit.wikimedia.org/r/897977

Change 897978 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove more watchdogs

https://gerrit.wikimedia.org/r/897978

Change 897979 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove more watchdogs

https://gerrit.wikimedia.org/r/897979

Change 897983 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove watchdogs, wmf_audit

https://gerrit.wikimedia.org/r/897983

Change 897984 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove watchdogs, wmf_than_you

https://gerrit.wikimedia.org/r/897984

Change 897986 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove watchdog from BannerHistoryQueueConsumer

https://gerrit.wikimedia.org/r/897986

Change 897987 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove watchdog from PaymentsInitQueueConsumer

https://gerrit.wikimedia.org/r/897987

Change 897990 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove watchdog from drush script + reformat

https://gerrit.wikimedia.org/r/897990

Change 897991 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove some watchdogs from drush scripts

https://gerrit.wikimedia.org/r/897991

Change 897995 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove watchdogs from wmf_ct_qc.module

https://gerrit.wikimedia.org/r/897995

Change 898001 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove watchdog from Oanda retriever

https://gerrit.wikimedia.org/r/898001

Change 898002 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove watchdog from large donation module

https://gerrit.wikimedia.org/r/898002

Change 898003 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Apply CiviCRM formatting standard to offline2civicrm.common.inc

https://gerrit.wikimedia.org/r/898003

Change 898004 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Swap out watchdog from offline2civicrm

https://gerrit.wikimedia.org/r/898004

Change 898026 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove watchdog from orphan_slayer

https://gerrit.wikimedia.org/r/898026

Change 898032 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove watchdog from AntiFraudConsumer

https://gerrit.wikimedia.org/r/898032

Change 898033 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Apply CiviCRM code formatting (no other change)

https://gerrit.wikimedia.org/r/898033

Change 898034 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove watchdog from banner_history_queue_consume

https://gerrit.wikimedia.org/r/898034

Change 898035 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove watchdog from wmf_optin

https://gerrit.wikimedia.org/r/898035

Change 898002 merged by AndyRussG:

[wikimedia/fundraising/crm@master] Remove watchdog from large donation module

https://gerrit.wikimedia.org/r/898002

Change 897976 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove watchdogs from templating

https://gerrit.wikimedia.org/r/897976

Change 897977 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove some more watchdogs

https://gerrit.wikimedia.org/r/897977

Change 897978 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove more watchdogs

https://gerrit.wikimedia.org/r/897978

Change 897979 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove more watchdogs

https://gerrit.wikimedia.org/r/897979

Change 897983 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove watchdogs, wmf_audit

https://gerrit.wikimedia.org/r/897983

Change 897984 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove watchdogs, wmf_than_you

https://gerrit.wikimedia.org/r/897984

Change 898032 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove watchdog from AntiFraudConsumer

https://gerrit.wikimedia.org/r/898032

Change 898033 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Apply CiviCRM code formatting (no other change)

https://gerrit.wikimedia.org/r/898033

Change 898034 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove watchdog from banner_history_queue_consume

https://gerrit.wikimedia.org/r/898034

Change 898035 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove watchdog from wmf_optin

https://gerrit.wikimedia.org/r/898035

Change 897986 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove watchdog from BannerHistoryQueueConsumer

https://gerrit.wikimedia.org/r/897986

Change 897987 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove watchdog from PaymentsInitQueueConsumer

https://gerrit.wikimedia.org/r/897987

Change 897990 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove watchdog from drush script + reformat

https://gerrit.wikimedia.org/r/897990

Change 897991 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove some watchdogs from drush scripts

https://gerrit.wikimedia.org/r/897991

Change 897995 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove watchdogs from wmf_ct_qc.module

https://gerrit.wikimedia.org/r/897995

Change 898003 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Apply CiviCRM formatting standard to offline2civicrm.common.inc

https://gerrit.wikimedia.org/r/898003

Change 898004 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Swap out watchdog from offline2civicrm

https://gerrit.wikimedia.org/r/898004

Change 898026 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove watchdog from orphan_slayer

https://gerrit.wikimedia.org/r/898026

Change 898001 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove watchdog from Oanda retriever

https://gerrit.wikimedia.org/r/898001

Change 902217 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove more watchdogs in wmf_civicrm

https://gerrit.wikimedia.org/r/902217

Change 902218 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove more watchdogs from civicrm_module

https://gerrit.wikimedia.org/r/902218

Change 902219 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove more watchdogs from civicrm_module

https://gerrit.wikimedia.org/r/902219

Change 902221 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove watchdog from failmail

https://gerrit.wikimedia.org/r/902221

Change 902217 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove more watchdogs in wmf_civicrm

https://gerrit.wikimedia.org/r/902217

Change 902218 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove more watchdogs from civicrm_module

https://gerrit.wikimedia.org/r/902218

Change 902221 merged by Eileen:

[wikimedia/fundraising/crm@master] Remove watchdog from failmail

https://gerrit.wikimedia.org/r/902221

Change 903339 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove watchdoc from queue2civicrm

https://gerrit.wikimedia.org/r/903339

Change 903344 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove qatchdog from UnsubscribeQueueConsumer

https://gerrit.wikimedia.org/r/903344

Change 903346 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove watchdog from RefundQueueConsumer

https://gerrit.wikimedia.org/r/903346

Change 903347 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove watchdog from WMFQueueConsumer

https://gerrit.wikimedia.org/r/903347

Change 903349 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove watchdog from RecurringQueueConsumer

https://gerrit.wikimedia.org/r/903349

Change 903350 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove watchdog from civicrm_cleanup_old_deleted_contacts

https://gerrit.wikimedia.org/r/903350

Change 903352 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove watching from recurring.module

https://gerrit.wikimedia.org/r/903352

Change 903353 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove watchdog from recurring.inc

https://gerrit.wikimedia.org/r/903353

Change 903354 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove watchdog from wmf_fredge

https://gerrit.wikimedia.org/r/903354

Change 903355 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove watchdog from queue2civicrm_common

https://gerrit.wikimedia.org/r/903355

Change 903356 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove watchdog handling from our BaseTestClass

https://gerrit.wikimedia.org/r/903356

Change 903357 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove watchdog from tracking.inc

https://gerrit.wikimedia.org/r/903357

Change 895873 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Fully remove wmf_get_civi_id

https://gerrit.wikimedia.org/r/895873

Change 902219 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove more watchdogs from civicrm_module

https://gerrit.wikimedia.org/r/902219

Change 903339 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove watchdoc from queue2civicrm

https://gerrit.wikimedia.org/r/903339

Change 903344 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove watchdog from UnsubscribeQueueConsumer

https://gerrit.wikimedia.org/r/903344

Change 903346 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove watchdog from RefundQueueConsumer

https://gerrit.wikimedia.org/r/903346

Change 903347 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove watchdog from WMFQueueConsumer

https://gerrit.wikimedia.org/r/903347

Change 903349 merged by Eileen:

[wikimedia/fundraising/crm@master] Remove watchdog from RecurringQueueConsumer

https://gerrit.wikimedia.org/r/903349

Change 903350 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove watchdog from civicrm_cleanup_old_deleted_contacts

https://gerrit.wikimedia.org/r/903350

Change 903352 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove watching from recurring.module

https://gerrit.wikimedia.org/r/903352

Change 903353 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove watchdog from recurring.inc

https://gerrit.wikimedia.org/r/903353

Change 903354 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove watchdog from wmf_fredge

https://gerrit.wikimedia.org/r/903354

Change 903355 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove watchdog from queue2civicrm_common

https://gerrit.wikimedia.org/r/903355

Change 903356 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove watchdog handling from our BaseTestClass

https://gerrit.wikimedia.org/r/903356

Change 903357 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove watchdog from tracking.inc

https://gerrit.wikimedia.org/r/903357

Change 893095 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove drupal functions from our exception class

https://gerrit.wikimedia.org/r/893095