Page MenuHomePhabricator
Create Task
Maniphest T288636

With VisualEditor enabled, when you navigate revisions, the address bar URL bounces back
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce:

  1. Go to https://ru.wikipedia.org/w/index.php?title=Иванов,_Валентин_Дмитриевич&diff=116003785&oldid=116003248&uselang=en while being logged on and having VisualEditor enabled.
  2. Expand RevisionSlider.
  3. Click "Older edit ←".

What happens?:

  1. The URL in the address bar changes to https://ru.wikipedia.org/w/index.php?diff=116003248&oldid=116002121&title=Иванов,_Валентин_Дмитриевич&uselang=en&diffmode=source.
  2. But then it reverts to https://ru.wikipedia.org/w/index.php?title=Иванов,_Валентин_Дмитриевич&diff=116003785&oldid=116003248&uselang=en&diffmode=source.
  3. As a result, if you refresh the page, you will see the original revision that you opened, not the one you navigated to.

What should have happened instead?:
The URL reversion shouldn't happen.

Why it happens?
I've debugged a bit, and the immediate reason of the reversion is this line of code: https://phabricator.wikimedia.org/diffusion/EVED/browse/master/modules/ve-mw/preinit/ve.init.mw.DiffPage.init.js$95.

history.replaceState( '', document.title, uri );

This code is part of the onReviewModeButtonSelectSelect function related to this button group:

image.png (48×208 px, 1 KB)

This happens only in wikis that have this button on diff pages (I guess this means VisualEditor enabled).

Details

SubjectRepoBranchLines +/-
Fix history.replaceState call on diff pagesmediawiki/extensions/VisualEditormaster+5 -4
Customize query in gerrit

Related Objects

Event Timeline

Jack_who_built_the_house created this task.Aug 11 2021, 5:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 11 2021, 5:26 PM
Jack_who_built_the_house updated the task description. (Show Details)Aug 11 2021, 5:28 PM
Jack_who_built_the_house updated the task description. (Show Details)Aug 12 2021, 2:07 AM
Jack_who_built_the_house added a project: VisualEditor.EditedAug 12 2021, 2:15 AM

This is also the reason why using the browser's "Back" button causes an issue. If you do everything I outlined in the "Steps to reproduce" section, then

  1. go to the table of contents,
  2. click some link in it,
  3. click "Back" in the browser,
  4. and then click "Newer edit →",

this will not work (you will stay with the same diff) and you will get https://ru.wikipedia.org/w/index.php?diff=NaN&oldid=NaN&title=Иванов,_Валентин_Дмитриевич&uselang=en&diffmode=source as the URL.

In case VisualEditor is to blame here I'll tag it too. (To be honest, that history.replaceState has always been annoying given that it altered the URL, adding diffmode= and making the URL longer, for no apparent reason.)

SerDIDG subscribed.Aug 12 2021, 2:20 AM
putnik subscribed.Aug 12 2021, 1:23 PM
matmarex subscribed.Aug 12 2021, 1:32 PM

Since you've already debugged the issue, would you like to submit a patch to Gerrit? I'd be very happy to review and approve it. Looks like we just need to use a new mw.Uri object every time onReviewModeButtonSelectSelect() is called, to allow for other tools like RevisionSlider changing the page's URL, instead of always using the same object constructed on page load.

matmarex added a comment.Aug 12 2021, 1:33 PM

Also, this is probably the same issue as T260186.

• ppelberg added a project: Editing-team (Tracking).Aug 12 2021, 3:08 PM
• ppelberg moved this task from To Triage to Triaged on the VisualEditor board.
• ppelberg moved this task from Backlog to External on the Editing-team (Tracking) board.
Jack_who_built_the_house added a comment.Aug 13 2021, 6:48 AM

would you like to submit a patch to Gerrit

OK, today or tomorrow.

gerritbot added a comment.Aug 14 2021, 10:37 AM

Change 713039 had a related patch set uploaded (by Jack who built the house; author: Jack who built the house):

[mediawiki/extensions/VisualEditor@master] Fix history.replaceState call on diff pages

https://gerrit.wikimedia.org/r/713039

gerritbot added a project: Patch-For-Review.Aug 14 2021, 10:37 AM
Jack_who_built_the_house added a comment.EditedAug 14 2021, 10:52 AM

(These are in fact 2 thematically related changes that affect the same line of code, which is why I submitted them as a single patch. They can be split into two patches though if desirable.)

matmarex merged a task: T260186: Incorrect browser URL when viewing diffs and visual differences.Aug 14 2021, 11:14 PM
matmarex added a project: VisualEditor-VisualDiffs.
matmarex added subscribers: Ivi104, Masumrezarock100, rugk, WMDE-Fisch.
gerritbot added a comment.Aug 14 2021, 11:30 PM

Change 713039 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix history.replaceState call on diff pages

https://gerrit.wikimedia.org/r/713039

matmarex assigned this task to Jack_who_built_the_house.Aug 14 2021, 11:32 PM

Thank you for the fix @Jack_who_built_the_house!

matmarex edited projects, added Editing-team (Kanban Board); removed Editing-team (Tracking).Aug 14 2021, 11:32 PM
matmarex moved this task from Incoming to Ready for Sign Off on the Editing-team (Kanban Board) board.
matmarex edited projects, added Skipped QA; removed Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.19; 2021-08-16).Aug 15 2021, 12:00 AM
• ppelberg closed this task as Resolved.Aug 18 2021, 3:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL