[Notifications] Update display logic for notifications bell state
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Dmantena
	Aug 11 2021, 8:39 PM

Description

Update the bell button's image depending on available notifications.

This task concerns the Bell button visible when logged in and on the Explore feed or when logged in and on the root Settings view if the Explore feed is turned off
Show in indicated notification available state as requested by app
Show in un-indicated plain state as requested by app

Engineering Needs:
[1] The UI needs API on the Notifications Data Controller to interact with here
[2] What is the mechanism for triggering a state change (Explore/Settings root view appearance, notification, etc.)?

Dependencies

https://phabricator.wikimedia.org/T287298
https://phabricator.wikimedia.org/T288654

Related Objects
Search...

Status	Assigned	Task
Open	None	T278838 Mobile user communication issues ([[Wikipedia:Mobile communication bugs]])
Resolved	• JMinor	T274404 Support notifications on the iOS app
Resolved	• JMinor	T287308 Notification Center UI
Resolved	• JMinor	T288669 [Notifications] Update display logic for notifications bell state

Event Timeline

• Dmantena created this task.Aug 11 2021, 8:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 11 2021, 8:39 PM

• Dmantena triaged this task as Medium priority.Aug 11 2021, 11:47 PM

• Dmantena moved this task from Tasks from Product Backlog to Needs Engineering Sync on the iOS-app-v6.9-Carp-On-A-Zamboni board.

LGoto moved this task from Needs Triage to Product Backlog on the Wikipedia-iOS-App-Backlog board.Aug 16 2021, 6:48 PM

• Dmantena mentioned this in T288652: [Notifications] Add "Bell" button to navigation bar.Aug 18 2021, 8:49 PM

Per planning - refresh when this icon is seen (foreground, switch back to explore, etc.). Ok if there's a 30 second timeout.

Looks like I missed posting some past engineering sync notes:

We will have a hook on push notification receipt (if permissions are enabled), so we can easily trigger a notifications data refresh (& thus badge state) when we already know there's new data. And of course we'll refresh when they navigate themselves to the app navigation center.

Given that, a refresh on every Explore appearance even with a 30 second timeout seems a bit heavy handed - can we bump this up? Just to be good API citizens.

Tsevener updated the task description. (Show Details)Sep 10 2021, 2:37 PM

Tsevener mentioned this in T288694: [Notifications] Add app icon badging.Sep 10 2021, 2:40 PM

Tsevener updated the task description. (Show Details)Sep 10 2021, 9:32 PM

Engineering sync notes:

We agree that we should immediately trigger a badge refresh upon foreground (and, obviously, upon a launch from terminate state).
For a refresh on appearance of the badge, that could be rather often (probably in viewDidAppear of Explore or Settings). Because this could happen so rapidly my early thoughts that we attempt to refresh the badge on this lifecycle call, but internally within a controller, have it silently fail and not attempt if it's been less than 30 seconds since the last time it refreshed the badge. This area is still up for discussion, to be continued when we pick it up for development.