Page MenuHomePhabricator
Create Task
Maniphest T288671

PHP Warning: First parameter must either be an object or the name of an existing class
Closed, ResolvedPublic1 Estimated Story PointsPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Warning: First parameter must either be an object or the name of an existing class
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.18/extensions/Kartographer/includes/SimpleStyleParser.php(131)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.37.0-wmf.18/extensions/Kartographer/includes/SimpleStyleParser.php(131): property_exists(double, string)
#2 /srv/mediawiki/php-1.37.0-wmf.18/extensions/Kartographer/includes/SimpleStyleParser.php(136): Kartographer\SimpleStyleParser::doCountersRecursive(array, stdClass)
#3 /srv/mediawiki/php-1.37.0-wmf.18/extensions/Kartographer/includes/Tag/TagHandler.php(283): Kartographer\SimpleStyleParser::doCountersRecursive(array, stdClass)
#4 /srv/mediawiki/php-1.37.0-wmf.18/extensions/Kartographer/includes/Tag/TagHandler.php(128): Kartographer\Tag\TagHandler->saveData()
#5 /srv/mediawiki/php-1.37.0-wmf.18/extensions/Kartographer/includes/Tag/TagHandler.php(95): Kartographer\Tag\TagHandler->handle(string, array, Parser, PPFrame_Hash)
#6 /srv/mediawiki/php-1.37.0-wmf.18/includes/parser/Parser.php(3966): Kartographer\Tag\TagHandler::entryPoint(string, array, Parser, PPFrame_Hash)
#7 /srv/mediawiki/php-1.37.0-wmf.18/includes/parser/PPFrame_Hash.php(351): Parser->extensionSubstitution(array, PPFrame_Hash)
#8 /srv/mediawiki/php-1.37.0-wmf.18/includes/parser/Parser.php(2923): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#9 /srv/mediawiki/php-1.37.0-wmf.18/includes/parser/Parser.php(1591): Parser->replaceVariables(string)
#10 /srv/mediawiki/php-1.37.0-wmf.18/includes/parser/Parser.php(652): Parser->internalParse(string)
#11 /srv/mediawiki/php-1.37.0-wmf.18/includes/content/WikitextContent.php(345): Parser->parse(string, Title, ParserOptions, boolean, boolean, NULL)
#12 /srv/mediawiki/php-1.37.0-wmf.18/includes/content/AbstractContent.php(540): WikitextContent->fillParserOutput(Title, NULL, ParserOptions, boolean, ParserOutput)
#13 /srv/mediawiki/php-1.37.0-wmf.18/includes/Revision/RenderedRevision.php(266): AbstractContent->getParserOutput(Title, NULL, ParserOptions, boolean)
#14 /srv/mediawiki/php-1.37.0-wmf.18/includes/Revision/RenderedRevision.php(235): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(WikitextContent, boolean)
#15 /srv/mediawiki/php-1.37.0-wmf.18/includes/Revision/RevisionRenderer.php(217): MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string, array)
#16 /srv/mediawiki/php-1.37.0-wmf.18/includes/Revision/RevisionRenderer.php(154): MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, array)
#17 [internal function]: MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}(MediaWiki\Revision\RenderedRevision, array)
#18 /srv/mediawiki/php-1.37.0-wmf.18/includes/Revision/RenderedRevision.php(197): call_user_func(Closure, MediaWiki\Revision\RenderedRevision, array)
#19 /srv/mediawiki/php-1.37.0-wmf.18/includes/Storage/DerivedPageDataUpdater.php(1354): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#20 [internal function]: MediaWiki\Storage\DerivedPageDataUpdater->getCanonicalParserOutput()
#21 /srv/mediawiki/php-1.37.0-wmf.18/includes/edit/PreparedEdit.php(104): call_user_func(array)
#22 /srv/mediawiki/php-1.37.0-wmf.18/includes/edit/PreparedEdit.php(119): MediaWiki\Edit\PreparedEdit->getOutput()
#23 /srv/mediawiki/php-1.37.0-wmf.18/includes/Storage/DerivedPageDataUpdater.php(1332): MediaWiki\Edit\PreparedEdit->__get(string)
#24 /srv/mediawiki/php-1.37.0-wmf.18/includes/page/WikiPage.php(2132): MediaWiki\Storage\DerivedPageDataUpdater->getPreparedEdit()
#25 /srv/mediawiki/php-1.37.0-wmf.18/includes/Storage/PageEditStash.php(148): WikiPage->prepareContentForEdit(WikitextContent, NULL, User, string, boolean)
#26 /srv/mediawiki/php-1.37.0-wmf.18/includes/api/ApiStashEdit.php(198): MediaWiki\Storage\PageEditStash->parseAndCache(WikiPage, WikitextContent, User, string)
#27 /srv/mediawiki/php-1.37.0-wmf.18/includes/api/ApiMain.php(1842): ApiStashEdit->execute()
#28 /srv/mediawiki/php-1.37.0-wmf.18/includes/api/ApiMain.php(821): ApiMain->executeAction()
#29 /srv/mediawiki/php-1.37.0-wmf.18/includes/api/ApiMain.php(792): ApiMain->executeActionWithErrorHandling()
#30 /srv/mediawiki/php-1.37.0-wmf.18/api.php(90): ApiMain->execute()
#31 /srv/mediawiki/php-1.37.0-wmf.18/api.php(45): wfApiMain()
#32 /srv/mediawiki/w/api.php(3): require(string)
#33 {main}
Impact

16 times in the last 30 min on plwiki

Notes

Details

Request URL
https://pl.wikimedia.org/w/api.php
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Guard non-critical code agains unexpected user inputmediawiki/extensions/Kartographermaster+13 -10
Customize query in gerrit

Event Timeline

jeena created this task.Aug 11 2021, 8:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 11 2021, 8:46 PM
Reedy added a project: Maps (Kartographer).Aug 11 2021, 9:15 PM
MSantos claimed this task.Aug 12 2021, 7:38 AM
MSantos added a project: Product-Infrastructure-Team-Backlog-Deprecated.
MSantos moved this task from Needs triage to Needs investigation on the Product-Infrastructure-Team-Backlog-Deprecated board.
Zabe moved this task from Untriaged to Aug 2021 on the Wikimedia-production-error board.Aug 13 2021, 8:40 PM
TheDJ subscribed.Oct 28 2021, 9:02 PM

So these are only PHP warnings right ???
Should be fixable by making use of isset instead of property_exists I think ?

dancy subscribed.Feb 3 2022, 6:22 PM

A burst of 36 of these occurred today:

Error
normalized_message
[{reqId}] {exception_url}   PHP Warning: First parameter must either be an object or the name of an existing class
exception.trace
from /srv/mediawiki/php-1.38.0-wmf.19/extensions/Kartographer/includes/SimpleStyleParser.php(131)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.38.0-wmf.19/extensions/Kartographer/includes/SimpleStyleParser.php(131): property_exists(double, string)
#2 /srv/mediawiki/php-1.38.0-wmf.19/extensions/Kartographer/includes/SimpleStyleParser.php(136): Kartographer\SimpleStyleParser::updateMarkerSymbolCounters(array, array)
#3 /srv/mediawiki/php-1.38.0-wmf.19/extensions/Kartographer/includes/Tag/TagHandler.php(291): Kartographer\SimpleStyleParser::updateMarkerSymbolCounters(array, array)
#4 /srv/mediawiki/php-1.38.0-wmf.19/extensions/Kartographer/includes/Tag/TagHandler.php(137): Kartographer\Tag\TagHandler->saveData()
#5 /srv/mediawiki/php-1.38.0-wmf.19/extensions/Kartographer/includes/Tag/TagHandler.php(102): Kartographer\Tag\TagHandler->handle(string, array, Parser, PPFrame_Hash)
#6 /srv/mediawiki/php-1.38.0-wmf.19/includes/parser/Parser.php(3955): Kartographer\Tag\TagHandler::entryPoint(string, array, Parser, PPFrame_Hash)
#7 /srv/mediawiki/php-1.38.0-wmf.19/includes/parser/PPFrame_Hash.php(353): Parser->extensionSubstitution(array, PPFrame_Hash)
#8 /srv/mediawiki/php-1.38.0-wmf.19/includes/parser/Parser.php(2908): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#9 /srv/mediawiki/php-1.38.0-wmf.19/includes/parser/Parser.php(1572): Parser->replaceVariables(string)
#10 /srv/mediawiki/php-1.38.0-wmf.19/includes/parser/Parser.php(690): Parser->internalParse(string)
#11 /srv/mediawiki/php-1.38.0-wmf.19/includes/content/WikitextContentHandler.php(294): Parser->parse(string, Title, ParserOptions, boolean, boolean, NULL)
#12 /srv/mediawiki/php-1.38.0-wmf.19/includes/content/ContentHandler.php(1723): WikitextContentHandler->fillParserOutput(WikitextContent, MediaWiki\Content\Renderer\ContentParseParams, ParserOutput)
#13 /srv/mediawiki/php-1.38.0-wmf.19/includes/content/Renderer/ContentRenderer.php(47): ContentHandler->getParserOutput(WikitextContent, MediaWiki\Content\Renderer\ContentParseParams)
#14 /srv/mediawiki/php-1.38.0-wmf.19/includes/Revision/RenderedRevision.php(271): MediaWiki\Content\Renderer\ContentRenderer->getParserOutput(WikitextContent, Title, NULL, ParserOptions, boolean)
#15 /srv/mediawiki/php-1.38.0-wmf.19/includes/Revision/RenderedRevision.php(238): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(WikitextContent, boolean)
#16 /srv/mediawiki/php-1.38.0-wmf.19/includes/Revision/RevisionRenderer.php(221): MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string, array)
#17 /srv/mediawiki/php-1.38.0-wmf.19/includes/Revision/RevisionRenderer.php(158): MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, array)
#18 [internal function]: MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}(MediaWiki\Revision\RenderedRevision, array)
#19 /srv/mediawiki/php-1.38.0-wmf.19/includes/Revision/RenderedRevision.php(200): call_user_func(Closure, MediaWiki\Revision\RenderedRevision, array)
#20 /srv/mediawiki/php-1.38.0-wmf.19/includes/Storage/DerivedPageDataUpdater.php(1389): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#21 /srv/mediawiki/php-1.38.0-wmf.19/includes/Storage/PageEditStash.php(165): MediaWiki\Storage\DerivedPageDataUpdater->getCanonicalParserOutput()
#22 /srv/mediawiki/php-1.38.0-wmf.19/includes/api/ApiStashEdit.php(199): MediaWiki\Storage\PageEditStash->parseAndCache(MediaWiki\Storage\PageUpdater, WikitextContent, User, string)
#23 /srv/mediawiki/php-1.38.0-wmf.19/includes/api/ApiMain.php(1889): ApiStashEdit->execute()
#24 /srv/mediawiki/php-1.38.0-wmf.19/includes/api/ApiMain.php(868): ApiMain->executeAction()
#25 /srv/mediawiki/php-1.38.0-wmf.19/includes/api/ApiMain.php(839): ApiMain->executeActionWithErrorHandling()
#26 /srv/mediawiki/php-1.38.0-wmf.19/api.php(90): ApiMain->execute()
#27 /srv/mediawiki/php-1.38.0-wmf.19/api.php(45): wfApiMain()
#28 /srv/mediawiki/w/api.php(3): require(string)
#29 {main}
thiemowmde added a project: WMDE-TechWish-Maintenance.Feb 4 2022, 3:18 PM
gerritbot added a comment.Feb 4 2022, 3:38 PM

Change 759720 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Guard non-critical code agains unexpected user input

https://gerrit.wikimedia.org/r/759720

gerritbot added a project: Patch-For-Review.Feb 4 2022, 3:38 PM
thiemowmde claimed this task.Feb 4 2022, 3:39 PM
thiemowmde added projects: WMDE-TechWish-Sprint-2022-02-02, Unplanned-Sprint-Work.
thiemowmde set the point value for this task to 1.
thiemowmde moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2022-02-02 board.
thiemowmde moved this task from Incoming to In progress on the WMDE-TechWish-Maintenance board.
thiemowmde added a subscriber: MSantos.
gerritbot added a comment.Feb 6 2022, 9:33 PM

Change 759720 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Guard non-critical code agains unexpected user input

https://gerrit.wikimedia.org/r/759720

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.21; 2022-02-07).Feb 6 2022, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 6 2022, 10:10 PM
thiemowmde moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2022-02-02 board.Feb 7 2022, 8:11 AM
dancy unsubscribed.Feb 7 2022, 4:00 PM
thiemowmde closed this task as Resolved.Feb 15 2022, 9:29 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits